all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Ingo Lohmar <i.lohmar@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 397e316: Add option `calendar-weekend-days'
Date: Tue, 04 Aug 2015 11:43:42 -0400	[thread overview]
Message-ID: <0qr3njdpox.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87mvy88ikq.fsf@acer.localhost.com> (Ingo Lohmar's message of "Mon, 03 Aug 2015 18:04:05 +0200")


It's no problem, don't worry about it.

Adding a missing commit message to a later commit, like in 4e1bdd44,
where you added a commit log for lisp/calendar/calendar.el, which wasn't
changed at all in that change, isn't the right way to correct things
though. It just causes confusion when reading the git log, and now there
will be three entries for this change in the generated ChangeLog. What
you are supposed to do is (from admin/notes/repo) run 'make
change-history' (or wait till Sunday when that happens automatically),
then edit ChangeLog.2 to correct it and commit it. Feel free to correct
any of the docs if there was something that would have made this stuff
clearer to you. (You're not the first person to edit ChangeLog.2 by hand.)

Wrt doc/emacs/calendar.texi, you're missing a final ".". at the end of
the sentence you added. (I'm not sure this was worth adding, since the
header faces aren't even mentioned in the manual. Not everything needs
to be. Which calendar systems even have something other than two
consecutive weekend days?)



  reply	other threads:[~2015-08-04 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150802153051.8158.16904@vcs.savannah.gnu.org>
     [not found] ` <E1ZLvDv-00028C-QB@vcs.savannah.gnu.org>
2015-08-03 15:44   ` master 397e316: Add option `calendar-weekend-days' Glenn Morris
2015-08-03 16:04     ` Ingo Lohmar
2015-08-04 15:43       ` Glenn Morris [this message]
2015-08-04 16:01         ` Ingo Lohmar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0qr3njdpox.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=i.lohmar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.