From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 b6d6304: Comment on last change to define-derived-mode
Date: Fri, 4 Mar 2016 18:10:17 +0200 [thread overview]
Message-ID: <0ff1a53d-bbdf-7393-5462-516c89a582d8@yandex.ru> (raw)
In-Reply-To: <jwvio12z5d4.fsf-monnier+gmane.emacs.devel@gnu.org>
On 03/04/2016 04:26 PM, Stefan Monnier wrote:
>>> That should at least give one example where adding (indent 3) hurts.
>> define-derived-mode is available since at least emacs 22.1 without any
>> (indent N) settings. I think maybe it is better to think in the other
>> direction that is what does (indent 3) bring to the table?
>
> That's irrelevant to the issue of having to documenting *why* you
> revert something.
Putting a code sample into the comment right there would be pretty
awkward, though. I'd rather see a message to emacs-devel or a bug
report, and a link to either in the reverting commit.
In this case, though, maybe we should revert the revert, all things
considered.
next prev parent reply other threads:[~2016-03-04 16:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160301035146.26012.60163@vcs.savannah.gnu.org>
[not found] ` <E1aabLe-0006mA-65@vcs.savannah.gnu.org>
2016-03-01 14:24 ` [Emacs-diffs] emacs-25 b6d6304: Comment on last change to define-derived-mode Stefan Monnier
2016-03-03 1:36 ` Leo Liu
2016-03-03 8:19 ` Oleh Krehel
2016-03-03 14:55 ` Kaushal Modi
2016-03-04 14:26 ` Stefan Monnier
2016-03-04 16:10 ` Dmitry Gutov [this message]
2016-03-05 2:09 ` Leo Liu
2016-03-05 3:11 ` Dmitry Gutov
2016-03-05 9:48 ` Leo Liu
2016-03-05 13:32 ` Dmitry Gutov
2016-03-05 14:41 ` Leo Liu
2016-03-05 14:51 ` Dmitry Gutov
[not found] ` <8760x16nag.fsf@oremacs.com>
2016-03-05 14:50 ` Dmitry Gutov
2016-03-06 2:58 ` John Wiegley
2016-03-06 7:22 ` Oleh Krehel
2016-03-06 21:01 ` John Wiegley
2016-03-07 4:10 ` Leo Liu
2016-03-07 8:48 ` Oleh Krehel
2016-03-07 14:51 ` John Wiegley
2016-03-07 15:26 ` Oleh Krehel
2016-03-07 15:43 ` Clément Pit--Claudel
2016-03-07 15:59 ` Oleh Krehel
2016-03-07 16:03 ` Drew Adams
2016-03-07 16:11 ` Clément Pit--Claudel
2016-03-07 17:00 ` Drew Adams
2016-03-07 16:03 ` Drew Adams
2016-03-08 15:32 ` Thierry Volpiatto
2016-03-07 15:44 ` John Wiegley
2016-03-07 15:58 ` Oleh Krehel
2016-03-07 16:01 ` Dmitry Gutov
2016-03-08 4:35 ` Stefan Monnier
2016-03-08 12:33 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ff1a53d-bbdf-7393-5462-516c89a582d8@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.