From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20625: 25.0.50; doc of `define-error` is incorrect Date: Sat, 23 May 2015 09:22:40 -0700 (PDT) Message-ID: <0fec8ff5-ea94-442e-a00a-8b75f054f8af@default> References: > <83382n38et.fsf@gnu.org>> <10eb5733-c84c-491d-86ca-2d6a05b80e7d@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1432398208 23379 80.91.229.3 (23 May 2015 16:23:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 May 2015 16:23:28 +0000 (UTC) Cc: 20625@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 23 18:23:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YwCCg-0006zt-NP for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 May 2015 18:23:14 +0200 Original-Received: from localhost ([::1]:38127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwCCf-0003Gy-Rs for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 May 2015 12:23:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwCCY-0003Cy-Gg for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:23:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YwCCU-0006JY-Gh for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:23:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwCCU-0006JU-E0 for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YwCCU-0005q5-6U for bug-gnu-emacs@gnu.org; Sat, 23 May 2015 12:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 May 2015 16:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20625-submit@debbugs.gnu.org id=B20625.143239817822431 (code B ref 20625); Sat, 23 May 2015 16:23:02 +0000 Original-Received: (at 20625) by debbugs.gnu.org; 23 May 2015 16:22:58 +0000 Original-Received: from localhost ([127.0.0.1]:54114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwCCL-0005pf-RP for submit@debbugs.gnu.org; Sat, 23 May 2015 12:22:58 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:43518) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwCCG-0005pP-7B for 20625@debbugs.gnu.org; Sat, 23 May 2015 12:22:52 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t4NGMe58027976 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 23 May 2015 16:22:41 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t4NGMdLJ025855 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 23 May 2015 16:22:40 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t4NGMdYF027682; Sat, 23 May 2015 16:22:39 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103113 Archived-At: > > In fact, I think that the right change would be not only > > to say what nil MESSAGE means but to make MESSAGE an > > &optional parameter. >=20 > I disagree. The bookmark.el code is just a historical accident. Then please remove it. Either this is an intended feature or it is not. If you don't want `define-error` to provide exactly the same thing that you can get by using property `error-conditions' directly, then leave its definition and doc as they are, but change the `bookmark.el' code back to using `error-conditions' directly, so any code that expects error condition `bookmark-errors' to be available will not be surprised. Or remove it from bookmark.el altogether, if you don't care about such backward compatibility. Or provide a MESSAGE arg for the definition of `bookmark-errors'. One way or another, the doc and behavior should match, and bookmark.el should be made coherent with both.