From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24239: 25.1; Potential regression: Multibyte text in HTTP request Date: Wed, 17 Aug 2016 04:32:24 +0300 Message-ID: <0f709753-d7d8-c2ab-f8c2-19ff87316d60@yandex.ru> References: <877fbhc109.fsf@cassou.me> <87twel6xl5.fsf@cassou.me> <5c4a3484-735b-10df-8fe9-89323fbe43c3@yandex.ru> <83bn0sg3kp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1471397601 30203 195.159.176.226 (17 Aug 2016 01:33:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 17 Aug 2016 01:33:21 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 Cc: damien@cassou.me, 24239@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 17 03:33:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZpjJ-0007ew-E2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Aug 2016 03:33:17 +0200 Original-Received: from localhost ([::1]:44716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpjG-0006VG-Jy for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Aug 2016 21:33:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpj8-0006Tv-Ht for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 21:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZpj4-0004Za-AF for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 21:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZpj4-0004ZW-71 for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 21:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bZpj3-0001mp-Sc for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2016 21:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2016 01:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24239 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24239-submit@debbugs.gnu.org id=B24239.14713975546654 (code B ref 24239); Wed, 17 Aug 2016 01:33:01 +0000 Original-Received: (at 24239) by debbugs.gnu.org; 17 Aug 2016 01:32:34 +0000 Original-Received: from localhost ([127.0.0.1]:59602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZpib-0001jD-SJ for submit@debbugs.gnu.org; Tue, 16 Aug 2016 21:32:34 -0400 Original-Received: from mail-wm0-f66.google.com ([74.125.82.66]:35156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZpib-0001iU-05 for 24239@debbugs.gnu.org; Tue, 16 Aug 2016 21:32:33 -0400 Original-Received: by mail-wm0-f66.google.com with SMTP id i5so19552336wmg.2 for <24239@debbugs.gnu.org>; Tue, 16 Aug 2016 18:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=LrSilRqavgsQdfgzEfFivLcwlr2NqAC6RIuOyvz/dGU=; b=z+/RvX0g96jLPLGv7GScMMw0rXcEFaozPDcvIfA0k0Y1lXjDECkHj1UYnKlYg/MPRt D3RO4KfPcPbvDP1txr2Fz6SZ9yNvVHmiw5ZjCkCOjYTW7oF4lFRLkGv7o+39RJOfh9Tf apAVh5Bnt5hu3sHZ8BUI9kbmVsfg30SMsMbqsfEGbs0y5wYgFL5zvhXY7f0QzBz/igvd 44QniVnJQBpleoqCdgxqFqzyPg0KRVmZm7J9z6cF9T0t5WhRAkC6W4Rwn0sX/qtTm5MQ d0ScJ0/pIissMfTluNTG6QBf5ucc8dYNwgNczC3Gx35xAVeZpIyI1c6fbgYlJUbFld9U M68w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=LrSilRqavgsQdfgzEfFivLcwlr2NqAC6RIuOyvz/dGU=; b=FLmbD/MP7Y6br/+fDkr4dbp+lkMtTTTA1K9QhjBu0eCG9ZV+3YELlxzrJJ/KmAoOEy kWSPpBVp+sA4zuHcJ5kKE7ggH2zrvUkdTMIYdDzXXLRN0vFtmQD6M3a8dt6F+9P8eaDj O7CtbolHA2tYV9gaIJT3TFqOiJHeFjndf1uvJcJyj1nUsiDVTY49DjdkzGQc40+QHDCo 0P+OIkUnlKFICKcLAgTuByISzxuKGLSuwj9e7HD9PdHnslgYVAdaLvthLb9dI9BP3bGK np19gWXfWm8PF5gkx7ufrROOCZ33pSbuJWMjA5OfmvA/YbIAF8PkiOU4isEt4Gw+8I1W 3QsA== X-Gm-Message-State: AEkoouuauVoeUP1VTnqM9AnvWvKfG0vw4SjQzSzZcD0rE7/llWk01L7WUc1f7nqcdU6wAw== X-Received: by 10.25.20.226 with SMTP id 95mr6707042lfu.194.1471397547137; Tue, 16 Aug 2016 18:32:27 -0700 (PDT) Original-Received: from [192.168.1.190] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id 206sm1200553ljj.4.2016.08.16.18.32.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2016 18:32:26 -0700 (PDT) In-Reply-To: <83bn0sg3kp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122295 Archived-At: On 08/16/2016 06:01 PM, Eli Zaretskii wrote: > I guess you are talking about NEWS, not ChangeLog. Yup. That's what I gathered Damien to mean, considering we do mention this change in the generated ChangeLog. > It's tru we don't > describe bug-fixes in NEWS, but we do describe incompatible changes. > So I think it would be good to document this change there. Could you > suggest some simple description of that? Something like "url-request-data is not allowed to be bound to a multibyte value; if your request body is multibyte (which is the usual case, by the way), convert it with encode-coding-string". Hmm... by the way, we could also mention that json-encode now keeps most multibyte characters as-is. Which is the reason we had to scramble to fix this problem with the URL package. > (I don't understand the > details of the use case well enough to do that myself -- how is the > value of url-request-data related to the change we made in > url-http-create-request?) The related change is for the previous bug report (23750), and the commit a98aa02a that added the "Multibyte text in HTTP request" error.