all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: damien@cassou.me, 24239@debbugs.gnu.org
Subject: bug#24239: 25.1; Potential regression: Multibyte text in HTTP request
Date: Wed, 17 Aug 2016 04:32:24 +0300	[thread overview]
Message-ID: <0f709753-d7d8-c2ab-f8c2-19ff87316d60@yandex.ru> (raw)
In-Reply-To: <83bn0sg3kp.fsf@gnu.org>

On 08/16/2016 06:01 PM, Eli Zaretskii wrote:

> I guess you are talking about NEWS, not ChangeLog.

Yup. That's what I gathered Damien to mean, considering we do mention 
this change in the generated ChangeLog.

> It's tru we don't
> describe bug-fixes in NEWS, but we do describe incompatible changes.
> So I think it would be good to document this change there.  Could you
> suggest some simple description of that?

Something like "url-request-data is not allowed to be bound to a 
multibyte value; if your request body is multibyte (which is the usual 
case, by the way), convert it with encode-coding-string".

Hmm... by the way, we could also mention that json-encode now keeps most 
multibyte characters as-is. Which is the reason we had to scramble to 
fix this problem with the URL package.

> (I don't understand the
> details of the use case well enough to do that myself -- how is the
> value of url-request-data related to the change we made in
> url-http-create-request?)

The related change is for the previous bug report (23750), and the 
commit a98aa02a that added the "Multibyte text in HTTP request" error.





  reply	other threads:[~2016-08-17  1:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15 18:58 bug#24239: 25.1; Potential regression: Multibyte text in HTTP request Damien Cassou
2016-08-15 21:52 ` Dmitry Gutov
2016-08-16  6:23   ` Damien Cassou
2016-08-16  8:16     ` Dmitry Gutov
2016-08-16 15:01       ` Eli Zaretskii
2016-08-17  1:32         ` Dmitry Gutov [this message]
2016-08-17  2:44           ` Eli Zaretskii
2016-08-17  3:57             ` Dmitry Gutov
2016-08-17 15:17               ` Eli Zaretskii
2016-08-17 18:02                 ` Dmitry Gutov
2016-08-17 18:31                   ` Eli Zaretskii
2016-09-21 10:27       ` Damien Cassou
2016-09-21 10:34         ` Dmitry Gutov
2016-09-21 13:16           ` Damien Cassou
2018-02-09  0:35             ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f709753-d7d8-c2ab-f8c2-19ff87316d60@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=24239@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.