From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#44483: 27.1.50; Window parameter `min-margins' doesn't split window in half Date: Sat, 7 Nov 2020 10:00:11 +0100 Message-ID: <0f516ef7-2ebc-bdd0-b672-708a63bcd475@gmx.at> References: <87tuu2inkv.fsf@fastmail.fm> <87361mi5nq.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39142"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44483@debbugs.gnu.org To: Joost Kremers Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 07 10:02:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbK71-000A6W-Sa for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 10:02:19 +0100 Original-Received: from localhost ([::1]:60980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbK70-0008Cl-NX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 04:02:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbK5o-0008Ax-Ij for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 04:01:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbK5m-000734-He for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 04:01:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbK5m-0005XM-Gt for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 04:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Nov 2020 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44483 X-GNU-PR-Package: emacs Original-Received: via spool by 44483-submit@debbugs.gnu.org id=B44483.160473962221226 (code B ref 44483); Sat, 07 Nov 2020 09:01:02 +0000 Original-Received: (at 44483) by debbugs.gnu.org; 7 Nov 2020 09:00:22 +0000 Original-Received: from localhost ([127.0.0.1]:57934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbK58-0005WI-Hr for submit@debbugs.gnu.org; Sat, 07 Nov 2020 04:00:22 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:38755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbK57-0005W2-3s for 44483@debbugs.gnu.org; Sat, 07 Nov 2020 04:00:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604739612; bh=vF90JLmQPkG/rQgjQzrYIuHlsVlyIJ9pFeVfuORYsLw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=KZx0riuVqZGd1wGm6mExPOON78jYnppjVUgOdEBcHvOuBQTCs7ZW4NL8O5IeoHV++ r4H/2++TOVQ4I6JFbVjUoDbkyjim3hp5zAyPUOQPsprdwF5y7bdW68iYOXEBnuR1Cs QJfhdz9qSNfpiOJhyFzF9elSC4SJe5DjYQbLSgMs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.5]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTRMi-1kl8Ge03ci-00ToGK; Sat, 07 Nov 2020 10:00:12 +0100 In-Reply-To: <87361mi5nq.fsf@fastmail.fm> Content-Language: en-US X-Provags-ID: V03:K1:PmlSLIYkCiAimfG3Xzymbk3bEH6oG60kR2nLB5HuB9c/14tBvfR NeQ0/1wpvdGkPT3dJQnYiG5gXDS4myuAoXks2cvL39vj/F7OHkamsWlX8GgAkxgmkhE35uz iQ1dk3luVXTMZN/WzxOMZk1xQGkAyA7sS9fd3VzAQK4K8epSN8nlLk/C2cmEJwrRhLZ/m+E JDnJ/xhtHegAoyvTbKDow== X-UI-Out-Filterresults: notjunk:1;V03:K0:XTNSZDCK9Do=:2kvYQA4Xq8P51+KOuGDMO0 olGBNaxpH2VKyLHaGz9PMwCqd7flOhigHZJkPurhFPJYJHbrfZENgm3XwJkZvt+LAp8CHvUQd /ke/MIoNCIPzZDRoqCkARuqqUojXxZr+m8dTkbRKsydQqS7BHGbiNpax5dZwQgVHSFAhHZW61 3fQMaTODepSI8piXD7MqYOuxdOfkRtR16ZXg6/OoKfno5CJGQTj5v3Q2r12oWyeRW7/c8aJER ADftA7fp9MmgdSnPXTJws3HrjQWkNseIgS1Xjo1sfw1q7p2X47kGc3F0j+fwz2K36awApyPiP JkLicjeB0tQqakyn+CHemzoMHso2V/Ow11CQ4ae8JJVgV5ZGLJLrXfGxSiRjEm+K/izZWPjvR 0Hi92p1GN00i3VsEPQ8uVphyh6v/hGy/uPXY/BC5ZUyVzwStE84bcblzFtprjAcgh0CHUkwV/ IUKYLf41ArMmLiEC17y4RW+v6pFbsfEQQY5Z5wNoqZ+ZY6bBD6/+FslZFk+EkVbPgEOM3KbzW 3y7aj4VX0aPjZAm25Re+kWB2PlR4D5KE49BBeXDz8iECKtJWb+snxY8jz//Ehpl6bZq+437lN PucBFTOAtVIlhMPh88H4eZqGF1u/dEgS+WQu0A5q4nU5bT1zsQVKNFMKQ+x5jgyt276jxzoBq 0Rmlqi/Mpu85bZIZQ0ci/e/PD0DpDVsmk49Bfsqv4m740ygsvSHV1fgoTmM1LTINKJo43lOx2 z5L+3cBaI3w2L8zFbzKPuXm4UxuFp3O8BG6mFyMLvhz/7Y6Aa+gsxTGjYt1aw8qujFV0M3TC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192822 Archived-At: >> The problem is that when we split the original window, the new window >> does not get its 'min-margins' parameter set and the subsequent >> sanitizing step screws up things. Please try the attached patch. > > Yes, the patch appears to work. After applying it, splitting a window gives me a > 50/50 split. (I tried several times.) I installed a slightly different fix on the Emacs 27 branch now. We really should have had tested 'min-margins' when Emacs 25 came out but IIRC you bowed out in the last minute back then and apparently now you have become their first client. Since the bug shows up only when SIZE is unspecified, the recipe I used might not have triggered it then. In Emacs 28 I intend to remove sanity checks entirely and always auto-shrink margins when they don't fit into a window any more. Windows will also have a configurable minimum body width so the behavior seen now where the entire buffer text disappears can be easily avoided. >> And please look also into what happens when you shrink a frame with such >> large margins to a size that won't accommodate those margins any more >> unless they get shrunk. I'm afraid that the subsequent sanitizing step >> might cause troubles there as well. > > I'm not seeing anything unexpected here, but I'm not sure what I should be > looking at. In an earlier posting you said that "Twice during my tests Emacs actually hung, driving one of the CPU cores to 100%." I thought of something similar happening when shrinking a frame. martin