From: martin rudalics <rudalics@gmx.at>
To: Joost Kremers <joostkremers@fastmail.fm>
Cc: 44483@debbugs.gnu.org
Subject: bug#44483: 27.1.50; Window parameter `min-margins' doesn't split window in half
Date: Sat, 7 Nov 2020 10:00:11 +0100 [thread overview]
Message-ID: <0f516ef7-2ebc-bdd0-b672-708a63bcd475@gmx.at> (raw)
In-Reply-To: <87361mi5nq.fsf@fastmail.fm>
>> The problem is that when we split the original window, the new window
>> does not get its 'min-margins' parameter set and the subsequent
>> sanitizing step screws up things. Please try the attached patch.
>
> Yes, the patch appears to work. After applying it, splitting a window gives me a
> 50/50 split. (I tried several times.)
I installed a slightly different fix on the Emacs 27 branch now. We
really should have had tested 'min-margins' when Emacs 25 came out but
IIRC you bowed out in the last minute back then and apparently now you
have become their first client. Since the bug shows up only when SIZE
is unspecified, the recipe I used might not have triggered it then.
In Emacs 28 I intend to remove sanity checks entirely and always
auto-shrink margins when they don't fit into a window any more. Windows
will also have a configurable minimum body width so the behavior seen
now where the entire buffer text disappears can be easily avoided.
>> And please look also into what happens when you shrink a frame with such
>> large margins to a size that won't accommodate those margins any more
>> unless they get shrunk. I'm afraid that the subsequent sanitizing step
>> might cause troubles there as well.
>
> I'm not seeing anything unexpected here, but I'm not sure what I should be
> looking at.
In an earlier posting you said that "Twice during my tests Emacs
actually hung, driving one of the CPU cores to 100%." I thought of
something similar happening when shrinking a frame.
martin
next prev parent reply other threads:[~2020-11-07 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 14:09 bug#44483: 27.1.50; Window parameter `min-margins' doesn't split window in half Joost Kremers
2020-11-06 14:41 ` Eli Zaretskii
2020-11-06 16:25 ` Joost Kremers
2020-11-06 18:29 ` Eli Zaretskii
2020-11-06 18:12 ` martin rudalics
2020-11-06 20:36 ` Joost Kremers
2020-11-07 9:00 ` martin rudalics [this message]
2020-11-08 15:00 ` Joost Kremers
2020-11-09 8:31 ` martin rudalics
2021-10-11 12:35 ` Stefan Kangas
2021-10-11 17:18 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f516ef7-2ebc-bdd0-b672-708a63bcd475@gmx.at \
--to=rudalics@gmx.at \
--cc=44483@debbugs.gnu.org \
--cc=joostkremers@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.