From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 23 Mar 2019 09:41:42 -0700 Organization: UCLA Computer Science Department Message-ID: <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="69333"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 Cc: emacs-devel@gnu.org To: Eli Zaretskii , Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 23 17:42:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7jjA-000Hw8-3x for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 17:42:36 +0100 Original-Received: from localhost ([127.0.0.1]:45535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7jj9-0007J0-3M for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 12:42:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7jiN-0007Ih-MA for emacs-devel@gnu.org; Sat, 23 Mar 2019 12:41:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7jiM-0003Yw-Of for emacs-devel@gnu.org; Sat, 23 Mar 2019 12:41:47 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59140) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h7jiL-0003XT-77; Sat, 23 Mar 2019 12:41:45 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5AF0E160CBB; Sat, 23 Mar 2019 09:41:43 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1jJI9mlxCLaI; Sat, 23 Mar 2019 09:41:42 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 91AB9160AE8; Sat, 23 Mar 2019 09:41:42 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zWot5FgVu9AO; Sat, 23 Mar 2019 09:41:42 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5A2D4160986; Sat, 23 Mar 2019 09:41:42 -0700 (PDT) In-Reply-To: <83ef6xpo6b.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234651 Archived-At: Eli Zaretskii wrote: > The correct name would be something like gui_write_glyphs, since > there's tty_write_glyphs in term.c. Although I personally fail to see > how such renaming will help anyone or anything. Renaming would make the code clearer now, and would benefit those unfamiliar with the code (or at least to this part of the code -- and I put myself in this category as I'm often confused by the non-X x_* names). However, renaming would also make software archaeology more difficult. When weighing benefit vs cost, it partly depends on how forward-looking we want to be. I would favor renaming, though I also see the benefits of leaving things alone.