all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Phil Sainty <psainty@orcon.net.nz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Robert Pluim <rpluim@gmail.com>, stefan@marxist.se, emacs-devel@gnu.org
Subject: Re: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out)
Date: Fri, 14 Jan 2022 14:05:56 +1300	[thread overview]
Message-ID: <0f304fcc8959fd365e95ce36e42b4794@webmail.orcon.net.nz> (raw)
In-Reply-To: <83ee5b3de7.fsf@gnu.org>

On 2022-01-14 03:42, Eli Zaretskii wrote:
>>     >> Using `with-demoted-errors' would achieve both goals, I think?
>> 
>>     Eli> Using that where? in the test suite?
>> 
>> Yes, for this one specific test. Although Iʼd prefer `ignore-errors',
> 
> Fine with me.

I agree with `ignore-errors' for the test suite.

My `with-⁠demoted-⁠errors' suggestion was actually regarding
`ispell-⁠valid-⁠dictionary-⁠list' or `ispell-⁠set-⁠spellchecker-⁠params'
as I wouldn't expect an absence of dictionaries to cause those
functions (or at least the former) to fail.

I haven't looked at them in detail, but my gut feeling was that
`ispell-⁠valid-⁠dictionary-⁠list' should be returning an empty list
in that scenario.  I thought that if a warning message was logged
along the way to point out that no dictionaries were installed,
that would seem fine (and preferable to an error).

Maybe not a change for 28.1, but potentially for master?


-Phil




  reply	other threads:[~2022-01-14  1:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13  7:51 "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Phil Sainty
2022-01-13  8:46 ` Robert Pluim
2022-01-13 10:20   ` Robert Pluim
2022-01-13 10:39     ` Eli Zaretskii
2022-01-13 11:28       ` Phil Sainty
2022-01-13 12:39         ` Eli Zaretskii
2022-01-13 14:05           ` Robert Pluim
2022-01-13 14:42             ` Eli Zaretskii
2022-01-14  1:05               ` Phil Sainty [this message]
2022-01-14  7:12                 ` Eli Zaretskii
2022-01-14  9:06                   ` Phil Sainty
2022-01-14 12:02                     ` Eli Zaretskii
2022-01-13 11:26     ` Phil Sainty
2022-01-13 14:23       ` Robert Pluim
2022-01-13 14:38         ` Robert Pluim
2022-01-13 11:57     ` Phil Sainty
2022-01-13 14:30       ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f304fcc8959fd365e95ce36e42b4794@webmail.orcon.net.nz \
    --to=psainty@orcon.net.nz \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.