From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#61504: 29.0.60; executing byte-code from previous build causes SIGSEGV crash Date: Tue, 14 Feb 2023 09:29:32 +0000 Message-ID: <0f053182b047f142abcf@heytings.org> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="YkMxnCQia1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9080"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 61504@debbugs.gnu.org To: Istvan Marko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 14 10:30:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRrdp-0002BK-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Feb 2023 10:30:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRrdW-0006xe-8Z; Tue, 14 Feb 2023 04:30:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRrdS-0006wi-WB for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 04:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRrdS-0008Lk-A8 for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 04:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRrdS-0008Gq-5N for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 04:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2023 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61504 X-GNU-PR-Package: emacs Original-Received: via spool by 61504-submit@debbugs.gnu.org id=B61504.167636697631717 (code B ref 61504); Tue, 14 Feb 2023 09:30:02 +0000 Original-Received: (at 61504) by debbugs.gnu.org; 14 Feb 2023 09:29:36 +0000 Original-Received: from localhost ([127.0.0.1]:52564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRrd2-0008FV-BN for submit@debbugs.gnu.org; Tue, 14 Feb 2023 04:29:36 -0500 Original-Received: from heytings.org ([95.142.160.155]:56188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRrd0-0008FM-Hf for 61504@debbugs.gnu.org; Tue, 14 Feb 2023 04:29:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1676366973; bh=OBAeORT7qTZ2YCWzADBq3b/8nY9RmNHKZlmAiXcuv50=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=jTU9ky6puYv5+s1CHYpCf5aUSVBVsNRvXc44lzvzp8U65w7dpkwdC281Nf2J0zWMZ FTMYOzBa3UXHyCrmEkjdZbxF6PErT29BmsgCjt+1p4b7oe4Il27mr4NjnmypUpeWRQ /e7773t92FEW5qf/Y5P+TRsIU7NC46aKAIRhz9sEBBQ1qgQHqKkq8DbDlXycfU2zLv VSYRz0UD5nOpZ4SAMnTHPiqpM8wAVtFuG4TwG8cTWFT+Qo231P1q8tbPQmXbpT6i/z FbyxpAZolcVStNH8GD8TzfAO7LoKNl0J35vYDBi7o3pbYyXJQRhEpW3bpG6w6tBGA9 Y0GaupKODazmA== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255561 Archived-At: --YkMxnCQia1 Content-Type: text/plain; format=flowed; charset=us-ascii > > There seems to be a byte-code change between versions > 0ec0a610ed226419269f519021cbe8fb2dde2ed5 (old) and > a4aa32bdfff7aaf54efbacbb04b7f2b52fef92a7 (new) which causes the new > version to crash with SIGSEGV when executing certain code from an .elc > built using the old version. Recompiling the file with the new version > causes the new .elc to work correctly. > The bytecode did not change, but the byte codes generated by the save-restriction form did change. Now that I think of it again, it is possible make that change while preserving backward compatibility. Eli, what do you think of the attached patch? It restores the 'unbind 1' at the end of save-restriction, and puts the two data elements into a cons instead of pushing them separately. (Of course this passes make and make check, with and without native compilation.) --YkMxnCQia1 Content-Type: text/x-diff; name=Improve-backward-compatibility-of-save-restriction.patch Content-Transfer-Encoding: base64 Content-ID: <0f053182b016f28f2bab@heytings.org> Content-Disposition: attachment; filename=Improve-backward-compatibility-of-save-restriction.patch RnJvbSA4NWY0YTI4NTE1MTRmYWQ5ODFiNzRhYmUxNGI4MzMxOTZkNTk4N2Iw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUdWUsIDE0IEZl YiAyMDIzIDA5OjIyOjIyICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIEltcHJv dmUgYmFja3dhcmQgY29tcGF0aWJpbGl0eSBvZiBzYXZlLXJlc3RyaWN0aW9u DQoNCiogc3JjL2VkaXRmbnMuYyAoc2F2ZV9yZXN0cmljdGlvbl9hbmRfbmFy cm93aW5nX2xvY2tzX3Jlc3RvcmUpOg0KTmV3IGZ1bmN0aW9uLCBjb21iaW5p bmcgJ3NhdmVfcmVzdHJpY3Rpb25fcmVzdG9yZScgYW5kDQonbmFycm93aW5n X2xvY2tzX3Jlc3RvcmUnLg0KKG5hcnJvd2luZ19sb2Nrc19yZXN0b3JlKTog TWFrZSBzdGF0aWMuDQooRnNhdmVfcmVzdHJpY3Rpb24pOiBVc2UgdGhlIG5l dyBmdW5jdGlvbiBpbnN0ZWFkIG9mIHRoZSB0d28gb25lcw0KaXQgY29tYmlu ZXMuDQoNCiogc3JjL2xpc3AuaDogTWFrZSB0aGUgbmV3IGZ1bmN0aW9uIGV4 dGVybmFsbHkgdmlzaWJsZS4NCg0KKiBzcmMvYnl0ZWNvZGUuYyAoZXhlY19i eXRlX2NvZGUpOiBVc2UgdGhlIG5ldyBmdW5jdGlvbiBpbnN0ZWFkIG9mDQp0 aGUgdHdvIG9uZXMgaXQgY29tYmluZXMuDQoNCiogc3JjL2NvbXAuYyAoaGVs cGVyX3NhdmVfcmVzdHJpY3Rpb24pOiBVc2UgdGhlIG5ldyBmdW5jdGlvbg0K aW5zdGVhZCBvZiB0aGUgdHdvIG9uZXMgaXQgY29tYmluZXMuDQoNCiogbGlz cC9lbWFjcy1saXNwL2J5dGVjb21wLmVsIChieXRlLWNvbXBpbGUtc2F2ZS1y ZXN0cmljdGlvbik6DQpEZWNyZW1lbnQgdW5iaW5kaW5nIGNvdW50Lg0KLS0t DQogbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVsIHwgIDIgKy0NCiBzcmMv Ynl0ZWNvZGUuYyAgICAgICAgICAgICAgfCAgNyArKystLS0tDQogc3JjL2Nv bXAuYyAgICAgICAgICAgICAgICAgIHwgIDcgKysrLS0tLQ0KIHNyYy9lZGl0 Zm5zLmMgICAgICAgICAgICAgICB8IDE0ICsrKysrKysrKysrLS0tDQogc3Jj L2xpc3AuaCAgICAgICAgICAgICAgICAgIHwgIDIgKy0NCiA1IGZpbGVzIGNo YW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQ0KDQpk aWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL2J5dGVjb21wLmVsIGIvbGlz cC9lbWFjcy1saXNwL2J5dGVjb21wLmVsDQppbmRleCBjNmNkYTZiNTg4YS4u NWRmMTIwNTg2OWMgMTAwNjQ0DQotLS0gYS9saXNwL2VtYWNzLWxpc3AvYnl0 ZWNvbXAuZWwNCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9ieXRlY29tcC5lbA0K QEAgLTQ5MDAsNyArNDkwMCw3IEBAIGJ5dGUtY29tcGlsZS1zYXZlLWV4Y3Vy c2lvbg0KIChkZWZ1biBieXRlLWNvbXBpbGUtc2F2ZS1yZXN0cmljdGlvbiAo Zm9ybSkNCiAgIChieXRlLWNvbXBpbGUtb3V0ICdieXRlLXNhdmUtcmVzdHJp Y3Rpb24gMCkNCiAgIChieXRlLWNvbXBpbGUtYm9keS1kby1lZmZlY3QgKGNk ciBmb3JtKSkNCi0gIChieXRlLWNvbXBpbGUtb3V0ICdieXRlLXVuYmluZCAy KSkNCisgIChieXRlLWNvbXBpbGUtb3V0ICdieXRlLXVuYmluZCAxKSkNCiAN CiAoZGVmdW4gYnl0ZS1jb21waWxlLXNhdmUtY3VycmVudC1idWZmZXIgKGZv cm0pDQogICAoYnl0ZS1jb21waWxlLW91dCAnYnl0ZS1zYXZlLWN1cnJlbnQt YnVmZmVyIDApDQpkaWZmIC0tZ2l0IGEvc3JjL2J5dGVjb2RlLmMgYi9zcmMv Ynl0ZWNvZGUuYw0KaW5kZXggOGUyMTQ1NjBmMzAuLmNhN2FlNDc2NmUxIDEw MDY0NA0KLS0tIGEvc3JjL2J5dGVjb2RlLmMNCisrKyBiL3NyYy9ieXRlY29k ZS5jDQpAQCAtOTQwLDEwICs5NDAsOSBAQCAjZGVmaW5lIERFRklORShuYW1l LCB2YWx1ZSkgW25hbWVdID0gJiZpbnNuXyAjIyBuYW1lLA0KIAkgIH0NCiAN CiAJQ0FTRSAoQnNhdmVfcmVzdHJpY3Rpb24pOg0KLQkgIHJlY29yZF91bndp bmRfcHJvdGVjdCAoc2F2ZV9yZXN0cmljdGlvbl9yZXN0b3JlLA0KLQkJCQkg c2F2ZV9yZXN0cmljdGlvbl9zYXZlICgpKTsNCi0JICByZWNvcmRfdW53aW5k X3Byb3RlY3QgKG5hcnJvd2luZ19sb2Nrc19yZXN0b3JlLA0KLQkJCQkgbmFy cm93aW5nX2xvY2tzX3NhdmUgKCkpOw0KKwkgIHJlY29yZF91bndpbmRfcHJv dGVjdCAoc2F2ZV9yZXN0cmljdGlvbl9hbmRfbmFycm93aW5nX2xvY2tzX3Jl c3RvcmUsDQorCQkJCSBGY29ucyAoc2F2ZV9yZXN0cmljdGlvbl9zYXZlICgp LA0KKwkJCQkJbmFycm93aW5nX2xvY2tzX3NhdmUgKCkpKTsNCiAJICBORVhU Ow0KIA0KIAlDQVNFIChCY2F0Y2gpOgkJLyogT2Jzb2xldGUgc2luY2UgMjUu ICAqLw0KZGlmZiAtLWdpdCBhL3NyYy9jb21wLmMgYi9zcmMvY29tcC5jDQpp bmRleCAwZTJkZmQzOTEzYi4uZmUyYzliMDU0YjYgMTAwNjQ0DQotLS0gYS9z cmMvY29tcC5jDQorKysgYi9zcmMvY29tcC5jDQpAQCAtNTA2MSwxMCArNTA2 MSw5IEBAIGhlbHBlcl91bmJpbmRfbiAoTGlzcF9PYmplY3QgbikNCiBzdGF0 aWMgdm9pZA0KIGhlbHBlcl9zYXZlX3Jlc3RyaWN0aW9uICh2b2lkKQ0KIHsN Ci0gIHJlY29yZF91bndpbmRfcHJvdGVjdCAoc2F2ZV9yZXN0cmljdGlvbl9y ZXN0b3JlLA0KLQkJCSBzYXZlX3Jlc3RyaWN0aW9uX3NhdmUgKCkpOw0KLSAg cmVjb3JkX3Vud2luZF9wcm90ZWN0IChuYXJyb3dpbmdfbG9ja3NfcmVzdG9y ZSwNCi0JCQkgbmFycm93aW5nX2xvY2tzX3NhdmUgKCkpOw0KKyAgcmVjb3Jk X3Vud2luZF9wcm90ZWN0IChzYXZlX3Jlc3RyaWN0aW9uX2FuZF9uYXJyb3dp bmdfbG9ja3NfcmVzdG9yZSwNCisJCQkgRmNvbnMgKHNhdmVfcmVzdHJpY3Rp b25fc2F2ZSAoKSwNCisJCQkJbmFycm93aW5nX2xvY2tzX3NhdmUgKCkpKTsN CiB9DQogDQogc3RhdGljIGJvb2wNCmRpZmYgLS1naXQgYS9zcmMvZWRpdGZu cy5jIGIvc3JjL2VkaXRmbnMuYw0KaW5kZXggY2UxMzM3ODVlMGIuLmRiY2M1 NzI4ZGRhIDEwMDY0NA0KLS0tIGEvc3JjL2VkaXRmbnMuYw0KKysrIGIvc3Jj L2VkaXRmbnMuYw0KQEAgLTI4MDQsNyArMjgwNCw3IEBAIG5hcnJvd2luZ19s b2Nrc19zYXZlICh2b2lkKQ0KICAgcmV0dXJuIEZjb25zIChidWYsIEZjb3B5 X3NlcXVlbmNlIChsb2NrcykpOw0KIH0NCiANCi12b2lkDQorc3RhdGljIHZv aWQNCiBuYXJyb3dpbmdfbG9ja3NfcmVzdG9yZSAoTGlzcF9PYmplY3QgYnVm X2FuZF9zYXZlZF9sb2NrcykNCiB7DQogICBMaXNwX09iamVjdCBidWYgPSBY Q0FSIChidWZfYW5kX3NhdmVkX2xvY2tzKTsNCkBAIC0zMDY4LDYgKzMwNjgs MTMgQEAgc2F2ZV9yZXN0cmljdGlvbl9yZXN0b3JlIChMaXNwX09iamVjdCBk YXRhKQ0KICAgICBzZXRfYnVmZmVyX2ludGVybmFsIChjdXIpOw0KIH0NCiAN Cit2b2lkDQorc2F2ZV9yZXN0cmljdGlvbl9hbmRfbmFycm93aW5nX2xvY2tz X3Jlc3RvcmUgKExpc3BfT2JqZWN0IGRhdGEpDQorew0KKyAgc2F2ZV9yZXN0 cmljdGlvbl9yZXN0b3JlIChYQ0FSIChkYXRhKSk7DQorICBuYXJyb3dpbmdf bG9ja3NfcmVzdG9yZSAoWENEUiAoZGF0YSkpOw0KK30NCisNCiBERUZVTiAo InNhdmUtcmVzdHJpY3Rpb24iLCBGc2F2ZV9yZXN0cmljdGlvbiwgU3NhdmVf cmVzdHJpY3Rpb24sIDAsIFVORVZBTExFRCwgMCwNCiAgICAgICAgZG9jOiAv KiBFeGVjdXRlIEJPRFksIHNhdmluZyBhbmQgcmVzdG9yaW5nIGN1cnJlbnQg YnVmZmVyJ3MgcmVzdHJpY3Rpb25zLg0KIFRoZSBidWZmZXIncyByZXN0cmlj dGlvbnMgbWFrZSBwYXJ0cyBvZiB0aGUgYmVnaW5uaW5nIGFuZCBlbmQgaW52 aXNpYmxlLg0KQEAgLTMwOTEsOCArMzA5OCw5IEBAIERFRlVOICgic2F2ZS1y ZXN0cmljdGlvbiIsIEZzYXZlX3Jlc3RyaWN0aW9uLCBTc2F2ZV9yZXN0cmlj dGlvbiwgMCwgVU5FVkFMTEVELCAwDQogICByZWdpc3RlciBMaXNwX09iamVj dCB2YWw7DQogICBzcGVjcGRsX3JlZiBjb3VudCA9IFNQRUNQRExfSU5ERVgg KCk7DQogDQotICByZWNvcmRfdW53aW5kX3Byb3RlY3QgKHNhdmVfcmVzdHJp Y3Rpb25fcmVzdG9yZSwgc2F2ZV9yZXN0cmljdGlvbl9zYXZlICgpKTsNCi0g IHJlY29yZF91bndpbmRfcHJvdGVjdCAobmFycm93aW5nX2xvY2tzX3Jlc3Rv cmUsIG5hcnJvd2luZ19sb2Nrc19zYXZlICgpKTsNCisgIHJlY29yZF91bndp bmRfcHJvdGVjdCAoc2F2ZV9yZXN0cmljdGlvbl9hbmRfbmFycm93aW5nX2xv Y2tzX3Jlc3RvcmUsDQorCQkJIEZjb25zIChzYXZlX3Jlc3RyaWN0aW9uX3Nh dmUgKCksDQorCQkJCW5hcnJvd2luZ19sb2Nrc19zYXZlICgpKSk7DQogICB2 YWwgPSBGcHJvZ24gKGJvZHkpOw0KICAgcmV0dXJuIHVuYmluZF90byAoY291 bnQsIHZhbCk7DQogfQ0KZGlmZiAtLWdpdCBhL3NyYy9saXNwLmggYi9zcmMv bGlzcC5oDQppbmRleCA5MzE5N2QzODE3Ni4uYTg2YTJlODIzZjkgMTAwNjQ0 DQotLS0gYS9zcmMvbGlzcC5oDQorKysgYi9zcmMvbGlzcC5oDQpAQCAtNDY4 NSw3ICs0Njg1LDcgQEAgWE1PRFVMRV9GVU5DVElPTiAoTGlzcF9PYmplY3Qg bykNCiBleHRlcm4gTGlzcF9PYmplY3Qgc2F2ZV9yZXN0cmljdGlvbl9zYXZl ICh2b2lkKTsNCiBleHRlcm4gdm9pZCBzYXZlX3Jlc3RyaWN0aW9uX3Jlc3Rv cmUgKExpc3BfT2JqZWN0KTsNCiBleHRlcm4gTGlzcF9PYmplY3QgbmFycm93 aW5nX2xvY2tzX3NhdmUgKHZvaWQpOw0KLWV4dGVybiB2b2lkIG5hcnJvd2lu Z19sb2Nrc19yZXN0b3JlIChMaXNwX09iamVjdCk7DQorZXh0ZXJuIHZvaWQg c2F2ZV9yZXN0cmljdGlvbl9hbmRfbmFycm93aW5nX2xvY2tzX3Jlc3RvcmUg KExpc3BfT2JqZWN0KTsNCiBleHRlcm4gTGlzcF9PYmplY3QgbWFrZV9idWZm ZXJfc3RyaW5nIChwdHJkaWZmX3QsIHB0cmRpZmZfdCwgYm9vbCk7DQogZXh0 ZXJuIExpc3BfT2JqZWN0IG1ha2VfYnVmZmVyX3N0cmluZ19ib3RoIChwdHJk aWZmX3QsIHB0cmRpZmZfdCwgcHRyZGlmZl90LA0KIAkJCQkJICAgIHB0cmRp ZmZfdCwgYm9vbCk7DQotLSANCjIuMzkuMA0KDQo= --YkMxnCQia1--