all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Gregory Heytings <gregory@heytings.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: mi-ebugs@kismala.com, Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	61504@debbugs.gnu.org
Subject: bug#61504: 29.0.60; executing byte-code from previous build causes SIGSEGV crash
Date: Tue, 14 Feb 2023 17:00:55 +0000	[thread overview]
Message-ID: <0f053182b0078c2103a9@heytings.org> (raw)
In-Reply-To: <E3D51434-F82A-4C58-9358-00FCC3DBC995@acm.org>


Thanks for the review!

>
> The patch is all right, I suppose, but it would be nice to do without 
> the extra cons. Maybe a new specpdl case is warranted? `save-excursion` 
> has one.
>

That's a possible improvement, but I think it's not safe enough for Emacs 
29.

>
> By the way, doesn't the patch switch the restoration order of narrowing 
> and restriction, respectively? Maybe it doesn't matter?
>

Hmmm, that's a good question!  The evaluation order of parameters is 
unspecified in C, so actually the order could be switched or not, 
depending on what the compiler chooses to do.  That being said, AFAICS it 
doesn't matter in this case, indeed.






  reply	other threads:[~2023-02-14 17:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  6:33 bug#61504: 29.0.60; executing byte-code from previous build causes SIGSEGV crash Istvan Marko
2023-02-14  9:29 ` Gregory Heytings
2023-02-14 13:29   ` Eli Zaretskii
2023-02-14 16:50     ` Mattias Engdegård
2023-02-14 17:00       ` Gregory Heytings [this message]
2023-02-14 17:16         ` Eli Zaretskii
2023-02-14 20:44           ` Gregory Heytings
2023-02-14 17:21         ` Mattias Engdegård
2023-02-14 20:46           ` Gregory Heytings
2023-02-14 20:32         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-14 20:47           ` Gregory Heytings
2023-02-14 15:22   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-14 16:00     ` Gregory Heytings
2023-02-14 16:47       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-14 16:51         ` Gregory Heytings
2023-02-14 17:36       ` Istvan Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f053182b0078c2103a9@heytings.org \
    --to=gregory@heytings.org \
    --cc=61504@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mattiase@acm.org \
    --cc=mi-ebugs@kismala.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.