From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71049: async-shell-command ends with "Process *Async Shell Command* finished" when remote "direct-async-process" Date: Wed, 29 May 2024 20:26:26 +0300 Message-ID: <0ebb5a51-8634-4f65-a384-79f82592e339@gutov.dev> References: <3a497741-2ad0-4919-b7c9-cdb36b0eb455@gutov.dev> <8734q7h35d.fsf@gmx.de> <87ttinfgoa.fsf@gmx.de> <861q5r2ric.fsf@gnu.org> <87o78vf9l2.fsf@gmx.de> <86sey711m6.fsf@gnu.org> <221919a1-950e-4ef3-975d-f86078d8e105@gutov.dev> <87wmnidv3u.fsf@gmx.de> <25dad14a-397c-4052-908c-121e40bbef51@gutov.dev> <877cfhubyd.fsf@gmx.de> <608acf89-a1f9-4151-9f53-99962af87688@gutov.dev> <87jzjhvnbw.fsf@gmx.de> <50900208-34b8-4b7c-90fc-8796da6bccd6@gutov.dev> <87cyp9vlb1.fsf@gmx.de> <87fru4u06a.fsf@gmx.de> <7989cd21-7808-4416-ab0a-92e5da869a36@gutov.dev> <861q5ku956.fsf@gnu.org> <86wmncss4i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4474"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: michael.albinus@gmx.de, 71049@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 29 19:27:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCN4z-00010g-Ix for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 May 2024 19:27:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCN4g-0003zL-Mc; Wed, 29 May 2024 13:26:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCN4e-0003yo-A2 for bug-gnu-emacs@gnu.org; Wed, 29 May 2024 13:26:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCN4e-0007sg-1g for bug-gnu-emacs@gnu.org; Wed, 29 May 2024 13:26:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCN4n-0000ej-Ka for bug-gnu-emacs@gnu.org; Wed, 29 May 2024 13:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 May 2024 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71049 X-GNU-PR-Package: emacs Original-Received: via spool by 71049-submit@debbugs.gnu.org id=B71049.17170036082481 (code B ref 71049); Wed, 29 May 2024 17:27:01 +0000 Original-Received: (at 71049) by debbugs.gnu.org; 29 May 2024 17:26:48 +0000 Original-Received: from localhost ([127.0.0.1]:45667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCN4a-0000dv-0e for submit@debbugs.gnu.org; Wed, 29 May 2024 13:26:48 -0400 Original-Received: from fhigh1-smtp.messagingengine.com ([103.168.172.152]:59429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCN4Y-0000dT-1M for 71049@debbugs.gnu.org; Wed, 29 May 2024 13:26:47 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 7E22011400E9; Wed, 29 May 2024 13:26:30 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 29 May 2024 13:26:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717003590; x=1717089990; bh=RO0Ut2LJYIzRYBbP2UJppkDTjfkGxPztH9/5DM3ZUfI=; b= Joi/21yoV+DB/Nx7GJL3omniqhA79tnqfCXnmik2MyJ3Bw6Od5Be++X1PlqeWWNt 05c7LtmsHgGKIBXoT6SjIPTIlD1xysnkzZqiswN7P7X6ShNiZiIgMHPfy1ykk/UQ iLdmkJnTA/wERL/WJ66EWvwlFpvZf2H8tZph/7FfAVMQW4KzI8teyb5E2N70FcIO Ep+5F7WFNlwnFhq8e5jbfBldbEs/TjG2NyA5XpL5kwIdAFQJupU/WqCwcE+jJFKf OQMSHnFVDpqbcr2RRV+7/6xrNHzzk1CNQniDkNARpu4ekRrIpc1SYcyKeuJlOP1A H0T4jrr2PC+/6S66uUwm+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717003590; x= 1717089990; bh=RO0Ut2LJYIzRYBbP2UJppkDTjfkGxPztH9/5DM3ZUfI=; b=I 3W6t8dq30N6aLiAFuzS2svAGFdQOu7484w0xa91HktfVnyy25BHHK7OUNZ//3WqK 6V05pFfW/cVllhdDRx3sg8svAwRX1ftx0kjmbjUcGc6cWLZcDXtfkmcQc4zGStDW 8fO99qAU3y7aqJwQb908B/fdnJoSYGkht7hEt7jfFa5Ug0o+Y8iW3IEnESUMaKca 7klm5ugutcVQSBgZ8gwvidgtSeVA7n+yCkh80JW9Ncfx3mNNeRJnx0lqeHoFBvUp 0Yl9hAmDMUKE+jZqoa+gJbugbXRSwi+c7FBhr+zQxFmb6CzFc8WjAGU7/6EfJYU1 0upKtUXLbTx3ijG0U/R0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekuddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeffieefvdelueektdfgleeigedugfevkeefjeevjeffteffueeuueeghfev ieduvdenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 May 2024 13:26:29 -0400 (EDT) Content-Language: en-US In-Reply-To: <86wmncss4i.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286170 Archived-At: On 29/05/2024 15:46, Eli Zaretskii wrote: >> Seems so. The patches (two alternatives) are attached to >> https://debbugs.gnu.org/71049#53. > Thanks. I don't understand what they do in the context of this > discussion, probably because I don't know enough about shell-mode and > comint. Could you explain the intent, please? Okay, to summarize the previous messages: async-shell-command calls shell-mode, which loads the history file by calling comint-read-input-ring. shell-setup-input-ring.diff extracts the comint input ring setup to a separate function. That function is then only called by 'shell', but not by 'shell-mode' itself anymore, or any of its descendants. Any callers or descendants of it that actually need this setup (I'm not aware of any, but they might exist) will need to adapt by adding this call. shell-no-start-prog.diff does not move the logic, but predicates its execution on the value of the variable shell--start-prog being non-nil. In-tree it's only set by 'shell', so the result is the same. The "how to adapt" recipe would be setting shell--start-prog to non-nil (in callers).