From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1d2df2f: Improve bignum comparison Date: Wed, 22 Aug 2018 08:06:34 -0700 Organization: UCLA Computer Science Department Message-ID: <0e5674b4-1cd7-8bae-b7a0-a3e770db6155@cs.ucla.edu> References: <831saqcva7.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1534950296 10323 195.159.176.226 (22 Aug 2018 15:04:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Aug 2018 15:04:56 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 22 17:04:51 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsUgl-0002aU-EQ for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 17:04:51 +0200 Original-Received: from localhost ([::1]:59477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsUir-0005tX-KK for ged-emacs-devel@m.gmane.org; Wed, 22 Aug 2018 11:07:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsUik-0005tN-Tx for emacs-devel@gnu.org; Wed, 22 Aug 2018 11:06:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsUig-0002eA-UM for emacs-devel@gnu.org; Wed, 22 Aug 2018 11:06:54 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsUiU-0002Ry-SQ; Wed, 22 Aug 2018 11:06:39 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6F563160EBD; Wed, 22 Aug 2018 08:06:36 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0Xh4g_mMqVwJ; Wed, 22 Aug 2018 08:06:35 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B69BA160F92; Wed, 22 Aug 2018 08:06:35 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PHtiSpxEsqsq; Wed, 22 Aug 2018 08:06:35 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 72C74160EBD; Wed, 22 Aug 2018 08:06:35 -0700 (PDT) In-Reply-To: <831saqcva7.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228815 Archived-At: Eli Zaretskii wrote: > This commit does this: > > * src/data.c (isnan): Remove, as we can assume C99. > > We indeed assume a C99 compliant compiler, but not necessarily a C99 > compliant library. Does the above assumption still valid if the > library is not C99-compliant? Other parts of Emacs have been assuming isnan since July, so this should be safe here. In practice isnan support is universal nowadays in the non-Microsoft world, and even MSVC has it, as I understand it. If there are problems (when compiling for MS-Windows 95, say?) we can fix them by doing something like adding "#define isnan _isnan" in src/w32.h. It's better to isolate portability hacks to platform-specific code, when the problem is platform-specific.