From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38563: 27.0.50; Company popup renders with newlines (?) inheriting the bg properties of the character at next line's bol Date: Fri, 13 Dec 2019 17:04:21 +0200 Message-ID: <0e27fa9b-67ac-c4b4-176f-f98c151d9b19@yandex.ru> References: <4c2a9d55-57d1-4c19-fe20-4ccf61d20d68@yandex.ru> <83o8weaiem.fsf@gnu.org> <4220b126-0511-d6ee-521d-d79f463ab6ee@yandex.ru> <8336dpaiee.fsf@gnu.org> <2203b03e-5558-1fe1-788a-4006602626f2@yandex.ru> <83h8248wio.fsf@gnu.org> <83wob071sd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77162"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38563@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 13 16:05:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifmVE-000JuV-N4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 16:05:12 +0100 Original-Received: from localhost ([::1]:50226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifmVD-0007Ro-Bo for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 10:05:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51789) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifmV5-0007NM-6O for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:05:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifmV4-0001VA-1L for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifmV3-0001Ul-S2 for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:05:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ifmV3-00014p-LO for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 10:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2019 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38563 X-GNU-PR-Package: emacs Original-Received: via spool by 38563-submit@debbugs.gnu.org id=B38563.15762494724097 (code B ref 38563); Fri, 13 Dec 2019 15:05:01 +0000 Original-Received: (at 38563) by debbugs.gnu.org; 13 Dec 2019 15:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:34536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifmUa-000141-71 for submit@debbugs.gnu.org; Fri, 13 Dec 2019 10:04:32 -0500 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:34124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifmUX-00013m-UT for 38563@debbugs.gnu.org; Fri, 13 Dec 2019 10:04:30 -0500 Original-Received: by mail-ed1-f48.google.com with SMTP id l8so1191811edw.1 for <38563@debbugs.gnu.org>; Fri, 13 Dec 2019 07:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kDkT7JMHQM9F8aNMizeKGjYhIXRfC2WV/LDE2aXWLr4=; b=Ib/IONp+29su7695ov7xDoqXoPhQoYnj+WS7wMBpC8dlFvnPWgRypnd9EfcaBMOjnl C5kqTKv/QYS0METCHu/U8W2RdCQZxdWQw+nXTkJTVTpv5sq+4kRHdAzHrK/m7FfrQNq7 FJc7AbbQYPRFLTgz7a14RV+fy0y10hM4B9iPYICfBtDuaRd2eL7X90H/a0DbRQdIOTE5 UhlBYQNpSwOY32X2dbqfMG8qWkC6jsTLGzxMO1crDziGkDETPv+4C23uRTpDnadAe3C4 mtoYWytEyEVqDRFjkBkiGFxzPGAUzUS7KpmJiG3BjEXNBYpeJZfGLp5bKtXjj2UFpGPD /8lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kDkT7JMHQM9F8aNMizeKGjYhIXRfC2WV/LDE2aXWLr4=; b=sk9TyBw/I30sGc/P2sTb0/4lbrjUsCHrHaEAuFGoOl59H5vxveYhowPSBvlqX/GVx7 IiCmsL5M8MPLVD6BJkg0ZAbsRU0mo8I+h2NCR/N0zy31SfCM9VA1yXR4jGoaqJKSb6iZ aCr4w8mUARWNMrSUVx0KJFqR0PSvid2Wq7LADAdqyKpAKk4+xZfa5QkkW861eUKDUQku 4g/GWe9K+G6U6LESE9c3PxRJstQR30id++XCB9eeyXJc7VInXDBcgPIzslxHxhs1fCn9 I2ugYzGglOvoX8dSlE90SxxS2NcudrBzP5SA96phlhYhTeP1BG71O5VnMlRNo0VmsyL+ MH4g== X-Gm-Message-State: APjAAAXrKLQXJzyDbzUPBvfO5mWLQYXUOViE9mlvkQbOaHdtScdxBYpp QxeynlDjM0NmYCbYIaLZMfFR33l2 X-Google-Smtp-Source: APXvYqwJVnyyBqLzDW8KKao0PwyDN0UvWZ0atCZVErpkTqGkc5o8olV6t24yGhzZKllu81FnKwcNew== X-Received: by 2002:a50:ee0f:: with SMTP id g15mr16204130eds.295.1576249463719; Fri, 13 Dec 2019 07:04:23 -0800 (PST) Original-Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id bo13sm531634ejb.5.2019.12.13.07.04.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Dec 2019 07:04:22 -0800 (PST) In-Reply-To: <83wob071sd.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173279 Archived-At: On 13.12.2019 16:12, Eli Zaretskii wrote: >> But I suppose I could add a face with ':extend nil' and use it in place >> of 'default' there. > > It wouldn't have worked, because ':extend nil' means the face which > says this is ineligible for face merging when face extension is > considered. IOW, ':extend nil' cannot countermand some other face > that's being merged which says ':extend t'. Hmm, that's counter to my intuition how this should work (meaning, :extend nil should be used during merging, like it's used during inheritance), but maybe this way enables functionality that wouldn't be possible otherwise. >> ...but the background color is taken specifically from the face that >> specified :extend? > > The problem is that the company's tooltip faces don't say ':extend t', > so they are ineligible for merging when the face beyond EOL is > considered. And we definitely wouldn't want the tooptil faces to say ':extend t'. Or else it would not be rectangular. > The only face which was eligible was the face of the > first character of the line where you place your overlay. Even if it > doesn't have ':extend t', we treat the base face (the first one being > merged) specially: we always treat it as eligible (ever wondered how > come 'default', 'tool-bar', and other "basic" faces get extended > although they don't specify :extend?). Um, okay. I suppose they have to be extended because we need to draw *something* at the place "occupied by" newline. > The latest changes simply reset the :extend attribute of the "basic" > face used in the merge process, since I believe this is expected in > all the use cases (fingers crossed that no one comes with a valid use > case where it's not TRT). Fingers crossed. Thanks.