From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`" Date: Thu, 02 Jan 2025 21:11:11 +0300 Message-ID: <0dfd124008c28c6eddcefdce110cf940f977ad9c.camel@yandex.ru> References: <173560347147.2633946.7946382225330277437@vcs3.savannah.gnu.org> <20241231000431.DB05AE2FE49@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21341"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.54.2 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 02 19:22:02 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTPpZ-0005LM-5I for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jan 2025 19:22:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTPfi-00064W-8x; Thu, 02 Jan 2025 13:11:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTPfH-0002MD-J6 for emacs-devel@gnu.org; Thu, 02 Jan 2025 13:11:24 -0500 Original-Received: from forward502b.mail.yandex.net ([178.154.239.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTPfF-0006KA-6W for emacs-devel@gnu.org; Thu, 02 Jan 2025 13:11:23 -0500 Original-Received: from mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:43a3:0:640:831e:0]) by forward502b.mail.yandex.net (Yandex) with ESMTPS id 289F360DC1; Thu, 2 Jan 2025 21:11:13 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id BBlDVh5OcmI0-7C0ZJGjJ; Thu, 02 Jan 2025 21:11:12 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1735841472; bh=nCHb2LQrGFt6/3NJyyHHuTubbteJOHiU/h1bjY7JXaM=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=bOq+PrCymUhOL3DZaHkW3nuTQ5clppaqEHUU08kYPZgoVS7rmh5dLbBrAHWwqB2tq YbTQlWlUY0ANf3qQ2zfpD1LL8Eo6Kbt9pRE1aftAAfO3VAmoLbC2kf2oQTW/eHnAb+ 5APuZLttEBfnmFkaBdknG/bysSGUPUDgw4H1MMOo= Authentication-Results: mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: Received-SPF: pass client-ip=178.154.239.146; envelope-from=Hi-Angel@yandex.ru; helo=forward502b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327579 Archived-At: On Mon, 2024-12-30 at 19:08 -0500, Stefan Monnier wrote: > > branch: elpa/scala-mode > > commit c2a4f58643eb505f38c8e341a29400e79f47f442 > > Author: Konstantin Kharlamov > > Commit: Konstantin Kharlamov > >=20 > > =C2=A0=C2=A0=C2=A0 Revert "scala-mode-indent.el: remove unused arg from= `goto- > > block-anchor`" > [...] > > @@ -583,7 +583,7 @@ keyword, or nil if not." > > =C2=A0;;; Block > > =C2=A0;;; > > =C2=A0 > > -(defun scala-indent:goto-block-anchor () > > +(defun scala-indent:goto-block-anchor (&optional point) > > =C2=A0=C2=A0 "Moves back to the point whose column will be used as the > > =C2=A0anchor for calculating block indent for current point (or point > > =C2=A0`point'). Returns point or (point-min) if not inside a block." >=20 > If the argument is unused, then you should rename it to `_point` > which > (by convention) says explicitly that this arg is not used. Oh, thank you! The reason I didn't do this is because when I tried prefixing an optional param with underscore in some other instance, I was getting parsing error. However, I can't reproduce it anymore, and now that I'm trying to, I suspect it wasn't because of the underscore, but rather because the make file in scala-mode sometimes prints `End of file during parsing`, which I attributed to Emacs byte-compiler. The Makefile is very poorly written (it also lacks some `.el` files and it has broken rebuilds because it saves `.latest-build` file for some reason and disregards the el vs elc files timestamps), so=E2=80=A6 yeah, I = just got confused.