From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq Date: Thu, 07 Mar 2019 16:13:27 +0100 Message-ID: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250188"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) To: 34781@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 07 16:50:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1vI1-00130Y-A2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2019 16:50:33 +0100 Original-Received: from localhost ([127.0.0.1]:54249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1vI0-0007kT-4z for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2019 10:50:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1ukm-0003CI-IZ for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:16:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1ukf-0006GC-78 for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:16:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1ukd-0006Cp-2J for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:16:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1ukc-0001LE-Lm for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Mar 2019 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34781 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15519717565134 (code B ref -1); Thu, 07 Mar 2019 15:16:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Mar 2019 15:15:56 +0000 Original-Received: from localhost ([127.0.0.1]:35564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1ukV-0001Kj-N9 for submit@debbugs.gnu.org; Thu, 07 Mar 2019 10:15:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1ukT-0001KW-1a for submit@debbugs.gnu.org; Thu, 07 Mar 2019 10:15:54 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:47092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1ukN-0005y6-7a for submit@debbugs.gnu.org; Thu, 07 Mar 2019 10:15:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1ukM-0002oX-9T for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:15:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1ukH-0005tj-8E for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:15:45 -0500 Original-Received: from mail224c50.megamailservers.eu ([91.136.10.234]:48658 helo=mail33c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1uk7-0005fL-Cl for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 10:15:38 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1551971723; bh=G9jsiSfppCZsepTyjlgSWyB5hC1UoiO/JlhPA7kxVvA=; h=Subject:From:To:Date:From; b=mQU8+4Cdy3AHuhzDBeSik8ysrMZ712KLrOgb4MuiFlncqKEqH1m9awSTuZ/9zH3W6 g6Nz7HTxqkk7+5cQjbBPJhJa8W5B4CFqgeBVpHYRp16IGddFmXsCmIwNXIYONa70pu A0B+lEYHUnc1CKs8ZwwrB1XycX7OB5IWTxOQ/fVo= Feedback-ID: mattiase@acm.or Original-Received: from dhcppc0 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x27FDRUN023113 for ; Thu, 7 Mar 2019 15:15:23 +0000 X-CTCH-RefID: str=0001.0A0B020E.5C81358B.001F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=fZaDNXYF c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=IkcTkHD0fZMA:10 a=cQZZq8QP7GP-45M59_gA:9 a=QEXdDO2ut3YA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156123 Archived-At: (defun f (x) (pcase x ((or 'a #x10000000000000000) t))) (f #x10000000000000000) => nil Just replacing integerp with fixnump fixes this, but I'm not sure if more of the same lurks somewhere. --- a/lisp/emacs-lisp/pcase.el +++ b/lisp/emacs-lisp/pcase.el @@ -792,7 +792,7 @@ pcase--u1 (let ((upat (cddr alt))) (eq (car-safe upat) 'quote))) (let ((val (cadr (cddr alt)))) - (unless (or (integerp val) (symbolp val)) + (unless (or (fixnump val) (symbolp val)) (setq memq-ok nil)) (push (cadr (cddr alt)) simples)) (push alt others))))