From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, help-gnu-emacs@gnu.org
Subject: RE: Emacs pretest: highlight line number in display-line-numbers-mode?
Date: Thu, 19 Oct 2017 13:43:06 -0700 (PDT) [thread overview]
Message-ID: <0da3bf1b-7d66-4462-8097-e9afe759e99d@default> (raw)
In-Reply-To: <<834lquew6p.fsf@gnu.org>>
> This face is by default the same as line-number because of 2 reasons:
>
> . linum-mode did the same
...chasing that rabbit: Why did `linum-mode' do that?
Two wrongs don't necessarily make a right.
> . using a different face makes redisplay slightly slower
> (because it disallows some redisplay optimizations)
Would those optimizations still be available if a
user chose the same face for both (but the faces
were different by default)?
If so, I'd suggest making the faces different by
default. And if the performance difference is
important then perhaps mention it in the doc,
so users who want that optimization at the cost
of not highlighting the current line number can
get it. IOW, opt-in for the loss of a difference.
> > To find the face used, I use `list-faces-display' and look
> > for either a face name that is a likely candidate
> > (`line-number' is pretty obvious, in this case) or a face
> > appearance that matches what I see.
>
> There are other places where this doesn't work, e.g. on the
> mode line.
What do you mean by "this"? Using `list-faces-display'
or the fact that you can't use `C-u C-x =' to learn
the face?
You gave that reply after my mention of the former.
Aren't all of the faces used in the mode line shown in
`list-faces-display'? At least all faces with "mode-line"
in their name are listed there.
There are certainly several places where you cannot use
`C-u C-x =' to see what the face is. (In particular,
places where there is no cursor/buffer position.)
next prev parent reply other threads:[~2017-10-19 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 15:19 Emacs pretest: highlight line number in display-line-numbers-mode? Sivaram Neelakantan
2017-10-19 15:37 ` Robert Pluim
2017-10-19 17:18 ` Drew Adams
2017-10-19 20:09 ` Eli Zaretskii
[not found] ` <<834lquew6p.fsf@gnu.org>
2017-10-19 20:43 ` Drew Adams [this message]
2017-10-20 6:34 ` Eli Zaretskii
2017-10-20 13:49 ` Robert Pluim
2017-10-20 14:49 ` Eli Zaretskii
[not found] ` <<87mv4mexpo.fsf@gmail.com>
[not found] ` <<83h8utdgcq.fsf@gnu.org>
2017-10-20 15:18 ` Drew Adams
2017-10-20 15:42 ` Eli Zaretskii
[not found] ` <<83376ee39c.fsf@gnu.org>
2017-10-20 15:18 ` Drew Adams
2017-10-20 15:52 ` Eli Zaretskii
[not found] <<krpqx3tvyv413v.fsf@gmail.com>
[not found] <<<krpqx3tvyv413v.fsf@gmail.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0da3bf1b-7d66-4462-8097-e9afe759e99d@default \
--to=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.