From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Mon, 22 Apr 2019 15:24:24 +0300 Message-ID: <0d42dab4-6c5c-be3a-d402-f17b39e7fc3c@yandex.ru> References: <87sh806xwa.fsf@chapu.is> <83lg12n75s.fsf@gnu.org> <83h8bqn2ik.fsf@gnu.org> <83zhphliil.fsf@gnu.org> <181b93a3-3861-0481-1b95-8344410d1049@yandex.ru> <83r2a2hdxn.fsf@gnu.org> <21f68973-a684-2a65-82eb-c8f3df90127f@yandex.ru> <83d0lmgez2.fsf@gnu.org> <7d503be9-4d85-3d0b-6829-631ad376ba3d@yandex.ru> <831s22gcci.fsf@gnu.org> <83y349gasn.fsf@gnu.org> <83d0lfag4x.fsf@gnu.org> <5cf45a21-65c3-67ee-f123-be83a6ee7c99@yandex.ru> <83a7gjaen6.fsf@gnu.org> <10ca4e2f-b116-16bc-c81e-24036752c867@yandex.ru> <83lg026xxb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77527"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: p.stephani2@gmail.com, sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 22 14:25:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIY0X-000JyQ-PB for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 14:25:13 +0200 Original-Received: from localhost ([127.0.0.1]:36824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIY0W-0001hv-Nw for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 08:25:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIY0Q-0001hf-Si for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 08:25:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIY0O-0006ig-Pu for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 08:25:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36548) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIY0O-0006iN-Jt for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 08:25:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIY0M-0005Pf-11 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2019 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.155593587520768 (code B ref 31138); Mon, 22 Apr 2019 12:25:01 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 22 Apr 2019 12:24:35 +0000 Original-Received: from localhost ([127.0.0.1]:50092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIXzv-0005Ou-Go for submit@debbugs.gnu.org; Mon, 22 Apr 2019 08:24:35 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:35450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIXzt-0005Og-DW for 31138@debbugs.gnu.org; Mon, 22 Apr 2019 08:24:33 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id o12so12302703wrn.2 for <31138@debbugs.gnu.org>; Mon, 22 Apr 2019 05:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zqbrDlk5oAdh8cp8uwyXhDJX7ma0PoYUF40Vz8bucso=; b=uwS8spPP1BfmPdMP1BW/+GG2/rZNxk5IFMP3gYQRadmOhZAGqY5jDMNyd+eXbJIWVv zR8UbbYknV/lyX4G0aXFk3eLPEXQUQsf5I7GSCQPI77PJRV5i9yiWs824nhMdTGR68ks kebEio7yGeOBymgKl0313qhHw+LH69B4eJHCbzYfljiIyNaVmx1sX3vDHhO5UcEQiAwk P/PighynmBGqukZJZKlDLJJOI/YjTk0bOh8+h8YTdD9xXGyHyFKrMb3PW8/xnlbXAv/h Gcrl9T83YCdxOu49Z5MfCb17DeIXT17E08DmRgDKxwSfnVv6KH2/kT/xHPgcq3QDKl4k FKbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zqbrDlk5oAdh8cp8uwyXhDJX7ma0PoYUF40Vz8bucso=; b=TIdM8/goH/TioWXRW4sQf6O7pBrTmmlDBiVzh3zBHnY2tp9H+4RR6RUnLesdWf+qcl 4zttUL7oKR463fJ8f7X9PE4X4J1RZx6znRQ3VzqHvUDJCDnczGf+vyIzlWmeRES1DS+c pSV4M7KUPtza+k4oZKK4gShjp8y7XS8sBO/4RIVEDBHKBI+a9MTumYGeryBy6k3GMSkc PfimGTM5ldZ/1xO6oXtGFGK9wAAahb8cexf+leCYUHwJItt7KoLrorEqtSH0s/5MRtM8 XWRBFbFHZ6phxfL61SmhmGYDUKVhvuj26UvSTWttZ6iD0PBzukp/3E7/t0WiCo/nxul7 zQeQ== X-Gm-Message-State: APjAAAVcRgK7lADo+TTJo7lzL2YmAE1q0cn/s9/xj550JxYbjVn4QQbb k4bp5feof8yatoow6Jck/Fjorj9G X-Google-Smtp-Source: APXvYqy5r4GQko2smLEJL2EYHlqY2/Nd2QZP1sxDPHpKk7Ux+eUANhdZkrvobh+Aqau4nugqHrCe2Q== X-Received: by 2002:adf:f8d0:: with SMTP id f16mr12984272wrq.198.1555935867513; Mon, 22 Apr 2019 05:24:27 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id z14sm19717684wro.81.2019.04.22.05.24.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 05:24:26 -0700 (PDT) In-Reply-To: <83lg026xxb.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158025 Archived-At: On 22.04.2019 15:12, Eli Zaretskii wrote: > Try using 'true' as the last argument of make_specified_string. Thank you. Tried it, tests now pass, and the performance improvement is the same. I compared the same benchmark (100 iterations, GC disabled for the whole duration), and this patch takes src/emacs -Q --batch -l ~/examples/elisp/json-test.el Elapsed time: 51.153870s down to $ src/emacs -Q --batch -l ~/examples/elisp/json-test.el Elapsed time: 26.268435s Are you still against it? (Just checking).