From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Date: Tue, 20 Dec 2022 22:32:52 -0800 Message-ID: <0d1eac42-1ea4-46d5-6236-eebfa75618ec@gmail.com> References: <83iliiv0yv.fsf@gnu.org> <765547c0-b2a5-b054-a29d-b27002b7442c@gmail.com> <07bcf6a532d0428b9f53@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39284"; mail-complaints-to="usenet@ciao.gmane.io" Cc: John Wiegley , Eli Zaretskii , arstoffel@gmail.com, 59956@debbugs.gnu.org To: Gregory Heytings , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 21 07:34:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7sgm-0009wj-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Dec 2022 07:34:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7sgU-0003dA-HC; Wed, 21 Dec 2022 01:34:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7sfy-0003Q9-P6 for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 01:34:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7sfy-0001OO-GB for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 01:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7sfy-0002gY-1I for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 01:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Dec 2022 06:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59956 X-GNU-PR-Package: emacs Original-Received: via spool by 59956-submit@debbugs.gnu.org id=B59956.167160438210302 (code B ref 59956); Wed, 21 Dec 2022 06:34:02 +0000 Original-Received: (at 59956) by debbugs.gnu.org; 21 Dec 2022 06:33:02 +0000 Original-Received: from localhost ([127.0.0.1]:49754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7sf0-0002g6-7y for submit@debbugs.gnu.org; Wed, 21 Dec 2022 01:33:02 -0500 Original-Received: from mail-pj1-f54.google.com ([209.85.216.54]:55067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7sex-0002fi-Jj for 59956@debbugs.gnu.org; Wed, 21 Dec 2022 01:33:00 -0500 Original-Received: by mail-pj1-f54.google.com with SMTP id x3so426649pjv.4 for <59956@debbugs.gnu.org>; Tue, 20 Dec 2022 22:32:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CTmGRZLoRp6MyNZNGqaf+t4zxj9fdXwBShQugNnODgU=; b=oMd/4dkq7f5PstE8SnETa31Ojq5DJ5mKDybO7n0jQVHViL5jGjVr4YaZksg8RqfM16 u4ZsQOttv0iuwbQTWeVsqJgSyeYjaFyA6iBkBNN3rQnX7q7DW00XnyUCNSFiLk/hJ9sS 7IKyd0sLfi/S25ge2E6Y1vfqwjswA/b4FM3QiqAwwtTuMM9/hShpaM3AJwOTEk7XtQxH Dhvd4HuUpJJaBUT69IHdjp6UzGKPI+uJtDRPO3F8KxRCHQwVqD+2l+tEIbQ+Eqep61ss PQ2eq3G4t9gOjYBlrNP6wrcAu5pDhipu0ycS8r4GjrPiYlV7HXeJ10xSfF6S8BfO2XQx hb+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CTmGRZLoRp6MyNZNGqaf+t4zxj9fdXwBShQugNnODgU=; b=StaR5cg/TM28Zt+OPobwQsmNQTzgHlNNYeW8azz3OIUZCoroPCi7NHYnvhm0HZUid+ o4lVmVY/sS+nLoRTKXWKy6C0MgO4t5SbVFBVPRkMkRS+3mG2fgIInWM6P17IJyBkGUIs qz6HHnuiEyDtkTcIlRf1spYT9RIvf9BNoXMioMUmYXgoSFzhUoVrxd1OKRGqxC74ZPdl fj7imWcKGiGpNtwWM8yW0FRopfZXobu1qdoWhi6TusS6JSfONnCU10dqJfhvzZ4+AhL4 H/jRptpj3KL6yl2UdDbR5vh+vrEvoFjSUb2tWcFuCZLdS9cq/vzxJYJU+r0iY8A9elcx 2hEw== X-Gm-Message-State: AFqh2kq15ExUuv5t7KXBn8t4hdNRa4hgn6ZkoyIzlGRYtIyc5hPBRiy2 +7IyhyH4MLXFyKP/N4h6BXw= X-Google-Smtp-Source: AMrXdXs89KFPzs3GPpSBlaY/7Y52l1UGz2Q3dvf0QEnA/kdF8BKpbRsdKqkS2oeYTrUytTJAuy6tCQ== X-Received: by 2002:a17:902:680f:b0:189:bbd3:a5a7 with SMTP id h15-20020a170902680f00b00189bbd3a5a7mr826484plk.51.1671604373651; Tue, 20 Dec 2022 22:32:53 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p6-20020a170902a40600b001766a3b2a26sm10506501plq.105.2022.12.20.22.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 22:32:53 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251568 Archived-At: On 12/19/2022 2:22 PM, Gregory Heytings wrote: > Augusto and Jim, can you please try the attached patch and tell us if it > fixes the issue without introducing regressions? It works for me after a bit of testing, thanks. I don't see any regressions on the Eshell side of things, at least. While it would be nice to have a way for Eshell to provide multiple forms of its arguments for completion (one for external commands that expect a flat list of strings, and another for Eshell commands), that seems like a lot more work that would probably be better spent elsewhere. (And a change like that would be too big for the release branch anyway.)