From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#59347: 29.0.50; `:family` face setting ignored Date: Tue, 22 Nov 2022 07:59:22 +0000 Message-ID: <0d1ea3007fb4172bc39c@heytings.org> References: <83cz9j9zyu.fsf@gnu.org> <838rk77yfo.fsf@gnu.org> <834juu9aya.fsf@gnu.org> <7cc9e03786024fc72f3b@heytings.org> <83a64l65ai.fsf@gnu.org> <7cc9e0378678a092e6ee@heytings.org> <835yf962q4.fsf@gnu.org> <7cc9e03786754c9e0aaf@heytings.org> <83zgcl4jra.fsf@gnu.org> <7cc9e03786c281cffdd4@heytings.org> <83tu2t4ie9.fsf@gnu.org> <7cc9e03786e324ff82ef@heytings.org> <83bkp04gjl.fsf@gnu.org> <83leo42vm9.fsf@gnu.org> <0d1ea3007fd94b7ae0b1@heytings.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="E2Tj3BnqNk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="883"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59347@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 09:00:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxOCe-000Adg-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 09:00:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxOCM-00065h-Bl; Tue, 22 Nov 2022 03:00:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxOCI-00065O-Nl for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 03:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxOCI-0005iN-9Q for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 03:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxOCI-0002KI-2z for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 03:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59347 X-GNU-PR-Package: emacs Original-Received: via spool by 59347-submit@debbugs.gnu.org id=B59347.16691039698880 (code B ref 59347); Tue, 22 Nov 2022 08:00:02 +0000 Original-Received: (at 59347) by debbugs.gnu.org; 22 Nov 2022 07:59:29 +0000 Original-Received: from localhost ([127.0.0.1]:49627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxOBk-0002JA-U4 for submit@debbugs.gnu.org; Tue, 22 Nov 2022 02:59:29 -0500 Original-Received: from heytings.org ([95.142.160.155]:54080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxOBg-0002Iz-0W for 59347@debbugs.gnu.org; Tue, 22 Nov 2022 02:59:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669103962; bh=vbFqPXPhf7iPAxvLcssZSo1CcgknyhDxKNS4Vzl6YrY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=JAE5g32Cr12tsyZ5iTuxpOBuA8aQqUA4e9craOdW25Bo5yKg31Uu1MISJEdCNJzF5 Fs+Dd8w3Zr+hW8zsAR9TTRHEWQe+08ijrYn8UqPH5Ns5no1w3Pd+uGDzrC3ci8XXXC MYO4r6BJWPKMihgU6gEGMjuRD+PJQLH1HRsR6OUTkRNHRggs1pxsATLUEti7fRBmWT akRPJ2Sz41mdFc7f+xk2J7GVe/kFgK6SWqUXXSQ+8zdccFIsFYVIFelHI3LzF+pd7x KC8EtnH5GpsM/irYKcJ2AMhwJ81KJyuS9EAekO5xfZfeh374P5vGCD60l+rTs0FN+M NlEIXkO58hR2A== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248614 Archived-At: --E2Tj3BnqNk Content-Type: text/plain; format=flowed; charset=us-ascii >> By the way, I suspect (but do not have a recipe right now) that the >> same bug exists with the :width and :slant attributes (namely, that >> setting the font for the default face with an "exotic" value leads to >> suboptimal/wrong font choices for other faces), and that they should >> also be set to nil in font_find_for_lface. > > IIUC the way we manage choose fonts is that we ask for a list of fonts > matching a particular pattern. If that list is empty we make the > pattern more coarse and try again. And when the list is not empty we > choose the best fit based on a score. > Yes, that's roughly speaking what is happening indeed. Except that if we constraint, when we build it, the list of candidates to a specific weight and/or slant and/or width, scoring the candidates becomes pointless, because all candidates in the list will (by definition) be perfect matches. > > So in essence, what you're saying is that we should rely more on > scoring, and start with a coarser pattern right from the beginning? > What I'm saying (now) is that we should rely on scoring, not that we should rely _more_ on scoring. New (again) patch attached. --E2Tj3BnqNk Content-Type: text/x-diff; name=Unset-the-weight-slant-width-in-font-specs-when-sear.patch Content-Transfer-Encoding: base64 Content-ID: <0d1ea3007f242d54a0e4@heytings.org> Content-Disposition: attachment; filename=Unset-the-weight-slant-width-in-font-specs-when-sear.patch RnJvbSBkMjEwMTdjOGIyZmRmMDE3Zjc4MjE3YjM0ZTZhNTQxMWI2MDVlMzdj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUdWUsIDIyIE5v diAyMDIyIDA3OjU4OjMwICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIFVuc2V0 IHRoZSB3ZWlnaHQvc2xhbnQvd2lkdGggaW4gZm9udCBzcGVjcyB3aGVuIHNl YXJjaGluZyBmb3INCiBhIGZvbnQNCg0KQmV0d2VlbiBjb21taXRzIGJmMGQz Zjc2ZGMgKDIwMTQpIGFuZCA2YjFlZDJmMmM5ICgyMDIyKSwNCnJlYWxpemVf Z3VpX2ZhY2UgY2FsbGVkIGZvbnRfbG9hZF9mb3JfbGZhY2Ugd2l0aCBhbiBl bXB0eSBvciBwYXJ0bHkNCmVtcHRpZWQgZm9udCBzcGVjLCBpLmUuIGl0IGln bm9yZWQgYSBwYXJ0IG9mIGl0cyBhdHRycyBhcmd1bWVudC4gIFRoZQ0KcmF0 aW9uYWxlIGdpdmVuIGluIGJ1ZyMxNzk3Mywgd2hpY2ggbGVkIHRvIGJmMGQz Zjc2ZGMsIGlzIG5vdCBjbGVhci4NCkhvd2V2ZXIsIDZiMWVkMmYyYzkgbGVh ZHMgdG8gc3Vib3B0aW1hbCBmb250IGNob2ljZXMsIGluIHBhcnRpY3VsYXIN CndoZW4gdGhlIGZvbnQgY2hvc2VuIGZvciB0aGUgZGVmYXVsdCBmYWNlIGhh cyBhIHdlaWdodCwgc2xhbnQgb3Igd2lkdGgNCnRoYXQgaXMgbm90IHN1cHBv cnRlZCBieSBvdGhlciBhdmFpbGFibGUgZm9udHMgb24gdGhlIHN5c3RlbSwg c3VjaCBhcw0KJ21lZGl1bScgb3IgJ2hlYXZ5Jy4gIEZ1cnRoZXJtb3JlLCBj YWxsaW5nIGZvbnRfbGlzdF9lbnRpdGllcyB3aXRob3V0DQp1bnNldHRpbmcg dGhlc2UgYXR0cmlidXRlcyBhcmJpdHJhcmlseSBsaW1pdHMgdGhlIG51bWJl ciBvZiBjYW5kaWRhdGVzDQp0byBvbmx5IHRob3NlIHRoYXQgYXJlIHBlcmZl Y3QgbWF0Y2hlcywgd2hpY2ggbWVhbnMgdGhhdCBzY29yaW5nIHRoZQ0KY2Fu ZGlkYXRlcyBiZWNvbWVzIGluIGZhY3QgcG9pbnRsZXNzLiAgVGhlcmVmb3Jl LCB0aGUgd2VpZ2h0LCBzbGFudA0KYW5kIHdpZHRoIGF0dHJpYnV0ZXMgaW4g dGhlIHNwZWMgYXJndW1lbnQgdG8gZm9udF9maW5kX2Zvcl9sZmFjZSBtdXN0 DQpiZSB1bnNldCwgbGlrZSB0aGUgc2l6ZSBhdHRyaWJ1dGUuDQoNCiogc3Jj L2ZvbnQuYyAoZm9udF9maW5kX2Zvcl9sZmFjZSk6IFVuc2V0IHRoZSB3ZWln aHQsIHNsYW50IGFuZCB3aWR0aA0Kb2YgdGhlIGZvbnQgc3BlYy4gIEZpeGVz IGJ1ZyM1NzU1NSBhbmQgYnVnIzU5MzQ3Lg0KLS0tDQogc3JjL2ZvbnQuYyB8 IDkgKysrKysrKysrDQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygr KQ0KDQpkaWZmIC0tZ2l0IGEvc3JjL2ZvbnQuYyBiL3NyYy9mb250LmMNCmlu ZGV4IDZlNzIwYmMyODUuLjA3MjNlMDgwZGQgMTAwNjQ0DQotLS0gYS9zcmMv Zm9udC5jDQorKysgYi9zcmMvZm9udC5jDQpAQCAtMzAwMyw2ICszMDAzLDE1 IEBAIGZvbnRfZmluZF9mb3JfbGZhY2UgKHN0cnVjdCBmcmFtZSAqZiwgTGlz cF9PYmplY3QgKmF0dHJzLCBMaXNwX09iamVjdCBzcGVjLCBpbnQNCiAgICAg fQ0KICAgQVNFVCAod29yaywgRk9OVF9TSVpFX0lOREVYLCBRbmlsKTsNCiAN CisgIC8qIFVuc2V0IHRoZSBmb250IHdlaWdodCwgc2xhbnQgYW5kIHdpZHRo LiAgVGhlIGJlc3QgcG9zc2libGUgdmFsdWVzDQorICAgICBmb3IgdGhlc2Ug YXR0cmlidXRlcyBpcyBkZXRlcm1pbmVkIGxhdGVyLCB3aGVuIHRoZSBjYW5k aWRhdGUgbGlzdA0KKyAgICAgcmV0dXJuZWQgYnkgZm9udF9saXN0X2VudGl0 aWVzIGlzIHNvcnRlZCBieSBmb250X3NlbGVjdF9lbnRpdHkNCisgICAgICh3 aGljaCBjYWxscyBmb250X3NvcnRfZW50aXRpZXMsIHdoaWNoIGNhbGxzIGZv bnRfc2NvcmUpLiAgU2VlDQorICAgICBidWcjNTkzNDcuICAqLw0KKyAgQVNF VCAod29yaywgRk9OVF9XRUlHSFRfSU5ERVgsIFFuaWwpOw0KKyAgQVNFVCAo d29yaywgRk9OVF9TTEFOVF9JTkRFWCwgUW5pbCk7DQorICBBU0VUICh3b3Jr LCBGT05UX1dJRFRIX0lOREVYLCBRbmlsKTsNCisNCiAgIC8qIEZvdW5kcnkg c3BlY2lmaWNhdGlvbiBhbHRlcm5hdGl2ZXM6IGZyb20gdGhlIG1vc3Qgc3Bl Y2lmaWMgdG8gdGhlDQogICAgICBsZWFzdCBzcGVjaWZpYyBhbmQgZmluYWxs eSBhbiB1bnNwZWNpZmllZCBvbmUuICAqLw0KICAgZm91bmRyeVswXSA9IEFS RUYgKHdvcmssIEZPTlRfRk9VTkRSWV9JTkRFWCk7DQotLSANCjIuMzUuMQ0K DQo= --E2Tj3BnqNk--