From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root Date: Wed, 30 Dec 2020 04:06:46 +0200 Message-ID: <0cc833b3-8d7e-56b7-f55c-a63c1ac22313@yandex.ru> References: <6d6911b9-c604-1fca-3cd4-084a8880524f@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6471"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 45135@debbugs.gnu.org To: Tobias Rittweiler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 30 03:07:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuQtK-0001ak-HG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 03:07:10 +0100 Original-Received: from localhost ([::1]:55114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuQtJ-0007EC-5c for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 21:07:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuQtC-0007E3-Uh for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 21:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57246) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuQtC-0006I7-Nq for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 21:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuQtC-0003zo-Gp for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 21:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2020 02:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45135 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45135-submit@debbugs.gnu.org id=B45135.160929402015352 (code B ref 45135); Wed, 30 Dec 2020 02:07:02 +0000 Original-Received: (at 45135) by debbugs.gnu.org; 30 Dec 2020 02:07:00 +0000 Original-Received: from localhost ([127.0.0.1]:40559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuQt9-0003zY-Kv for submit@debbugs.gnu.org; Tue, 29 Dec 2020 21:06:59 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:39628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuQt5-0003zF-Lu for 45135@debbugs.gnu.org; Tue, 29 Dec 2020 21:06:58 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id 3so3613911wmg.4 for <45135@debbugs.gnu.org>; Tue, 29 Dec 2020 18:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l1TOij1SEt3Pk66H3qjqZnjemWs637t6xDDQAWTNlJo=; b=NkorWWr/3w+eYBLsxn8iW7sF2+TKfdTlKzAtHENueHFAYDdau2r3JKwqz/jqRUmPxx 6Pa7J2fLmPGLVqThGwFG6mCwHNAvLGpJ/26Obg1BNl/G46WBzI2r1H0yAfpOGrnwVNy3 ATSyYmar67R7KKL9OUsEm4yNOlfLVM9Poc25Dke8uPOub4NFO11vbOlsHa9UZIAPhSlI u+MgEPcuge6TYC3BWKPcyZAdHGzPOUn/R6DURDCDLaF3ouwzh9Y1n0ZCyHJj3uHgAksM K5v+OSdBXdZLKiFf+hhRi13ImIfKXJsrSOOZ9bunrHZRgkOm80SEPhlysxvurHrVojY3 N9LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l1TOij1SEt3Pk66H3qjqZnjemWs637t6xDDQAWTNlJo=; b=smlEy23sts9QMgLlr9ETJJuLgtZjhrigg0ilmaQP9Ok5jjIloWa6IyLSyDJpBNM5wg pw4qCzHboOlL144CrUQ9QNzmk7lNnVzQRCA5S/hryi3GjJJWPp+qfI8voRh47yhDoA1D NaHZi64kb2Mfa2ggMTjhXdXGM4MICz0f7tohBCxSNBmisBg6DMzt15SSteisc29lS84L 4q4/9rPweuXMVs4sKhzWSR8Lj6NNJaUJIhl0uRt10gtjX1DQZt+G6yUT8RcZ2Rhpn7CU paTX5Gqcg15f5H3ESfTqMr5ZIrD52Ke767mNXQJ7oWhficObahsMSYbSyqanLCTqAq/o JRWg== X-Gm-Message-State: AOAM533Tz7o/SfOcOyJ1MlCxvG5AbLdp08X62H2mUlMj3+XhyS91bCh6 BQjFxnGWofb5/v/kLcu12YwNzRb42AErJg== X-Google-Smtp-Source: ABdhPJy9yWcVaG2QfLrtFP5gi8zgms3p7P0Gw8/pBQK3tlR25e+t8My583rzL+PW3Q4lsjItn1Cl4g== X-Received: by 2002:a1c:630b:: with SMTP id x11mr5516809wmb.138.1609294009639; Tue, 29 Dec 2020 18:06:49 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id y130sm5728492wmc.22.2020.12.29.18.06.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Dec 2020 18:06:48 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196992 Archived-At: On 27.12.2020 09:10, Tobias Rittweiler wrote: > Could you clarify the reason for the first patch? Did you have any test > failures (on Ubuntu 20.04.1?) with the current test code because of the > "random" filesystem traversal order? Thanks! > > > The original code *did* already fix the file order in the test where it > actually mattered: > 'xref-matches-in-directory-finds-some-for-bar'. Note that no other test > actually involve > locations from multiple files in a way that is dependent on the order. > > The patch does not serve any actual utility except for code hygiene: it > reduces a bit > of trivial code duplication. Feel free to ignore it. (But in case you do > add tests for > 'xref-file-name-display' being 'relative', please make sure you write > the tests in a way > that makes it independent from the filesystem traversal order.) > Tobias Thanks for the explanation (and the patch), I just wanted to make sure whether I missed something. I'll push this one now.