From: Dmitry Gutov <dgutov@yandex.ru>
To: Tobias Rittweiler <trittweiler@gmail.com>
Cc: 45135@debbugs.gnu.org
Subject: bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root
Date: Wed, 30 Dec 2020 04:06:46 +0200 [thread overview]
Message-ID: <0cc833b3-8d7e-56b7-f55c-a63c1ac22313@yandex.ru> (raw)
In-Reply-To: <CANXFPyVSBZ5SDNXjX8z4PUhkTCsOAOgFF_da4Abk0JzyNKwNZg@mail.gmail.com>
On 27.12.2020 09:10, Tobias Rittweiler wrote:
> Could you clarify the reason for the first patch? Did you have any test
> failures (on Ubuntu 20.04.1?) with the current test code because of the
> "random" filesystem traversal order? Thanks!
>
>
> The original code *did* already fix the file order in the test where it
> actually mattered:
> 'xref-matches-in-directory-finds-some-for-bar'. Note that no other test
> actually involve
> locations from multiple files in a way that is dependent on the order.
>
> The patch does not serve any actual utility except for code hygiene: it
> reduces a bit
> of trivial code duplication. Feel free to ignore it. (But in case you do
> add tests for
> 'xref-file-name-display' being 'relative', please make sure you write
> the tests in a way
> that makes it independent from the filesystem traversal order.)
> Tobias
Thanks for the explanation (and the patch), I just wanted to make sure
whether I missed something. I'll push this one now.
prev parent reply other threads:[~2020-12-30 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 15:08 bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root Tobias Rittweiler
2020-12-23 2:16 ` Dmitry Gutov
2020-12-26 2:21 ` Dmitry Gutov
2020-12-26 7:54 ` Eli Zaretskii
2020-12-27 6:55 ` Tobias Rittweiler
2020-12-30 12:05 ` Dmitry Gutov
2020-12-27 7:10 ` Tobias Rittweiler
2020-12-30 2:06 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc833b3-8d7e-56b7-f55c-a63c1ac22313@yandex.ru \
--to=dgutov@yandex.ru \
--cc=45135@debbugs.gnu.org \
--cc=trittweiler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.