From: Paul Eggert <eggert@cs.ucla.edu>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Returning argument string (regexp-quote)
Date: Tue, 24 Sep 2019 11:24:12 -0700 [thread overview]
Message-ID: <0c4254dd-42ea-5e47-f1b5-c00a326753e2@cs.ucla.edu> (raw)
In-Reply-To: <658AF539-1AE7-459D-94C7-44970AA94EEF@acm.org>
On 9/24/19 10:44 AM, Mattias Engdegård wrote:
> What about the specific case of regexp-quote then?
> It was responsible for a sizeable portion of local consing in some (non-public) code I was profiling.
> Would the change need a mention in NEWS, and/or its doc string?
The performance case for regexp-quote is reasonably strong. This is
similar to the 'format' function, which is called a lot, which does not
allocate a string if its argument is simple, and where its callers are
extremely unlikely to rely on its allocating a string in that case.
Changes should be mentioned in NEWS and the adjusted behavior should be
mentioned in the manual; I don't think it needs to be in the doc string.
Please see commit 2017-10-04T21:29:58Z!eggert@cs.ucla.edu for how the
doc was done in the 'format' case.
next prev parent reply other threads:[~2019-09-24 18:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 11:28 Returning argument string (regexp-quote) Mattias Engdegård
2019-09-24 11:49 ` Andreas Schwab
2019-09-24 16:20 ` Eli Zaretskii
2019-09-24 17:44 ` Mattias Engdegård
2019-09-24 18:24 ` Paul Eggert [this message]
2019-09-24 19:47 ` Eli Zaretskii
2019-09-25 13:41 ` Mattias Engdegård
2019-09-25 15:08 ` Eli Zaretskii
2019-09-25 19:55 ` Compilation failure on macOS 10.15 Catalina Zach Pearson
2019-09-25 20:29 ` mituharu
2019-09-25 21:55 ` Zach Pearson
2019-09-25 22:47 ` mituharu
2019-09-25 23:07 ` Zach Pearson
2019-09-25 23:39 ` mituharu
2019-09-27 23:22 ` chad
2019-10-02 3:59 ` Zach Pearson
2019-10-02 4:04 ` YAMAMOTO Mitsuharu
2019-10-02 4:34 ` Zach Pearson
2019-10-02 4:42 ` YAMAMOTO Mitsuharu
2019-10-02 4:43 ` Zach Pearson
2019-10-02 5:00 ` YAMAMOTO Mitsuharu
2019-10-02 5:07 ` Zach Pearson
2019-10-02 7:43 ` Zach Pearson
2019-10-02 15:15 ` Xu Xin
2019-09-26 8:34 ` Robert Pluim
2019-09-26 16:05 ` Zach Pearson
2019-09-26 21:00 ` mituharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c4254dd-42ea-5e47-f1b5-c00a326753e2@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.