From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Philipp Uhl" Newsgroups: gmane.emacs.bugs Subject: bug#62952: 28.2.50; secrets.el unlocking items Date: Tue, 09 May 2023 10:15:09 +0200 Message-ID: <0c22791a-2c75-4e54-87b6-a2e90fd70054@app.fastmail.com> References: <87fs8u6bm1.fsf@gmx.de> <0a74e18e-d972-43b6-b661-cee36b08ddb4@app.fastmail.com> <871qjzgdow.fsf@gmx.de> <87a5yfaw23.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12861"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.9.0-alpha0-415-gf2b17fe6c3-fm-20230503.001-gf2b17fe6 Cc: 62952-done@debbugs.gnu.org To: "Michael Albinus" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 09 10:16:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwIW3-00039K-RQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 May 2023 10:16:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwIVz-0004sX-W5; Tue, 09 May 2023 04:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwIVw-0004mv-8e for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 04:16:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwIVv-0002xr-Pt for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 04:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwIVu-00037b-5y for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 04:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Philipp Uhl" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 May 2023 08:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62952 X-GNU-PR-Package: emacs Original-Received: via spool by 62952-done@debbugs.gnu.org id=D62952.168362014011967 (code D ref 62952); Tue, 09 May 2023 08:16:02 +0000 Original-Received: (at 62952-done) by debbugs.gnu.org; 9 May 2023 08:15:40 +0000 Original-Received: from localhost ([127.0.0.1]:42355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwIVX-00036x-UN for submit@debbugs.gnu.org; Tue, 09 May 2023 04:15:40 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:58623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwIVV-00036f-El for 62952-done@debbugs.gnu.org; Tue, 09 May 2023 04:15:38 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4B6AE5C00C1; Tue, 9 May 2023 04:15:30 -0400 (EDT) Original-Received: from imap48 ([10.202.2.98]) by compute3.internal (MEProxy); Tue, 09 May 2023 04:15:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ph-uhl.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1683620130; x=1683706530; bh=Xg TCAtAKJWlgY9B7D8ThGpghwd+dafDj28Gc6x4IuZ8=; b=ENgjMEMnkrOlrpPvYE zZE9ZRaWnVco9/Ak5uIE0955yJyYIk2wxnvnkSmuGZWh4SvW33KXmsVsQ6CtwEcd uaofMnX5bAFcd82FhK/Gx9ko+a2BgnZdTGOJ24fJVQetNhxXPGOy87YsPm1zB5xr 0yc8o/A8otqoTyEc+Q+Mbnt3W1f5Lkq260e3p923MF2Tv0QKXoDR7qVL3pvT+442 OtonsZyWCDwmgB7JHMnU7H+Om4cQoPSaSSSlyz+haTgnBTOIjoUH0jNHHi+G0I/V thSgSp1dZ4jfe+zI49gRvR8VzF1WyDAemqq8XahrR0KEvBt31jCAeRt8IJKmYn/V 7avg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683620130; x=1683706530; bh=XgTCAtAKJWlgY 9B7D8ThGpghwd+dafDj28Gc6x4IuZ8=; b=ZTYxwOxYSFDvvtrldYSXKc6aUC0QS dLnu7s7T2GY/A2wQ8h+x2Wp8ei3Q7YyXmbOXIzPi9aP0rhWuAvhZZfVjx4wmN/vt qQHmkksFfBhTrg2FbgsDboBPKp6R2kSE1kMF/mkCvCb8UyBqBHrt1HDBfPQjmhex pAfh/cWpNJIHM5uV1AM0HZY5efiuSm8TIv8moDYJI6vyusBlu4PQZN8RUNcDo5JK nnDovGZlVykXYt2IKPAJurRkXGO+tzFnbNwzPGwxPnkDR6+AufO1sQ75YNwrZLYG bZV7FqNRiKCtQRCa4ncg6XvjjhgPc84taNSl+T+uut0AD5A24lSdPKacw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegtdcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdfrhhhilhhi phhpucgfhhhlfdcuoehgihhtsehphhdquhhhlhdrtghomheqnecuggftrfgrthhtvghrnh epgfekffegueehgfefledthefhfeekgffhtdevleefheefgfefleejtddtvdelueejnecu ffhomhgrihhnpegvlhdrihhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepghhithesphhhqdhuhhhlrdgtohhm X-ME-Proxy: Feedback-ID: i17694467:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id E154331A0063; Tue, 9 May 2023 04:15:29 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <87a5yfaw23.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261391 Archived-At: Hi Michael, thank you. Sounds great. Best, Philipp ----------------------------- Philipp Uhl git@ph-uhl.com Am Mo, 8. Mai 2023, um 13:42, schrieb Michael Albinus: > Version: 30.1 > > Michael Albinus writes: > > Hi Philipp, > >>> thanks for your response. Here is the secrets-lock-item function: >> >> Thanks. I'll check it next days. > > I've played this morning with your changes. Everything looks fine (in my > environment), so I have pushed them to the Emacs master branch. > >>>> Bonus points for respective tests in secrets-tests.el. >>> >>> I didn't find any secrets-tests.el in the Emacs repository. Also I am >>> not really familiar with writing test code in Elisp. But I did >>> manually test the code and it works. >> >> See test/lisp/net/secrets-tests.el in the git repository. Tests are >> performed using ERT, see (info "(ert) Top") for the manual. > > I've tried to see how it works with this, but it looks like the > temporary "session" session of Gnome keyring, which I use, doesn't care > about locking/unlocking of single items. So likely it isn't worth to > extend secrets-tests.el. > > I'm closing the bug. > >>> Cheers, Philipp > > Best regards, Michael.