From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Date: Sat, 22 Aug 2020 10:46:12 -0700 (PDT) Message-ID: <0bbb4ae1-9e14-4f8c-aca5-4e44941d8e86@default> References: <96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> <469bf659-07b6-8172-287c-2abc53582447@yandex.ru> <83zhoi74vl.fsf@gnu.org> <44b1aa8a-c06c-61f7-0948-0fd20605e938@yandex.ru> <83y34273mu.fsf@gnu.org> <2979c506-20e4-4b9f-0215-6f0241238678@yandex.ru> <83v9z6732b.fsf@gnu.org> <87ft8elp4h.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28035"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 35353@debbugs.gnu.org To: Lars Ingebrigtsen , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 22 19:47:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9Xbi-0007BB-PT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Aug 2020 19:47:10 +0200 Original-Received: from localhost ([::1]:45932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9Xbh-0000TW-DR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Aug 2020 13:47:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9Xba-0000T4-RZ for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 13:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39809) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9Xba-0004sm-IK for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 13:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9Xba-0005N2-Ez for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 13:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Aug 2020 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35353 X-GNU-PR-Package: emacs Original-Received: via spool by 35353-submit@debbugs.gnu.org id=B35353.159811838920595 (code B ref 35353); Sat, 22 Aug 2020 17:47:02 +0000 Original-Received: (at 35353) by debbugs.gnu.org; 22 Aug 2020 17:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:51355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9Xb3-0005M7-2U for submit@debbugs.gnu.org; Sat, 22 Aug 2020 13:46:29 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:48474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9Xaz-0005Lq-9R for 35353@debbugs.gnu.org; Sat, 22 Aug 2020 13:46:28 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07MHiRYf181894; Sat, 22 Aug 2020 17:46:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=56TJeGOm8MJxxou4joIMLzQW3lAU7mUTj9xi7LZBIKI=; b=YBWXCqAapWqwjX8EogzMRTj7h8+gh46OuCi61fi7zULSVWw8B6ySKuidFiPEcXZ1DMEO IkxUUvbxQEUBN9HZUAsDIfQFW95ZepHhyCKZVwLe1Iv3NYgKoH1v0tfGKhPiDg9bzCNG 6cc1G8/DuejJGUkx85AsWrNBIHFiIOgqOG5/6rCUZ9QeI2l8H08ftAY8WKc3IN3WNvmF SnaxCvzdnTWP3xWZA9BhegejpJodhJUao4Abhl8RBcr6EHtnnLVJq2bNn+Tkx7DSje0X Uy0Hl7vodPaeWWJpxyQLKE7X9dRxuGMeNWCpxECFyY7L0jQ00xOmNV4mqH8WMrFwK2dX IQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 332tsqhave-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 22 Aug 2020 17:46:19 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07MHi00C129403; Sat, 22 Aug 2020 17:46:18 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 332u60p0fs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Aug 2020 17:46:18 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07MHkDA9005444; Sat, 22 Aug 2020 17:46:15 GMT In-Reply-To: <87ft8elp4h.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9720 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=959 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=18 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008220195 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9720 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 suspectscore=18 phishscore=0 clxscore=1011 mlxscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=951 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008220195 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185980 Archived-At: > > - (define-key map [mouse-1] #'xref-goto-xref) > > - (define-key map [mouse-2] #'xref--mouse-2) > > + (define-key map [follow-link] 'mouse-face) > > + (define-key map [mouse-2] #'xref-goto-xref) > > + (define-key map [mouse-1] #'xref--mouse-2) >=20 > I think that this is basically what most modes that have clickable stuff > do, so I think it might be the right solution for xref, too (even if > xref doesn't have buttons per se). IOW, your conclusion is "Won't fix". That is not what most modes that have links do. Most such modes have `down-mouse-1' do `mouse-drag-region' and `mouse-1' do `mouse-set-point'. For users who want `mouse-1' to follow a link, it is option `mouse-1-click-follows-link' that takes care of that. And even when that is non-nil, a user can set point with `mouse-1', by simply holding `mouse-1' pressed more than 450 milliseconds. That's the behavior that's requested here - the USUAL Emacs behavior for `mouse-1' on links. Nothing more. This is nothing new, nothing unusual. What's unusual is the xref behavior.