From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#33446: 26; `isearch-lazy-highlight-update' in MASTER today Date: Wed, 21 Nov 2018 14:50:56 -0800 (PST) Message-ID: <0ba62b0e-d257-405d-a358-cee30725f4c6@default> References: <2c20f006-c54f-423e-ad4e-f1208f3fa179@default> <87h8gb5owm.fsf@mail.linkov.net> <064c334d-cfd8-4610-a320-2d4ca68b437b@default> <87y39mdpd1.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1542841021 18931 195.159.176.226 (21 Nov 2018 22:57:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2018 22:57:01 +0000 (UTC) Cc: 33446-done@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 21 23:56:57 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbQW-0004p5-Mt for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 23:56:56 +0100 Original-Received: from localhost ([::1]:42888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbSd-0001OU-5w for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 17:59:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbM0-0002vL-QO for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:52:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPbLu-0008WS-Tp for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:52:16 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36065) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPbLm-0008N8-HB for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPbLm-00053B-16 for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Nov 2018 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 33446-done@debbugs.gnu.org id=D33446.154284067119356 (code D ref 33446); Wed, 21 Nov 2018 22:52:01 +0000 Original-Received: (at 33446-done) by debbugs.gnu.org; 21 Nov 2018 22:51:11 +0000 Original-Received: from localhost ([127.0.0.1]:40323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbKx-000528-Hy for submit@debbugs.gnu.org; Wed, 21 Nov 2018 17:51:11 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:45736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbKv-00051s-Ig for 33446-done@debbugs.gnu.org; Wed, 21 Nov 2018 17:51:10 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wALMitaU043479; Wed, 21 Nov 2018 22:51:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=R+2qWSdYzzB1dMV80YsmwzqtUt0YP3ypwxcxYmAEEYU=; b=YB06lGH5WYE6yG4RtKlnVEx30bFGjf8oci9R+S1WbmvyBsPS9cf2iDXqKWLT/cDs9PZB UbC+3uRlxX2lg0/1VP2uPKXnkOU+liaEYyDg7BqhZQz0gq3KgL122yHArMwOafkpmw3m la2l8IGs47zQhXHhvNv29iVBqI3PYAfXOZh2+DJzwKeW7aE7CpRcJidD8hfRTf+8Mc4H Xtqv5p1uMTLoeP5C4Nt13lYIECIXMuXmeXr8AFKvJCCGknY46oFZIlJXih5JAoNN3nFG UFr0RfSkMes9Q8odrw6BtZQe1vRePuB2kRWuB4TDvfkplNcmV+OdqVS0UDs4QEjkAIN1 ew== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2ntbmquwyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 22:51:03 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wALMow33024121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 22:50:58 GMT Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wALMovUI024534; Wed, 21 Nov 2018 22:50:57 GMT In-Reply-To: <87y39mdpd1.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9084 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=921 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811210198 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152651 Archived-At: > > Yes, I guessed that finally. Beyond that, I think it's > > not intended to be invoked outside of search (i.e., > > when `isearch-mode' is nil). That was my mistake: > > invoking it in a command that can be used during Isearch > > or not. > > > > I know that wasn't intended as part of the Isearch > > design. Now I test for it and avoid calling `i-l-h-u'. > > > > (But it might not hurt for `i-l-h-u' itself to test and > > do nothing if `isearch-mode' is nil. I'm not requesting > > that, however.) >=20 > isearch-lazy-highlight-update can't test for non-nil > isearch-mode, because it's also used in non-isearch cases > like in query-replace where isearch-mode is nil. Oh, right. Is there some other state it can test for? As you said, it can only be expected to be used (i.e., to work) when within an appropriate context (e.g. following xyz). > > Feel free to close this bug, if you like. It's not > > clear to me whether any code change is needed. >=20 > I thought that your request was for using > isearch-lazy-highlight-window as an argument > of window functions in isearch-lazy-highlight-update. > If you need this, then please create a new request, > and I'm closing this one. That's fine. Thx.