From: Mauro Aranda <maurooaranda@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>, 65821@debbugs.gnu.org
Subject: bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type
Date: Fri, 8 Sep 2023 12:47:08 -0300 [thread overview]
Message-ID: <0b4e77df-e253-0568-9110-e0409bae36ca@gmail.com> (raw)
In-Reply-To: <CADwFkmnOXhDaiM8sM5vknbt-veErJ3xOmA+ao_9W1zyrt9gO_w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On 8/9/23 08:36, Stefan Kangas wrote:
> Mauro Aranda <maurooaranda@gmail.com> writes:
>
>> The option ielm-indirect-setup-hook is supposed to be a hook. However,
>> its type says it's a boolean.
>
> Thanks. Would you like to send a patch?
Sure. I also removed the :safe property, since it seems to me that it
was just a copy-paste from the other defcustom introduced in the same
commit.
[-- Attachment #2: 0001-Fix-defcustom-type-in-ielm.el.patch --]
[-- Type: text/x-patch, Size: 852 bytes --]
From 4b5b1c3b0b765f6e43ba96427aff03fff74acc64 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Fri, 8 Sep 2023 12:44:42 -0300
Subject: [PATCH] ; Fix defcustom type in ielm.el
* lisp/ielm.el (ielm-indirect-setup-hook): Fix :type and remove :safe
property, since it was probably a copy-pasta. (Bug#65821)
---
lisp/ielm.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/ielm.el b/lisp/ielm.el
index f7d025b8c01..e51c46054b4 100644
--- a/lisp/ielm.el
+++ b/lisp/ielm.el
@@ -491,8 +491,7 @@ ielm-indirect-setup-hook
indirect buffer as the current buffer after its setup is done.
This can be used to further customize fontification and other
behavior of the indirect buffer."
- :type 'boolean
- :safe 'booleanp
+ :type 'hook
:version "29.1")
(defun ielm-indirect-setup-hook ()
--
2.34.1
next prev parent reply other threads:[~2023-09-08 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 11:31 bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type Mauro Aranda
2023-09-08 11:36 ` Stefan Kangas
2023-09-08 15:47 ` Mauro Aranda [this message]
2023-09-08 16:44 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4e77df-e253-0568-9110-e0409bae36ca@gmail.com \
--to=maurooaranda@gmail.com \
--cc=65821@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.