From 706da4638a802660c9332a3bdaa980522ab7be44 Mon Sep 17 00:00:00 2001 From: Jim Porter Date: Thu, 14 Dec 2023 11:31:27 -0800 Subject: [PATCH] Abbreviate the VC revision in vc-annotate's buffer name * lisp/vc/vc-hooks.el (vc-use-short-revision): New variable. (vc-short-revision): New function. * lisp/vc/vc-annotate.el (vc-annotate-use-short-revision): New option... (vc-annotate): ... use it. * lisp/vc/vc-git.el (vc-git--rev-parse): Consult 'vc-use-short-revision'. * etc/NEWS: Announce this change (bug#67062). --- etc/NEWS | 6 ++++++ lisp/vc/vc-annotate.el | 10 +++++++++- lisp/vc/vc-git.el | 7 +++++-- lisp/vc/vc-hooks.el | 12 ++++++++++++ 4 files changed, 32 insertions(+), 3 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 6df17aa3f0a..7c21f04a0f7 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -492,6 +492,12 @@ switch is used, commands to see the diff of the old revision ('d'), check out an old file version ('f') or annotate it right away ('a'), also work on revisions which precede renames. +--- +*** 'vc-annotate' now abbreviates the Git revision in the buffer name. +When using the Git backend, 'vc-annotate' will use an abbreviated +revision identifier in its buffer name. To restore the previous +behavior, set 'vc-annotate-use-short-revision' to nil. + *** New option 'vc-git-file-name-changes-switches'. It allows tweaking the thresholds for rename and copy detection. diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el index de6c3adbbdb..cfca7cbfac0 100644 --- a/lisp/vc/vc-annotate.el +++ b/lisp/vc/vc-annotate.el @@ -162,6 +162,11 @@ vc-annotate-menu-elements :type '(repeat number) :group 'vc) +(defcustom vc-annotate-use-short-revision t + "If non-nil, \\[vc-annotate] will use short revisions in its buffer name." + :type 'boolean + :group 'vc) + (defvar-keymap vc-annotate-mode-map :doc "Local keymap used for VC-Annotate mode." "a" #'vc-annotate-revision-previous-to-line @@ -397,7 +402,10 @@ vc-annotate (save-current-buffer (vc-ensure-vc-buffer) (list buffer-file-name - (let ((def (vc-working-revision buffer-file-name))) + (let ((def (funcall (if vc-annotate-use-short-revision + #'vc-short-revision + #'vc-working-revision) + buffer-file-name))) (if (null current-prefix-arg) def (vc-read-revision (format-prompt "Annotate from revision" def) diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 24469f04f7c..bd74e2a6a44 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1857,8 +1857,11 @@ vc-git-previous-revision (defun vc-git--rev-parse (rev) (with-temp-buffer (and - (vc-git--out-ok "rev-parse" rev) - (buffer-substring-no-properties (point-min) (+ (point-min) 40))))) + (apply #'vc-git--out-ok "rev-parse" + (append (when vc-use-short-revision '("--short")) + (list rev))) + (goto-char (point-min)) + (buffer-substring-no-properties (point) (pos-eol))))) (defun vc-git-next-revision (file rev) "Git-specific version of `vc-next-revision'." diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 8451128286b..e84cdffe2dd 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -506,6 +506,18 @@ vc-working-revision (vc-call-backend backend 'working-revision file)))))) +(defvar vc-use-short-revision nil + "If non-nil, VC backend functions should return short revisions if possible. +This is set to t when calling `vc-short-revision', which will +then call the \\=`working-revision' backend function.") + +(defun vc-short-revision (file &optional backend) + "Return the repository version for FILE in a shortened form. +If FILE is not registered, this function always returns nil." + (let ((vc-use-short-revision t)) + (vc-call-backend (or backend (vc-backend file)) + 'working-revision file))) + (defun vc-default-registered (backend file) "Check if FILE is registered in BACKEND using vc-BACKEND-master-templates." (let ((sym (vc-make-backend-sym backend 'master-templates))) -- 2.25.1