From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Sat, 20 Jul 2019 23:32:03 -0700 Organization: UCLA Computer Science Department Message-ID: <0a45d364-73ee-4ef3-62de-4d8d42578036@cs.ucla.edu> References: <6a260307-a463-bd08-8a10-d7664d0606a2@cs.ucla.edu> <74235afc-7043-1da7-7c71-07f0ca23b9fd@cs.ucla.edu> <83r26mv53z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="130843"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: 36597@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 21 08:33:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hp5P9-000Xl5-Es for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 08:33:07 +0200 Original-Received: from localhost ([::1]:54806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hp5P8-0004iT-95 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 02:33:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59207) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hp5P5-0004iB-CA for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 02:33:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hp5P4-0001KE-Cr for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 02:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49267) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hp5P4-0001K7-9a for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 02:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hp5P4-0004HG-2p for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 02:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2019 06:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs Original-Received: via spool by 36597-submit@debbugs.gnu.org id=B36597.156369073316390 (code B ref 36597); Sun, 21 Jul 2019 06:33:02 +0000 Original-Received: (at 36597) by debbugs.gnu.org; 21 Jul 2019 06:32:13 +0000 Original-Received: from localhost ([127.0.0.1]:58088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hp5OG-0004GI-Pz for submit@debbugs.gnu.org; Sun, 21 Jul 2019 02:32:13 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hp5OE-0004G4-1q for 36597@debbugs.gnu.org; Sun, 21 Jul 2019 02:32:12 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 639581626E0; Sat, 20 Jul 2019 23:32:04 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id U1_B8jNdZoz9; Sat, 20 Jul 2019 23:32:03 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A8E661626ED; Sat, 20 Jul 2019 23:32:03 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vKBckyYwpY6P; Sat, 20 Jul 2019 23:32:03 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 818201626E0; Sat, 20 Jul 2019 23:32:03 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163504 Archived-At: Pip Cet wrote: > I don't see anything in there that > would drastically affect performance or memory footprint. The drastic change to the memory footprint occurs because the old code incorrectly computed the length of the hash table's vectors, and over-allocated them in some cases. The over-allocation factor could get worse with each hash table resize, following a Fibonacci-like sequence. I think this was a bug I introduced in 2011-07-21T17:41:20!eggert@cs.ucla.edu.