Re: lisp/term/ns-win.el modification

[Jean-Christophe Helary <jean.christophe.helary@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]


> On May 1, 2017, at 17:59, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
>> Date: Mon, 1 May 2017 17:23:19 +0900
>> 
>> The function only understand paths that start from / or from ~, so the path can't start with ws. As for paths ending with ws, that's a very marginal case. Currently, in a triple-click all the ws ending the string is selected and the function will thus fail to open the selected path. It should be possible to test incrementally whether the trimmed path points to a file, or if the path ending with the first ws does, etc until the end of the trailing ws list, but that's not practical.
> 
> OK, thanks.
> 
> Then I'd suggest to use split-string, which can trim any regexp
> specified by its 4th argument.  That way, you can include NBSP in the
> characters to trim.  I don't think we should include any additional
> characters that have the Zs Unicode category need to be trimmed, as I
> believe they are unlikely to be encountered in this scenario.  Perhaps
> a comment to that effect is in order.

Ok, I have something that works here. I'm attaching a diff. Let me know if that is satisfactory.

Jean-Christophe 


[-- Attachment #2: ns-win.el.diff --]
[-- Type: application/octet-stream, Size: 1280 bytes --]

diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
index 70bd817d93..d0a95dd701 100644
--- a/lisp/term/ns-win.el
+++ b/lisp/term/ns-win.el
@@ -229,6 +229,19 @@ The properties returned may include `top', `left', `height', and `width'."
 
 (declare-function dnd-open-file "dnd" (uri action))
 
+;; Handles multi line strings that are passed to the "open-file" service.
+(defun ns-open-file-service (filepaths)
+  "Opens multiple files at once when a multiline string is selected."
+  (let ((path_list (split-string filepaths "[\n\r]+")))
+    (dolist (path_string path_list)
+      (if (not (equal "" path_string))
+	  (dnd-open-file
+           ;; The path string is timmed for spaces, nbsp and tabs.
+           (car (split-string path_string nil nil  "[ \u00A0\t]+")) nil)))))
+
+
+
+
 (defun ns-spi-service-call ()
   "Respond to a service request."
   (interactive)
@@ -236,7 +249,7 @@ The properties returned may include `top', `left', `height', and `width'."
 	 (switch-to-buffer (generate-new-buffer "*untitled*"))
 	 (insert ns-input-spi-arg))
 	((string-equal ns-input-spi-name "open-file")
-	 (dnd-open-file ns-input-spi-arg nil))
+	 (ns-open-file-service ns-input-spi-arg))
 	((string-equal ns-input-spi-name "mail-selection")
 	 (compose-mail)
 	 (rfc822-goto-eoh)