From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: bug#3600: 23.0.94; shrink-window-if-larger-than-buffer
Date: Wed, 17 Jun 2009 12:44:07 -0700 [thread overview]
Message-ID: <0F4C735B7FF74432818F7CFAB4C85394@us.oracle.com> (raw)
Dunno if there is a bug here, beyond possibly improving the doc
string. In general, I have a question about the code.
The code imposes this as one of the conditions for fitting the window
to the buffer:
(or (not (frame-parameter frame 'minibuffer))
(let ((mini-window (minibuffer-window frame)))
(or (null mini-window)
(not (eq frame (window-frame mini-window)))
(< (nth 3 edges) (nth 1 (window-edges mini-window)))
(> (nth 1 edges) (frame-parameter frame 'menu-bar-lines)))))
I don't understand the last condition (>). At the least, this
condition seems to be missing from the doc string:
"Do nothing if the buffer contains more lines than the present window
height, or if some of the window's contents are scrolled out of view,
or if shrinking this window would also shrink another window, or if
the window is the only window of its frame."
What is that last condition (>) for? What is the relation between the
number of menu-bar-lines and the `Top' position of the window?
And doesn't this code raise an error if the `menu-bar-lines' parameter
is nil? Should it really be doing that?
In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600)
of 2009-05-24 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
next reply other threads:[~2009-06-17 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 19:44 Drew Adams [this message]
2009-06-18 10:07 ` bug#3600: 23.0.94; shrink-window-if-larger-than-buffer martin rudalics
2009-06-18 17:23 ` Drew Adams
2009-06-19 8:51 ` martin rudalics
2009-06-19 21:23 ` Drew Adams
2009-06-20 8:08 ` martin rudalics
2011-09-17 6:08 ` Lars Magne Ingebrigtsen
2011-09-17 14:06 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0F4C735B7FF74432818F7CFAB4C85394@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=3600@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.