From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#4293: 23.1; use pop-to-buffer, not switch...other-window, in bookmark.el Date: Wed, 2 Sep 2009 07:39:10 -0700 Message-ID: <0EDDA64C33FD4884B064564DC880B5F3@us.oracle.com> References: <4A9E41E3.1000201@gmx.at> Reply-To: Drew Adams , 4293@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1251902841 9633 80.91.229.12 (2 Sep 2009 14:47:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Sep 2009 14:47:21 +0000 (UTC) To: "'martin rudalics'" , <4293@emacsbugs.donarmstrong.com> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 02 16:47:13 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mir79-0003nA-OH for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Sep 2009 16:47:12 +0200 Original-Received: from localhost ([127.0.0.1]:34637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mir78-0007jb-Q2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Sep 2009 10:47:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mir72-0007jB-Mo for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 10:47:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mir6y-0007iU-Pb for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 10:47:04 -0400 Original-Received: from [199.232.76.173] (port=57046 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mir6y-0007iR-MI for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 10:47:00 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42229) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mir6x-0006eY-PM for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2009 10:47:00 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n82EkvP4004553; Wed, 2 Sep 2009 07:46:57 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n82Ej4kj004142; Wed, 2 Sep 2009 07:45:04 -0700 Resent-Date: Wed, 2 Sep 2009 07:45:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 02 Sep 2009 14:45:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4293 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4293-submit@emacsbugs.donarmstrong.com id=B4293.12519023403153 (code B ref 4293); Wed, 02 Sep 2009 14:45:03 +0000 Original-Received: (at 4293) by emacsbugs.donarmstrong.com; 2 Sep 2009 14:39:00 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n82Ecxt8003150 for <4293@emacsbugs.donarmstrong.com>; Wed, 2 Sep 2009 07:39:00 -0700 Original-Received: from rgminet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n82EdMmD016857 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Sep 2009 14:39:23 GMT Original-Received: from abhmt004.oracle.com (abhmt004.oracle.com [141.146.116.13]) by rgminet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n82Ed8Q5013462; Wed, 2 Sep 2009 14:39:08 GMT Original-Received: from dradamslap1 (/141.144.80.100) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 02 Sep 2009 07:38:49 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4A9E41E3.1000201@gmx.at> Thread-Index: AcortCIeO90zzWn/SA6mXmz2MXYwLgAJncVA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4A9E837A.011C:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 02 Sep 2009 10:47:04 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30735 Archived-At: > > In bookmark-jump-other-window and bookmark-bmenu-other-window we call > > switch-to-buffer-other-window. We should use pop-to-buffer, instead. > > > > With non-nil pop-up-frames, switch-to-buffer-other-window creates a > > new frame each time, even if the destination buffer is > > already showing in some frame. pop-to-buffer DTRT: it reuses > > the existing frame. > > I'm not sure what the problem is here. > `switch-to-buffer-other-window' > has a clear purpose - do _not reuse the selected window_ (which is the > bookmarks window, IIUC). OTOH `display-buffer-reuse-frames' non-nil > should assure that another frame is reused. Users should not have to customize a global variable, to prevent a new frame from being used in particular places like this. As Stefan says repeatedly (paraphrasing), switch-to-buffer-other-window is almost always the wrong thing to do, and should be replaced in most places by pop-to-buffer. Use of switch-to-buffer-other-window is a bug in general, typically made by someone who doesn't use non-nil pop-up-frames. In this particular context, there is no reason to use switch-to-buffer-other-frame.