From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#65030: 30.0.50; Check keyword args of make-process Date: Tue, 8 Aug 2023 11:16:07 +0200 Message-ID: <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@acm.org> References: <83a5v5u9nf.fsf@gnu.org> <83o7jkrcme.fsf@gnu.org> <87sf8tapbf.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2696"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 65030@debbugs.gnu.org, eller.helmut@gmail.com, Stefan Monnier To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 11:17:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTIqS-0000Tm-0G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 11:17:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTIq7-0004zt-4l; Tue, 08 Aug 2023 05:17:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTIq1-0004zG-Pr for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 05:17:15 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTIpr-0004WT-DB for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 05:17:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTIpp-0004hh-Sa for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 05:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 09:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65030 X-GNU-PR-Package: emacs Original-Received: via spool by 65030-submit@debbugs.gnu.org id=B65030.169148617818023 (code B ref 65030); Tue, 08 Aug 2023 09:17:01 +0000 Original-Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 09:16:18 +0000 Original-Received: from localhost ([127.0.0.1]:35163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTIp7-0004gd-VT for submit@debbugs.gnu.org; Tue, 08 Aug 2023 05:16:18 -0400 Original-Received: from mail236c50.megamailservers.eu ([91.136.10.246]:58574 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTIp3-0004gQ-8A for 65030@debbugs.gnu.org; Tue, 08 Aug 2023 05:16:17 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1691486171; bh=Sh9mwBDtdGca/xVLhDuGiZ2HtgmNYDB9ut/hmz/rJj0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ajKFFWpLKWajFOEGAGYG7NmWB1PUfCnNSYNXsmfc6EE1ovJ6Ic8O0CfX6eCVQoyCh e2zeTuV813kM7smJ0U+16rdcbgyaNhoSeRg59ZZl8Ugct5ywzivuqMY3Cr8KSlAkQH Hp64AGSMub4nJJlhnxWiObg0ki3R8fp1ATBCtCCM= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 3789G8HM049786; Tue, 8 Aug 2023 09:16:09 +0000 In-Reply-To: <87sf8tapbf.fsf@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrledvgddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffuvffqrffktedpqfgfvfdpgffpggdqveehtdenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpedvhfeiveekgfevledugfeuffeiudejtddtleehteetffdugeekveehgffhfefhtdenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopeehpdhrtghpthhtoheprhhplhhuihhmsehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhonh hnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrpdhrtghpthhtohepvghllhgvrhdrhhgvlhhmuhhtsehgmhgrihhlrdgt X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266924 Archived-At: 8 aug. 2023 kl. 10.52 skrev Robert Pluim : > I don=CA=BCt think any of the `make-process' keywords accept keywords = as > values, but missing values tends to cause catastrophic failure, so I > don=CA=BCt think it=CA=BCs that common a mistake. No, the usefulness of good compiler warnings goes far beyond that. A = determined programmer may eventually get something working despite an = error-prone API, but decent diagnostics will speed up the process = manifold by pointing out mistakes before the code is even run. (With = flymake/flycheck, even faster.) > Mattias> The main objection is that `make-process`, due to its = design, is often > Mattias> called indirectly using `apply` which would not trigger = the > Mattias> application of this compiler macro, so perhaps we should = improve the > Mattias> error handling of Fmake_process instead. >=20 > As long as that improvement results in warnings for mistakes such as > misspelled keywords, rather than errors. Of course not. Incorrect arguments detected at run-time should elicit = errors, as they do now. The point being that for something as complex as make-process they = should be more helpful than just `wrong-type-argument`.