all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* 23 branch NS build failure - XVECTOR->size / nsmenu
@ 2011-06-15 15:27 David Reitter
  2011-06-15 16:36 ` Glenn Morris
  2011-06-15 16:54 ` Alp Aker
  0 siblings, 2 replies; 7+ messages in thread
From: David Reitter @ 2011-06-15 15:27 UTC (permalink / raw)
  To: Emacs devel

The use of XVECTOR()->size needs to be changed (e.g., to ASIZE()) in nsmenu's ns_update_menubar to make the 23 branch compile again (with NS).

This change from the trunk would be the right one to merge:

revno: 104024 [merge]
committer: Paul Eggert <eggert@cs.ucla.edu>
branch nick: trunk
timestamp: Tue 2011-04-26 23:03:54 -0700
message:
  Merge: nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.


Is this something I can do myself (and if so, how - i.e., what's the correct way to cherry-pick in Bzr?), or should I wait for a maintainer to do it?


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: 23 branch NS build failure - XVECTOR->size / nsmenu
  2011-06-15 15:27 23 branch NS build failure - XVECTOR->size / nsmenu David Reitter
@ 2011-06-15 16:36 ` Glenn Morris
  2011-06-15 19:29   ` Alp Aker
  2011-06-15 16:54 ` Alp Aker
  1 sibling, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2011-06-15 16:36 UTC (permalink / raw)
  To: David Reitter; +Cc: Emacs devel

David Reitter wrote:

> Is this something I can do myself (and if so, how - i.e., what's the
> correct way to cherry-pick in Bzr?), or should I wait for a maintainer
> to do it?

Somebody already reported this and provided a patch:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8839

Personally I don't see any point in applying it until/unless it's
confirmed there will be another release from emacs-23 (currently, there
is not expected to be one,
http://lists.gnu.org/archive/html/emacs-devel/2011-06/msg00289.html )



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: 23 branch NS build failure - XVECTOR->size / nsmenu
  2011-06-15 15:27 23 branch NS build failure - XVECTOR->size / nsmenu David Reitter
  2011-06-15 16:36 ` Glenn Morris
@ 2011-06-15 16:54 ` Alp Aker
  1 sibling, 0 replies; 7+ messages in thread
From: Alp Aker @ 2011-06-15 16:54 UTC (permalink / raw)
  To: emacs-devel

> The use of XVECTOR()->size needs to be changed (e.g., to ASIZE()) in 
> nsmenu's  ns_update_menubar to make  the 23 branch compile again 
> (with NS).

I reported this as well in:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8839

and supplied a patch.  It might be easier to apply that directly rather than 
trying to cherry pick from the trunk.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: 23 branch NS build failure - XVECTOR->size / nsmenu
  2011-06-15 16:36 ` Glenn Morris
@ 2011-06-15 19:29   ` Alp Aker
  2011-06-15 21:19     ` Glenn Morris
  2011-06-16 16:31     ` bug#8839: " David Reitter
  0 siblings, 2 replies; 7+ messages in thread
From: Alp Aker @ 2011-06-15 19:29 UTC (permalink / raw)
  To: emacs-devel

> Personally I don't see any point in applying it until/unless it's
> confirmed there will be another release from emacs-23.

But wouldn't it be unfortunate to leave emacs-23 in a state in 
which it won't even compile on NS?








^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: 23 branch NS build failure - XVECTOR->size / nsmenu
  2011-06-15 19:29   ` Alp Aker
@ 2011-06-15 21:19     ` Glenn Morris
  2011-06-16 16:31     ` bug#8839: " David Reitter
  1 sibling, 0 replies; 7+ messages in thread
From: Glenn Morris @ 2011-06-15 21:19 UTC (permalink / raw)
  To: Alp Aker; +Cc: emacs-devel

Alp Aker wrote:

> But wouldn't it be unfortunate to leave emacs-23 in a state in 
> which it won't even compile on NS?

It doesn't bother me, any more than the fact that it doesn't compile on
some GNU/Linux distributions:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8497

I'd rather spend effort on getting 24.1 in shape. If somebody else wants
to backport these fixes, that's fine by me, but I'm not going to bother.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#8839: 23 branch NS build failure - XVECTOR->size / nsmenu
  2011-06-15 19:29   ` Alp Aker
  2011-06-15 21:19     ` Glenn Morris
@ 2011-06-16 16:31     ` David Reitter
  2011-06-16 17:16       ` Alp Aker
  1 sibling, 1 reply; 7+ messages in thread
From: David Reitter @ 2011-06-16 16:31 UTC (permalink / raw)
  To: Alp Aker; +Cc: Emacs devel

On Jun 15, 2011, at 3:29 PM, Alp Aker wrote:
> 
> But wouldn't it be unfortunate to leave emacs-23 in a state in 
> which it won't even compile on NS?

I agree.  I have made the change (rev 100598).  Please try it out.






^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: 23 branch NS build failure - XVECTOR->size / nsmenu
  2011-06-16 16:31     ` bug#8839: " David Reitter
@ 2011-06-16 17:16       ` Alp Aker
  0 siblings, 0 replies; 7+ messages in thread
From: Alp Aker @ 2011-06-16 17:16 UTC (permalink / raw)
  To: David Reitter; +Cc: Emacs devel

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

On Thu, Jun 16, 2011 at 12:31 PM, David Reitter wrote:

> I agree.  I have made the change (rev 100598).  Please try it out.

Builds fine.  Thanks for installing the fix.

[-- Attachment #2: Type: text/html, Size: 216 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-06-16 17:16 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-15 15:27 23 branch NS build failure - XVECTOR->size / nsmenu David Reitter
2011-06-15 16:36 ` Glenn Morris
2011-06-15 19:29   ` Alp Aker
2011-06-15 21:19     ` Glenn Morris
2011-06-16 16:31     ` bug#8839: " David Reitter
2011-06-16 17:16       ` Alp Aker
2011-06-15 16:54 ` Alp Aker

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.