all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Martin Jerabek <om@mailservice.ms>
Cc: 58718-done@debbugs.gnu.org
Subject: bug#58718: Incorrect regex in nXML URI check
Date: Mon, 24 Oct 2022 12:51:30 +0200	[thread overview]
Message-ID: <0E0045FD-164C-4626-A81B-EF400FD04AD5@gmail.com> (raw)
In-Reply-To: <938384610b8c5411944afa7fae860f15e2e40eae.camel@fastmail.fm>

I concur with the assessment. Your fixes are straightforward and have now been pushed to master.

I also did a quick scan for similar errors (missing backslashes before curly brackets) but found no obvious cases of the same bug in the Emacs tree. A check could be added to the regexp linter but it's hard to guard against false positives.

Thanks for the report and patch. This code hasn't seen much changes since it was added to Emacs, so if you find something else to improve you are more than welcome to contribute to further development.






  parent reply	other threads:[~2022-10-24 10:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22 12:58 bug#58718: Incorrect regex in nXML URI check Martin Jerabek
     [not found] ` <handler.58718.B.16664517395858.ack@debbugs.gnu.org>
2022-10-23 10:46   ` bug#58718: Acknowledgement (Incorrect regex in nXML URI check) Martin Jerabek
2022-10-24 10:51 ` Mattias Engdegård [this message]
2022-10-24 12:26   ` bug#58718: Incorrect regex in nXML URI check Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0E0045FD-164C-4626-A81B-EF400FD04AD5@gmail.com \
    --to=mattias.engdegard@gmail.com \
    --cc=58718-done@debbugs.gnu.org \
    --cc=om@mailservice.ms \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.