From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59490: 29.0.50; Add C# support Date: Wed, 23 Nov 2022 22:25:12 +0100 Message-ID: <0D2B024A-7486-46A4-999C-453494A251D6@thornhill.no> References: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18547"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59490@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 22:26:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxxGC-0004XV-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 22:26:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxxFu-0008Df-4p; Wed, 23 Nov 2022 16:26:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxxFr-0008DA-EI for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 16:26:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxxFq-0001nm-Is for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 16:26:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxxFq-0000Bd-6j for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 16:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59490 X-GNU-PR-Package: emacs Original-Received: via spool by 59490-submit@debbugs.gnu.org id=B59490.1669238723657 (code B ref 59490); Wed, 23 Nov 2022 21:26:02 +0000 Original-Received: (at 59490) by debbugs.gnu.org; 23 Nov 2022 21:25:23 +0000 Original-Received: from localhost ([127.0.0.1]:56432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxxFD-0000AX-6b for submit@debbugs.gnu.org; Wed, 23 Nov 2022 16:25:23 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]:17350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxxFB-0000AM-3f for 59490@debbugs.gnu.org; Wed, 23 Nov 2022 16:25:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669238719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXYN1aAAZstog7cCrZC1Ttf6fr2nS2apfor9RWfO9go=; b=H9zNtPJ8dtqpLPsco89CBGwESynAFb4oaJs5UXO2YqSfXH2n2sDzSUr5X/nWuq/Nag3Mj5 jDf+vFVH6wb9S10K3skiHyoEfyih81tQ2YzxDcPQ1qnHqbo5lBNTfkwT3f+uEz/7rSjyus AHGq0RS0ioMzGPaYIJgIk6kVtjF2RqFYZ7C9wRhPBRpy/pvQx9KcyOkKyduKyQ7/O6ADlh PQrNwHzW9OyO+iRSIVuRfPZPrqLq42qDLTFu8ELL63NHV/zk8gdbOyPL4ibLgeavOnkEC/ 7xO1FYfD0S/gsceBPfPSZjsC46oE6yqQoBn6CBuCqli52Ny48u0pgYILu32sfg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248789 Archived-At: On 23 November 2022 22:19:21 CET, Yuan Fu wrote: > > >> On Nov 23, 2022, at 12:43 PM, Theodor Thornhill w= rote: >>=20 >>=20 >>=20 >> On 23 November 2022 21:38:19 CET, Yuan Fu wrote: >>>=20 >>> Yuan Fu writes: >>>=20 >>>> Eli Zaretskii writes: >>>>=20 >>>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100 >>>>>> From: Theodor Thornhill via "Bug reports for GNU Emacs, >>>>>> the Swiss army knife of text editors" >>>>>>=20 >>>>>> Ok so this works=2E >>>>>>=20 >>>>>> Sorry for the mess=2E >>>>>>=20 >>>>>> What do you think? >>>>>=20 >>>>> LGTM, thanks=2E I'll let Yuan review and install=2E >>>>=20 >>>> Thanks Theo! I=E2=80=99ve merged it=2E One general comment is that we= should have >>>> a "standard" list of features consistent across major modes=2E I thin= k by >>>> now we=E2=80=99ve worked on font-lock enough to know what those featu= res should >>>> be=2E I=E2=80=99ll start a discussion on the ML=2E >>>=20 >>> Actually, another thing: it seems the mode defined is still named >>> csharp-mode rather than csharp-cc-mode=2E >>>=20 >>> Yuan >>=20 >> Yeah that's right=2E Imo that's ok, because it's unlikely there will be= much new development on the cc mode variant=2E So it will be identical to = the upstream one, and the upstream one will be marked as deprecated very so= on=2E >>=20 >> What do you think? > >Yeah I was just confused because you said > >> I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'=2E The cc-m= ode >> variant has that name as to not conflict with the ELPA package=2E Yep, that was unclear=2E I decided to skip it in the second patch :) > >And I only see csharp-mode=2E > >So the mode we provide in Emacs are csharp-mode and csharp-ts-mode? Then = I assume this line is a typo? > >;;;###autoload >(add-to-list 'auto-mode-alist '("\\=2Ecs\\'" =2E csharp-cc-mode)) > >Yuan > That's correct=2E That's a typo=2E My bad :) make it csharp-mode=2E You wa= nt a new patch?