From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code Date: Tue, 24 Apr 2012 10:37:09 -0700 Message-ID: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1335289106 29465 80.91.229.3 (24 Apr 2012 17:38:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 24 Apr 2012 17:38:26 +0000 (UTC) To: 11328@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 24 19:38:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SMjh2-0002Dj-Mh for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 19:38:24 +0200 Original-Received: from localhost ([::1]:40730 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjh2-0007lO-3H for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 13:38:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjgu-0007lG-Sd for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:38:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMjgt-0000gH-0X for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:38:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjgs-0000gB-Td for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:38:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SMjhe-0003BV-Ef for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Apr 2012 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.133528910212191 (code B ref -1); Tue, 24 Apr 2012 17:39:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Apr 2012 17:38:22 +0000 Original-Received: from localhost ([127.0.0.1]:51041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMjgz-0003AZ-NL for submit@debbugs.gnu.org; Tue, 24 Apr 2012 13:38:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34365) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMjgx-0003AM-8Q for submit@debbugs.gnu.org; Tue, 24 Apr 2012 13:38:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMjg4-0000d2-DA for submit@debbugs.gnu.org; Tue, 24 Apr 2012 13:37:25 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:60665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjg4-0000cy-A8 for submit@debbugs.gnu.org; Tue, 24 Apr 2012 13:37:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjg2-0007kL-HW for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:37:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMjg0-0000ce-Jr for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:37:21 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:23933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMjg0-0000ca-DY for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 13:37:20 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3OHbFJB010482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 17:37:16 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3OHbEXv023746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 24 Apr 2012 17:37:15 GMT Original-Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3OHbESr029333 for ; Tue, 24 Apr 2012 12:37:14 -0500 Original-Received: from dradamslap1 (/10.159.223.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Apr 2012 10:37:14 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0iQOAt/BRD/wxORmS0/5S+X00Adg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59457 Archived-At: Just a nit. But if you are going to add unnecessary comments to the code that describe only what everyone can see the code does, then at least get them right. Otherwise you mislead readers. This comment is incorrect: "Not a directory". What is actually true at that point is the following; a. RECURSIVE is nil b. RECURSIVE is non-nil and this is not a directory c. this is a directory, RECURSIVE is non-nil and not `always', and the user replied `n' (Similarly, the comment "This is a directory", though true, does not convey the real meaning. It is a directory AND it should be copied recursively.) It is a bad habit to add such comments to the code. Comments should generally be used when it is not obvious what the code does or why. In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-04-23 on MARVIN Bzr revision: 108006 agustin.martin@hispalinux.es-20120423103325-xmra3329elgzhmpc Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'