From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Ivan Shmakov <oneingray@gmail.com>
Cc: 16001-done@debbugs.gnu.org
Subject: bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings in some configurations
Date: Sat, 30 Nov 2013 14:32:30 +0100 [thread overview]
Message-ID: <0BB9EA99-8478-4026-ABFA-8828F793CA5B@swipnet.se> (raw)
In-Reply-To: <87zjondtun.fsf@violet.siamics.net>
Hello.
There are lot of new errors in window.c, xterm.c and xdisp.c after the pixelwise resize checkin, so this report is kind of obsolete. But I checked in fixes for the issues below.
Jan D.
29 nov 2013 kl. 18:02 skrev Ivan Shmakov <oneingray@gmail.com>:
> As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
> --without-x-toolkit, and GnuTLS 2, fails with:
>
> ../../src/xfaces.c:914:0: error: macro "NEAR_SAME_COLOR_THRESHOLD" is not used [-Werror=unused-macros]
> #define NEAR_SAME_COLOR_THRESHOLD 30000
> ^
> cc1: all warnings being treated as errors
>
> ../../src/gnutls.c:266:1: error: 'gnutls_audit_log_function' defined but not used [-Werror=unused-function]
> gnutls_audit_log_function (gnutls_session_t session, const char* string)
> ^
> cc1: all warnings being treated as errors
>
> The causes are:
>
> • the NEAR_SAME_COLOR_THRESHOLD macro’s definition is not
> properly guarded with #ifdef HAVE_WINDOW_SYSTEM;
>
> • both the declaration and the definition of
> gnutls_audit_log_function () are not properly guarded with
> #ifdef HAVE_GNUTLS3.
>
> Adding the respective guards fixes both of the GCC errors.
>
> The issue seem not to be fixed in e7203144, either.
>
> --
> FSF associate member #7257
>
>
next prev parent reply other threads:[~2013-11-30 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 17:02 bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings in some configurations Ivan Shmakov
2013-11-30 13:32 ` Jan Djärv [this message]
2013-11-30 16:26 ` martin rudalics
2013-11-30 18:15 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0BB9EA99-8478-4026-ABFA-8828F793CA5B@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=16001-done@debbugs.gnu.org \
--cc=oneingray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.