From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?7KGw7ISx67mI?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v5] Enable xwidgets on macOS Date: Wed, 31 Jul 2019 00:33:36 +0900 Message-ID: <0A9ED54B-E381-44AA-9512-40CC0481F097@icloud.com> References: <20190718192321.65684-1-pcr910303@icloud.com> <20190719041654.88561-1-pcr910303@icloud.com> <83pnm5t8ui.fsf@gnu.org> <20190729202649.GA89035@breton.holly.idiocy.org> Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142865"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 30 17:33:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsU8O-000b3w-MV for ged-emacs-devel@m.gmane.org; Tue, 30 Jul 2019 17:33:52 +0200 Original-Received: from localhost ([::1]:33988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsU8N-0007gE-IY for ged-emacs-devel@m.gmane.org; Tue, 30 Jul 2019 11:33:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45094) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsU8H-0007fm-Am for emacs-devel@gnu.org; Tue, 30 Jul 2019 11:33:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsU8G-0004W6-99 for emacs-devel@gnu.org; Tue, 30 Jul 2019 11:33:45 -0400 Original-Received: from mr85p00im-ztdg06021801.me.com ([17.58.23.195]:34245) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsU8G-0004VQ-0P for emacs-devel@gnu.org; Tue, 30 Jul 2019 11:33:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1564500821; bh=CBaOeY+rBpnO4W+gsHZ+p+8V1jmR94w5T6RaWmiUw+c=; h=Content-Type:Subject:From:Date:Message-Id:To; b=yCWUjf2rUK2ApOrSgZn6LpvhotCb3uw4ozsv6/zgzIRUFjiGy38UFCISPW0FbuQPt mMKOdz1ysKRf5nESRTHq/mRcfFAdujFGYmToKT0WcLRe5iIT6t8YYXVsdLure5+vQc SY33pQ6lvzDyazdUGOZwVn2T7jgQgSOLKiJXV3e88jhUm9jKv1vkiU6uaxP3TxdzHv /KBWILp0ruy8+SzU9VvoqVs5mCnvmqkE3V2bWr+retzKmZDYooTnTSmFMQejEm8iT7 h6chPXs7uLsZrnWRlYTB9qmDVn0xx7PlcorKODbBHzYSBK03rBgbbcYKewX+VWvM4O qX3DH35UyWapA== Original-Received: from [192.168.0.11] (unknown [1.230.108.64]) by mr85p00im-ztdg06021801.me.com (Postfix) with ESMTPSA id C3AA8180CE4; Tue, 30 Jul 2019 15:33:40 +0000 (UTC) In-Reply-To: <20190729202649.GA89035@breton.holly.idiocy.org> X-Mailer: Apple Mail (2.3445.9.1) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-30_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1907300160 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 17.58.23.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239036 Archived-At: > 2019. 7. 30. =EC=98=A4=EC=A0=84 5:26, Alan Third = =EC=9E=91=EC=84=B1: >=20 > On Fri, Jul 26, 2019 at 03:51:11AM +0900, =EC=A1=B0=EC=84=B1=EB=B9=88 = wrote: >> Hello, I have prepared three patches to apply on master. >> Can anyone review these? >=20 > This error message is extremely annoying: >=20 > You can=E2=80=99t share an xwidget (webkit2) among windows. [47 times] > mwheel-scroll: Beginning of buffer > You can=E2=80=99t share an xwidget (webkit2) among windows. [87 times] > completing-read-default: Command attempted to use minibuffer while in = minibuffer > You can=E2=80=99t share an xwidget (webkit2) among windows. [4 times] > Quit [4 times] > You can=E2=80=99t share an xwidget (webkit2) among windows. [121 = times] >=20 > It blocks the minibuffer so it=E2=80=99s impossible to see what = you=E2=80=99re typing > when you do M-x or C-x b and so on. Is it possible to limit it to only > when an actual xwidget buffer is selected? Wow, I found I just got used to that before I started to maintain the = patch and never even thought to fix that. I remember this was annoying = to hell to me too :-(. I'll try to find a solution. > Strange things also happen if you have the same xwidget buffer > displayed in two windows and then resize the one that doesn=E2=80=99t = display > the xwidget. It looks as though the wrong window is being used to > calculate the xwidget=E2=80=99s size. Hmm, maybe this is because the portion of xwidget in the window isn't = redrawn? I'm not sure how I should tackle the issue though. :-( > The big explanatory comment at the top of nsxwidget.m could do with > being rewritten. It=E2=80=99s got a few typos and I find hard to = understand. I > think I get the gist of it, but I=E2=80=99m not 100% sure. Ok, I'll try to clarify it. > Is this something we=E2=80=99re going to have to update over time? >=20 > self.customUserAgent =3D > @"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6)" > @" AppleWebKit/603.3.8 (KHTML, like Gecko)" > @" Version/11.0.1 Safari/603.3.8"; I removed this part. > Anyway, the code contains two calls to > evaluateJavaScript:completionHandler: which is a problem as we=E2=80=99r= e > banned from using ObjC blocks, and the completion handler is an ObjC > block. Unless GCC supports them now, which I doubt. Does that mean this patch can never get merged until gcc supports = blocks? > I don=E2=80=99t see any alternatives in the Apple documentation.