From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Date: Tue, 30 Jan 2024 22:44:49 -0800 Message-ID: <0A273FF0-D67F-40DC-B195-90575DE7D9B9@gmail.com> References: <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org> <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> <868r4b9qjs.fsf@gnu.org> <875xzfkxq7.fsf@yahoo.com> <86a5oq6luo.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9101"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , Po Lu , "Ergus via Emacs development discussions." , dev@rjt.dev To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 31 07:45:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rV4Lu-0002AO-W6 for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Jan 2024 07:45:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rV4LY-00042p-JY; Wed, 31 Jan 2024 01:45:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV4LS-0003zY-2h for emacs-devel@gnu.org; Wed, 31 Jan 2024 01:45:14 -0500 Original-Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rV4LI-0008Nf-BF; Wed, 31 Jan 2024 01:45:08 -0500 Original-Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2954b34ddd0so2574638a91.0; Tue, 30 Jan 2024 22:45:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706683501; x=1707288301; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wnQ0KJBwq/Y0ZLAubb45MVQ4cl4UG09nhXPyzEpluN4=; b=nLJgPwzthWjgDR/X70NetlIzbREzwFQjMKNZPmeWT/dchMSLjJtZ67Nmfk37K+r8XK W/2ierutTq8NT+H5lGI2tMOPr55h4/B9oFT5njncHaNaG8v4hh8MowF+1Q9lzcolS0Xe Ml6OXc5W5ohMAUtAf+rr8AAvg0vCbZaAxPyrIXLJ2EIC8YyUWOSZ1R6lBjFlH9s+lw3F hIkaMj+APElXf0es6pLCLVedu5w8iGm7gjnmU6Ky6CBBaWv5oxcIp3tKGP2+Ja6eI3Jb +PgMcdeT8sAiG8Egb6FG15vrrpdpbTaNzh6p/KsPht2lr4MNu0oGkdH2GHHuoOGJ+/3K fu6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706683501; x=1707288301; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wnQ0KJBwq/Y0ZLAubb45MVQ4cl4UG09nhXPyzEpluN4=; b=mj3dCeiPAdMC/ykW4Iwbaora6rljiuXO82aMeKW6lhRU9GgWjyosmVgiUUju/7jozx /sx59OoeRI1bht83TfJYLLpYwPQjGu3ngvY1e5/BFLOlF6q0EJtu1M4dJNj9B3LzBBc2 Hj0Qx3C3C64C7Jw9gFubEwgbeRbMo2OLyMlOeY2nW/NFISj+ZWlAQcqVWeXqxmxQJ/fj N9/E1V3E6vCmzJk4fCnBPCW/7MNU1zkAF03iNiGm37r/Ik4wmK2tsjoaMQKpQuCqWKc6 ZiAVYDCZ/RHLfHy4RHCoLowyJTy35QJTVjbRJKxbbE7HchkIcoHiGnix1wO3tpH29xkE pk2g== X-Gm-Message-State: AOJu0YwFu9wMsMEUxbd/th0+i2cDfKoIPPxuYCc06UZpU+UsiWbnpJwo RX/lzFVelmUII4EfLg/PYqHGlSE+2wXO0ryXOdEUIyWAxZjlI9dvLdWHh+bG X-Google-Smtp-Source: AGHT+IEZoqBtdLOizTIoWLjLEkvohBS/sVoBwtr/NqbB0xjXQSo/sWGH2MLkGAssR8RiLuE73XCT6A== X-Received: by 2002:a17:90a:cb97:b0:295:b0cd:9be6 with SMTP id a23-20020a17090acb9700b00295b0cd9be6mr867739pju.30.1706683500866; Tue, 30 Jan 2024 22:45:00 -0800 (PST) Original-Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id l6-20020a17090a49c600b0028c2b52d132sm600839pjm.13.2024.01.30.22.45.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jan 2024 22:45:00 -0800 (PST) In-Reply-To: <86a5oq6luo.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=casouri@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315659 Archived-At: Hey sorry, I didn=E2=80=99t see this thread. I did forget to include the = bug number, will make sure I do next time. > On Jan 27, 2024, at 9:57 PM, Eli Zaretskii wrote: >=20 >> From: Stefan Kangas >> Date: Sat, 27 Jan 2024 14:40:02 -0800 >> Cc: emacs-devel@gnu.org, dev@rjt.dev >>=20 >> Po Lu writes: >>=20 >>> Yes, please. Furthermore, if such bugfix cannot be described as >>> anything but a simplification (with a correspondingly large diff), = there >>> should be another approach safer for the release branch. >>=20 >> We must not get overly rigid about that. It takes extra work, and it >> will not always be clear that it's worth the effort. Often it is, = but >> sometimes it isn't. We tend to decide on a case-by-case basis. >>=20 >> Furthermore, please keep in mind that Yuan is both the principal = author >> and maintainer of our treesitter support. He's closer to the code = than >> anyone else, and is thus in the best position to make such judgement >> calls. I see no reason to second-guess him here, myself. >>=20 >> If there are any specific technical arguments for why this particular >> change must not be installed on emacs-29, then let's hear them. = Neither >> generalizations nor administrative arguments will cut it, I think. >=20 > My arguments for not objecting to this change on the release branch: >=20 > . the change only affects these two modes > . the modes are new in Emacs 29, so their fixes should preferably be > in Emacs 29 as well The fix comes together with the simplification, so you can=E2=80=99t = simply pick it out and only apply the fix. It=E2=80=99ll be a rather = wasteful use of time and more error-prone. All the code that the patch = removed are copy-paste boilerplate, and the code that replaces them = delegate most of the work to existing functions. So I don=E2=80=99t = think it=E2=80=99ll destabilize emacs-29. Yuan