From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#11139: 24.0.94; inappropriate `face' property for `apropos*' button types Date: Sat, 31 Mar 2012 10:27:00 -0700 Message-ID: <0A1B281D1742437983A7AE45AABFFDA7@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1333214891 30935 80.91.229.3 (31 Mar 2012 17:28:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 31 Mar 2012 17:28:11 +0000 (UTC) To: 11139@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 31 19:28:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SE25r-0000Ua-Gg for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Mar 2012 19:28:03 +0200 Original-Received: from localhost ([::1]:51211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE25q-0003xr-I0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Mar 2012 13:28:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE25n-0003xV-Ke for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 13:28:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SE25l-0002AV-Rl for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 13:27:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE25l-00029p-P0 for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 13:27:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SE25q-00018g-CP for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 13:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Mar 2012 17:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11139 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.13332148454330 (code B ref -1); Sat, 31 Mar 2012 17:28:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 31 Mar 2012 17:27:25 +0000 Original-Received: from localhost ([127.0.0.1]:33117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SE25F-00017n-7c for submit@debbugs.gnu.org; Sat, 31 Mar 2012 13:27:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41617) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SE25C-00017f-Uf for submit@debbugs.gnu.org; Sat, 31 Mar 2012 13:27:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SE255-000201-Mf for submit@debbugs.gnu.org; Sat, 31 Mar 2012 13:27:17 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:46749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE255-0001zv-Jj for submit@debbugs.gnu.org; Sat, 31 Mar 2012 13:27:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE253-0003pi-QX for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 13:27:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SE251-0001zN-Ss for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 13:27:13 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:20101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE251-0001yz-M0 for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 13:27:11 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q2VHR8Ka030430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 31 Mar 2012 17:27:09 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q2VHR7l9002871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 31 Mar 2012 17:27:08 GMT Original-Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q2VHR7Yr026469 for ; Sat, 31 Mar 2012 12:27:07 -0500 Original-Received: from dradamslap1 (/10.159.47.251) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 31 Mar 2012 10:27:07 -0700 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac0PY3syQEVb6TQ3S3avtNcksqM6Vg== X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-CT-RefId: str=0001.0A090206.4F773E6D.0024,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58390 Archived-At: Here's the thing: Users can customize faces. That seems to get forgotten sometimes. In the case of an Apropos buffer, Emacs defines multiple button types, and all but one of them use _hard-coded_ faces. And there are additional places where particular faces are hard-coded in `apropos.el'. This hard-coding is a no-no. Why? Because USERS CAN CUSTOMIZE FACES. A user might well customize some of the faces that you use here in a hard-coded way. Those customizations might make sense for typical uses of those faces (e.g. font-locking for code), but the result in this buffer might be awful. You, writing apropos.el, cannot foresee all of the possibilities. But you can foresee that users will want to customize the appearance of Apropos buffers. And they deserve to be able to do that easily. Please, please provide a way for users to customize the display of Apropos itself. Add apropos-specific deffaces or face-valued defcustoms for each of the faces that the Apropos display uses. Set their default values to whatever you like, including perhaps font-lock faces. But please stop hard-coding faces, depriving users of the ability to control the appearance (without resorting to redefining the Emacs source code). A face should almost never be hard-coded, fixing Emacs's appearance in concrete. Please think of the users and of Emacs's mission to be customizable by them. It is hard to believe that this kind of thing is still going on. This is 2012, not 1980. In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600) of 2012-03-19 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include'