From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Crashes in "C-h h" Date: Tue, 2 Jul 2019 19:38:00 -0700 Organization: UCLA Computer Science Department Message-ID: <09f72051-d740-9115-c6fd-c4344c749568@cs.ucla.edu> References: <83y31hes6r.fsf@gnu.org> <83r279epwe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182140"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 Cc: emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 03 04:38:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiVAQ-000lEn-00 for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2019 04:38:42 +0200 Original-Received: from localhost ([::1]:58832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiVAO-00070D-Hd for ged-emacs-devel@m.gmane.org; Tue, 02 Jul 2019 22:38:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57500) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiV9n-0006y8-Sl for emacs-devel@gnu.org; Tue, 02 Jul 2019 22:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiV9m-0000Df-Uo for emacs-devel@gnu.org; Tue, 02 Jul 2019 22:38:03 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57666) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiV9m-0000Cq-PS for emacs-devel@gnu.org; Tue, 02 Jul 2019 22:38:02 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 756E9161598; Tue, 2 Jul 2019 19:38:01 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SDHDmKfnA0Kl; Tue, 2 Jul 2019 19:38:00 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C51F01616A8; Tue, 2 Jul 2019 19:38:00 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jOE7Gu0Z3q52; Tue, 2 Jul 2019 19:38:00 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9AFEC161598; Tue, 2 Jul 2019 19:38:00 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238308 Archived-At: Pip Cet wrote: > Is there a problem simply testing FIXNUMP in this place? As Eli's revised code suggests, if n is in fixnum range, then instead of (FIXNUMP (x) && XFIXNUM (x) == n) it's typically a bit cleaner (and faster) to write EQ (x, make_fixnum (n)).