From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: master 09b5f00613: ; Fix calls to treesit functions Date: Mon, 19 Dec 2022 00:26:27 -0800 Message-ID: <09FE9BDC-BE35-4280-BA1E-5AF8D1E3ECF2@gmail.com> References: <167138365421.15060.2886694741391315956@vcs2.savannah.gnu.org> <20221218171414.77B8EC0060F@vcs2.savannah.gnu.org> <47D9ABEB-EA9C-49DA-BC35-189A563DEC10@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="344"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel , Eli Zaretskii To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 09:27:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7BUe-000AUC-97 for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 09:27:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7BTq-0005RO-3I; Mon, 19 Dec 2022 03:26:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7BTn-0005QR-Cl for emacs-devel@gnu.org; Mon, 19 Dec 2022 03:26:36 -0500 Original-Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7BTl-0004Pw-RK; Mon, 19 Dec 2022 03:26:35 -0500 Original-Received: by mail-pf1-x42d.google.com with SMTP id 124so5732649pfy.0; Mon, 19 Dec 2022 00:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mKJo+tem3FRi8lcGfz8kkUmI6Kaali3QkJDOP3pmFjA=; b=YN/OPHhLsvsm1Hzspt2rFKiJAJO317gVr1jwx/uA0ZQGnizFvI2rLxp3BYgYt7Tmaz QS0+E183hOGCYTDsWEsGeE3WDK4NV3pGagOufh6HinRt53yeXISa6VkxVHWIMV+YB5br XiDuVNaLYLVgJ4fpY55OHZPyYs0O/oxB5iMkxRUczmnj8EV3N0VkPoWen3G9Ro0ldr2m RSVoiV4ZuZKTL/rJDSsajTX1G84hsREoY0WWl1UElQugRXfkdJVsx6hFDDmeBqEMs79Q pRgDpPN5nJ3hEfBk4ZLAzKtwZagFGw3hlXTevGzFTJs4w0DmPzbWVxVpKu5TWWsdiMVb 1VMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mKJo+tem3FRi8lcGfz8kkUmI6Kaali3QkJDOP3pmFjA=; b=HghZEwzudSLlirqVys24VCWOyZDfBsqPADJeh7+G1G1awt7+TzUZz2ly7TLfOnonIS eEs0xHPNcchpehqXDtUuEKoU7hDpGeAwPwLQf4mrqStzoet/Iy5mAzSqRFSDEh/r3ELv yNRlxySs55zU7L73kO5DKN3QDjxr1jxAsEg2AjLJ/F60R6EXoNo9Wy+YCjdDBu4Mvz9c nH9J+h3DBgfbRoIC1W/pxZO/vkJ7zBM04D9V4M6karBrrizJbt0TwvKQ+/35ZDD/HyA1 Y9a4hB1bTtyJOOPzTHNZFc8Ijxr/csrxH7z0s0OY7Nqs8GT1gDznfesnrb+cVND+d6Kv BI0A== X-Gm-Message-State: ANoB5pnn08gf7v1lMrwtBBxdv6gydIdZ3eoyZxJieayzRoPixu4lQyYr QexKbPX3AAlx7a+HIFtRuRw= X-Google-Smtp-Source: AA0mqf768oaWZYzDEcgW+oE6Hpbri39uw6zZb6HMomrlmipDi3nLCnzyrt3JFa2STFP53kP5QOinPg== X-Received: by 2002:a05:6a00:705:b0:566:900e:1023 with SMTP id 5-20020a056a00070500b00566900e1023mr38412630pfl.3.1671438391125; Mon, 19 Dec 2022 00:26:31 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id e4-20020a056a0000c400b005758d26fbf7sm6000547pfj.58.2022.12.19.00.26.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Dec 2022 00:26:30 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=casouri@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301632 Archived-At: > On Dec 18, 2022, at 3:54 PM, Stefan Monnier = wrote: >=20 >> That makes sense. Also, anyone using tree-sitter functions needs to >> declare functions in treesit.c in case Emacs didn=E2=80=99t build = with >> tree-sitter. Should we streamline it with a macro like this? >=20 > I wouldn't bother. >=20 >> (eval-when-compile >> (require 'treesit) >> (treesit-declare-c-functions)) >=20 > `declare-function` within a `eval-when-compile` (just like (defvar > )) is a bad idea. If it works, it's only by accident and can be > considered a bug (which could get fixed). >=20 Cool, glad I asked ;-) Yuan=