From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE Date: Sat, 29 Apr 2023 15:55:26 -0700 Message-ID: <09F6DE90-EA98-4758-A718-2BC4A12EA846@gmail.com> References: <82E7ADEC-25BC-475B-8EE0-839FE78FF2F4@gmail.com> <83fs8s2xnk.fsf@gnu.org> <2BDA88D0-A870-4FE3-BAF8-350FBAA943BF@gmail.com> <384f8110-eba6-8fb3-ef4e-56fa0721d85d@gutov.dev> <90E66143-A3E2-4B76-AC0A-01DC5E841AFE@gmail.com> <36F36D54-E56C-42C8-B686-448C8BF938EA@gmail.com> <83jzxxs6yn.fsf@gnu.org> <85A2194C-5C67-4AC2-A265-9C20F03FA5B6@gmail.com> <838recsgv2.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22688"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 62951@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 30 00:56:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pstUM-0005iw-Ld for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Apr 2023 00:56:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pstU5-0004JN-Cy; Sat, 29 Apr 2023 18:56:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pstU3-0004JC-I8 for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2023 18:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pstU3-0008MG-8j for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2023 18:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pstU2-0001KR-Ek for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2023 18:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Apr 2023 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62951 X-GNU-PR-Package: emacs Original-Received: via spool by 62951-submit@debbugs.gnu.org id=B62951.16828089495088 (code B ref 62951); Sat, 29 Apr 2023 22:56:02 +0000 Original-Received: (at 62951) by debbugs.gnu.org; 29 Apr 2023 22:55:49 +0000 Original-Received: from localhost ([127.0.0.1]:36814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pstTo-0001K0-Vg for submit@debbugs.gnu.org; Sat, 29 Apr 2023 18:55:49 -0400 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:51705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pstTk-0001Ji-5d for 62951@debbugs.gnu.org; Sat, 29 Apr 2023 18:55:46 -0400 Original-Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-24ded4b33d7so161805a91.3 for <62951@debbugs.gnu.org>; Sat, 29 Apr 2023 15:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682808938; x=1685400938; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ae8j+Pjr/S5r6BaOZYAp2tOsKcCvUZJKXlJRGmN2sFA=; b=QPLJ4bIT6Rg3ogbtyBfgbtoQkqMufWBHLp3FM0C9YMEJXnxlal9vMdi5LOOTkHy8iF XW6p+O/ZlAav9GNwUuR/rT/ZJdjcCv7+NwsFG4IBy7OcNKAN0s3hSm/dHzF+JaUXz/Ub qUGqAqFK/IIqtk/Q0wiUpAUbAbmoB6do2LigU5VXYeOCkoXsDJsyU1mgh1/z7dwLanZg NypyUVBkwtLTgu/HZjEcQ89aqhn3pTio51yzR3XJUU9tfgLU+hYtDv/z2RRAXeyCJBay jVaJvRXzhelO/82lTo/C3xINmAuIaow1z89VUH7ArxavR7npzj8brmWMbY72ECtUHolK VqxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682808938; x=1685400938; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ae8j+Pjr/S5r6BaOZYAp2tOsKcCvUZJKXlJRGmN2sFA=; b=WZOa18WcNCF9Jo2FH5Ev3aDLMk97TvhvKBIcFM50sCueXKDYWQDvAQ+OQ8VFukpaZz MfRYlR904GObiXg0H/Vnw6PXnLw5pWlhtpEqaeSJP874U0whheMNot1rDHtvg6WyHwcW BfG4dh86qd/H+V9FmJqm3NFhdYn2SZ92vEDsSufbNwQtERoHKHTMbN7Q6XKnpS7rxAze pIbAAvUMG1YnsbqGKbJ46lOKG0o2DE195dy8ZxzSPt8Yh1D1Bvi8ndrDiEw7+VqpLV4G v9Teq8Fv6NCiWvjuiuTlYxtP2SN73nIy2t0NrQnWNkj+yVBFRJ++Zw812u6bygd3m6Rm AATg== X-Gm-Message-State: AC+VfDwKATRc/u81I9D/vjcLvKW5dZ9YtMHOpFwoFPG45iJrNcRD5oxP pGLboyOA2r3oeo6dXfupwKk= X-Google-Smtp-Source: ACHHUZ64R8DZGbyXWWiK3LCcbEyoGKRbwzq9CYLbdSG9G37cbw0m3ASplhsoGV4BDpQv++pI3Ar/rw== X-Received: by 2002:a17:90a:4b05:b0:249:7224:41cb with SMTP id g5-20020a17090a4b0500b00249722441cbmr9860723pjh.31.1682808937885; Sat, 29 Apr 2023 15:55:37 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id bj19-20020a17090b089300b002465a7fc0cfsm16683806pjb.44.2023.04.29.15.55.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Apr 2023 15:55:37 -0700 (PDT) In-Reply-To: <838recsgv2.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.500.231) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260822 Archived-At: > On Apr 27, 2023, at 10:41 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 27 Apr 2023 12:56:07 -0700 >> Cc: dmitry@gutov.dev, >> 62951@debbugs.gnu.org >>=20 >>> c-ts-mode: Cannot load language definition: not-found, = ("libtree-sitter-emacs-c" "libtree-sitter-emacs-c.dll"), "No such file = or directory" >>>=20 >>> It looks like your "fake emacs-c language" trick somehow misfires? >>> The value of treesit-load-name-override-list is nil, which is not = what >>> you intended, AFAICT? The only way I can make this work is by >>> manually customizing treesit-load-name-override-list before loading >>> c-ts-mode. >>=20 >> Duh, sorry, dumb mistake. Fixed. >=20 > Thanks. >=20 >>> Otherwise, looks quite good; here are some other problems I found: >>>=20 >>> . some uses of FOR_EACH_TAIL are not fontified at all; examples: >>> comp.c, line 2079, fns.c, line 189 >>=20 >> You mean the FOE_EACH_TAIL part isn=E2=80=99t fontified, or the body = isn=E2=80=99t fontified? Because the body are always fontified here. = FOR_EACH_TAIL itself shouldn=E2=80=99t be fontified since it=E2=80=99s = just a macro call and a variable. >=20 > I mean the macro itself, FOR_EACH_TAIL. If it isn't supposed to be > fontified, then why is it fontified at line 856 of comp.c? It's > inconsistent. (However, this is a very minor problem, so if fixing > it is difficult, we can leave this alone for now.) Ah, I see. FOR_EACH_TAIL=E2=80=99s that has a bracketed body are not = skipped and still have fontification on them. I pushed a change so that = no one has fontification now. Also thanks for the doc fix :-) Yuan=