all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>
Cc: 43308@debbugs.gnu.org, Ihor Radchenko <yantar92@gmail.com>,
	stefankangas@gmail.com
Subject: bug#43308: 28.0.50; Improvements to Edit->Search menu
Date: Tue, 22 Sep 2020 09:59:08 -0700 (PDT)	[thread overview]
Message-ID: <090c6fc6-92b9-4604-bb14-e19287dd6685@default> (raw)
In-Reply-To: <87sgbadxr9.fsf@mail.linkov.net>

> >> Why no keybindings are shown for nonincremental menu items?
> >> They still have keybindings, e.g. nonincremental forward search
> >> can be started with 'C-s RET', nonincremental backward search
> >> with 'C-r RET', nonincremental regexp search 'C-M-s RET', etc.
> >
> > I suppose I could add some explicitly, with :keys.
> > That makes sense.  Unfortunately, none show up
> > automatically.  It would be good to somehow fix that.
> 
> How about the following patch?

It doesn't fix the nonautomatic display of keys, does it?

> BTW, why "Search Tagged Files..." and "Continue Tags Search" have
> no keybindings?

Because they have no keyboard key bindings.  Or was
that your question?  Did `tags-search' ever have a
default keyboard binding?  For `Continue Tags Search'
I think the reason was that when Emacs moved to xref
it dropped the `M-,' key binding for that command
(`tags-loop-continue').  (I wasn't in favor of that.)

> Another problem is that selecting "Continue Tags Search"
> signals the error:
> 
> emacs -Q
> Select "Edit" -> "Search" -> "Continue Tags Search"
> 
> Lisp error: (wrong-type-argument commandp fileloop-continue)

I don't see that with emacs -Q, loading menu-bar+.el,
and using that item in the Search menu (which is not
under Edit).  Dunno why.  I see just this error message:
"No operation in progress", which makes sense.

> I think "Continue Tags Search" should be disabled when it has no effect.

I've done that now, in menu-bar+.el.  I use this, but
perhaps someone can let me know if it's not the right,
or best, condition to use.  (I use condition-case, not
ignore-errors, for compatibility with older Emacs.)

:enable (not (condition-case nil
                 (tags-loop-eval tags-loop-scan)
               (error t)))





  parent reply	other threads:[~2020-09-22 16:59 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<87zh5xiuk4.fsf@localhost>
     [not found] ` <<831rj9k79b.fsf@gnu.org>
     [not found]   ` <<CADwFkmkvLnNySYVaEUhRzPMZVAfOU13NRp1GudxBmF1iuaxCxQ@mail.gmail.com>
     [not found]     ` <<83sgbpiqa7.fsf@gnu.org>
     [not found]       ` <<87mu1xa380.fsf@mail.linkov.net>
     [not found]         ` <<83imclii71.fsf@gnu.org>
     [not found]           ` <<87wo1178cn.fsf@mail.linkov.net>
     [not found]             ` <<83d02tifi3.fsf@gnu.org>
     [not found]               ` <<87ft7cx6kh.fsf@localhost>
     [not found]                 ` <<83bli027is.fsf@gnu.org>
2020-09-20 16:26                   ` bug#43308: 28.0.50; Improvements to Edit->Search menu Drew Adams
2020-09-21 19:05                     ` Juri Linkov
2020-09-21 19:29                       ` Andreas Schwab
2020-09-21 19:39                         ` Drew Adams
2020-09-21 19:30                       ` Drew Adams
2020-09-21 21:15                         ` Drew Adams
2020-09-22  8:04                         ` Juri Linkov
2020-09-22 14:19                           ` Eli Zaretskii
2020-09-22 18:10                             ` Juri Linkov
2020-09-22 18:37                               ` Eli Zaretskii
2020-09-22 16:59                           ` Drew Adams [this message]
2020-09-22 19:30                             ` bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error Juri Linkov
2020-09-22 20:44                               ` Drew Adams
2020-09-26  8:52                                 ` Eli Zaretskii
2020-09-21 19:44                       ` bug#43308: 28.0.50; Improvements to Edit->Search menu Eli Zaretskii
     [not found]                   ` <<498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default>
     [not found]                     ` <<87wo0nbln5.fsf@mail.linkov.net>
     [not found]                       ` <<6e21964e-a580-45ef-943f-a8ea97e58eef@default>
     [not found]                         ` <<87sgbadxr9.fsf@mail.linkov.net>
     [not found]                           ` <<090c6fc6-92b9-4604-bb14-e19287dd6685@default>
     [not found]                             ` <<87eemt7gob.fsf_-_@mail.linkov.net>
     [not found]                               ` <<f84e24f3-1f56-452a-b92c-1a3421e62d92@default>
     [not found]                                 ` <<83zh5crkbb.fsf@gnu.org>
2020-09-26 14:53                                   ` bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error Drew Adams
2020-09-26 15:15                                     ` Eli Zaretskii
     [not found] <<<<<<87zh5xiuk4.fsf@localhost>
     [not found] ` <<<<<<831rj9k79b.fsf@gnu.org>
     [not found]   ` <<<<<<CADwFkmkvLnNySYVaEUhRzPMZVAfOU13NRp1GudxBmF1iuaxCxQ@mail.gmail.com>
     [not found]     ` <<<<<<83sgbpiqa7.fsf@gnu.org>
     [not found]       ` <<<<<<87mu1xa380.fsf@mail.linkov.net>
     [not found]         ` <<<<<<83imclii71.fsf@gnu.org>
     [not found]           ` <<<<<<87wo1178cn.fsf@mail.linkov.net>
     [not found]             ` <<<<<<83d02tifi3.fsf@gnu.org>
     [not found]               ` <<<<<<87ft7cx6kh.fsf@localhost>
     [not found]                 ` <<<<<<83bli027is.fsf@gnu.org>
     [not found]                   ` <<<<<<498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default>
     [not found]                     ` <<<<<<87wo0nbln5.fsf@mail.linkov.net>
     [not found]                       ` <<<<<<6e21964e-a580-45ef-943f-a8ea97e58eef@default>
     [not found]                         ` <<<<<<87sgbadxr9.fsf@mail.linkov.net>
     [not found]                           ` <<<<<<090c6fc6-92b9-4604-bb14-e19287dd6685@default>
     [not found]                             ` <<<<<<87eemt7gob.fsf_-_@mail.linkov.net>
     [not found]                               ` <<<<<<f84e24f3-1f56-452a-b92c-1a3421e62d92@default>
     [not found]                                 ` <<<<<<83zh5crkbb.fsf@gnu.org>
     [not found]                                   ` <<<<<15cf58e4-afc0-4c41-b159-29565724ddb7@default>
     [not found]                                     ` <<<<<83eemor2lx.fsf@gnu.org>
     [not found]                                       ` <<<<8ceca0dd-a0d8-48bb-992b-41823f7702ac@default>
     [not found]                                         ` <<<<83blhsr1i7.fsf@gnu.org>
     [not found]                                           ` <<<<82143311-d8b3-4a96-a103-587e1fedf9dd@default>
     [not found]                                             ` <<<<83zh5cpk5q.fsf@gnu.org>
     [not found]                                               ` <<<3c22f287-5b44-4d8f-a942-a5545b2a1389@default>
     [not found]                                                 ` <<<83imc0pc13.fsf@gnu.org>
     [not found]                                                   ` <<161e718a-2213-46c8-bc9c-061dfb390e9b@default>
     [not found]                                                     ` <<83a6xbpwky.fsf@gnu.org>
2020-09-27 19:10                                                       ` Drew Adams
2020-09-28  6:00                                                         ` Eli Zaretskii
2022-04-25 15:08                                                           ` Lars Ingebrigtsen
     [not found] <<<<<87zh5xiuk4.fsf@localhost>
     [not found] ` <<<<<831rj9k79b.fsf@gnu.org>
     [not found]   ` <<<<<CADwFkmkvLnNySYVaEUhRzPMZVAfOU13NRp1GudxBmF1iuaxCxQ@mail.gmail.com>
     [not found]     ` <<<<<83sgbpiqa7.fsf@gnu.org>
     [not found]       ` <<<<<87mu1xa380.fsf@mail.linkov.net>
     [not found]         ` <<<<<83imclii71.fsf@gnu.org>
     [not found]           ` <<<<<87wo1178cn.fsf@mail.linkov.net>
     [not found]             ` <<<<<83d02tifi3.fsf@gnu.org>
     [not found]               ` <<<<<87ft7cx6kh.fsf@localhost>
     [not found]                 ` <<<<<83bli027is.fsf@gnu.org>
     [not found]                   ` <<<<<498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default>
     [not found]                     ` <<<<<87wo0nbln5.fsf@mail.linkov.net>
     [not found]                       ` <<<<<6e21964e-a580-45ef-943f-a8ea97e58eef@default>
     [not found]                         ` <<<<<87sgbadxr9.fsf@mail.linkov.net>
     [not found]                           ` <<<<<090c6fc6-92b9-4604-bb14-e19287dd6685@default>
     [not found]                             ` <<<<<87eemt7gob.fsf_-_@mail.linkov.net>
     [not found]                               ` <<<<<f84e24f3-1f56-452a-b92c-1a3421e62d92@default>
     [not found]                                 ` <<<<<83zh5crkbb.fsf@gnu.org>
     [not found]                                   ` <<<<15cf58e4-afc0-4c41-b159-29565724ddb7@default>
     [not found]                                     ` <<<<83eemor2lx.fsf@gnu.org>
     [not found]                                       ` <<<8ceca0dd-a0d8-48bb-992b-41823f7702ac@default>
     [not found]                                         ` <<<83blhsr1i7.fsf@gnu.org>
     [not found]                                           ` <<<82143311-d8b3-4a96-a103-587e1fedf9dd@default>
     [not found]                                             ` <<<83zh5cpk5q.fsf@gnu.org>
     [not found]                                               ` <<3c22f287-5b44-4d8f-a942-a5545b2a1389@default>
     [not found]                                                 ` <<83imc0pc13.fsf@gnu.org>
2020-09-27  1:17                                                   ` Drew Adams
2020-09-27  6:23                                                     ` Eli Zaretskii
     [not found] <<<<87zh5xiuk4.fsf@localhost>
     [not found] ` <<<<831rj9k79b.fsf@gnu.org>
     [not found]   ` <<<<CADwFkmkvLnNySYVaEUhRzPMZVAfOU13NRp1GudxBmF1iuaxCxQ@mail.gmail.com>
     [not found]     ` <<<<83sgbpiqa7.fsf@gnu.org>
     [not found]       ` <<<<87mu1xa380.fsf@mail.linkov.net>
     [not found]         ` <<<<83imclii71.fsf@gnu.org>
     [not found]           ` <<<<87wo1178cn.fsf@mail.linkov.net>
     [not found]             ` <<<<83d02tifi3.fsf@gnu.org>
     [not found]               ` <<<<87ft7cx6kh.fsf@localhost>
     [not found]                 ` <<<<83bli027is.fsf@gnu.org>
     [not found]                   ` <<<<498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default>
     [not found]                     ` <<<<87wo0nbln5.fsf@mail.linkov.net>
     [not found]                       ` <<<<6e21964e-a580-45ef-943f-a8ea97e58eef@default>
     [not found]                         ` <<<<87sgbadxr9.fsf@mail.linkov.net>
     [not found]                           ` <<<<090c6fc6-92b9-4604-bb14-e19287dd6685@default>
     [not found]                             ` <<<<87eemt7gob.fsf_-_@mail.linkov.net>
     [not found]                               ` <<<<f84e24f3-1f56-452a-b92c-1a3421e62d92@default>
     [not found]                                 ` <<<<83zh5crkbb.fsf@gnu.org>
     [not found]                                   ` <<<15cf58e4-afc0-4c41-b159-29565724ddb7@default>
     [not found]                                     ` <<<83eemor2lx.fsf@gnu.org>
     [not found]                                       ` <<8ceca0dd-a0d8-48bb-992b-41823f7702ac@default>
     [not found]                                         ` <<83blhsr1i7.fsf@gnu.org>
     [not found]                                           ` <<82143311-d8b3-4a96-a103-587e1fedf9dd@default>
     [not found]                                             ` <<83zh5cpk5q.fsf@gnu.org>
2020-09-26 19:32                                               ` Drew Adams
2020-09-26 19:34                                                 ` Eli Zaretskii
     [not found] <<<87zh5xiuk4.fsf@localhost>
     [not found] ` <<<831rj9k79b.fsf@gnu.org>
     [not found]   ` <<<CADwFkmkvLnNySYVaEUhRzPMZVAfOU13NRp1GudxBmF1iuaxCxQ@mail.gmail.com>
     [not found]     ` <<<83sgbpiqa7.fsf@gnu.org>
     [not found]       ` <<<87mu1xa380.fsf@mail.linkov.net>
     [not found]         ` <<<83imclii71.fsf@gnu.org>
     [not found]           ` <<<87wo1178cn.fsf@mail.linkov.net>
     [not found]             ` <<<83d02tifi3.fsf@gnu.org>
     [not found]               ` <<<87ft7cx6kh.fsf@localhost>
     [not found]                 ` <<<83bli027is.fsf@gnu.org>
     [not found]                   ` <<<498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default>
     [not found]                     ` <<<87wo0nbln5.fsf@mail.linkov.net>
     [not found]                       ` <<<6e21964e-a580-45ef-943f-a8ea97e58eef@default>
     [not found]                         ` <<<87sgbadxr9.fsf@mail.linkov.net>
     [not found]                           ` <<<090c6fc6-92b9-4604-bb14-e19287dd6685@default>
     [not found]                             ` <<<87eemt7gob.fsf_-_@mail.linkov.net>
     [not found]                               ` <<<f84e24f3-1f56-452a-b92c-1a3421e62d92@default>
     [not found]                                 ` <<<83zh5crkbb.fsf@gnu.org>
     [not found]                                   ` <<15cf58e4-afc0-4c41-b159-29565724ddb7@default>
     [not found]                                     ` <<83eemor2lx.fsf@gnu.org>
2020-09-26 15:31                                       ` Drew Adams
2020-09-26 15:39                                         ` Eli Zaretskii
2020-09-26 15:45                                           ` Lars Ingebrigtsen
2020-09-26 15:55                                             ` Eli Zaretskii
2020-09-26 16:13                                               ` Lars Ingebrigtsen
2020-09-26 16:27                                                 ` Eli Zaretskii
2020-09-26 18:58                                               ` Kévin Le Gouguec
2020-09-26 19:09                                                 ` Eli Zaretskii
2020-09-26 21:40                                                   ` Lars Ingebrigtsen
2020-09-27 10:22                                                     ` Kévin Le Gouguec
2020-09-27 12:17                                                       ` Lars Ingebrigtsen
2020-09-27 13:00                                                         ` Dmitry Gutov
2020-09-27 13:03                                                           ` Lars Ingebrigtsen
2020-09-26 16:31                                           ` Drew Adams
2020-09-26 16:39                                             ` Eli Zaretskii
2020-09-10 14:18 bug#43308: 28.0.50; Improvements to Edit->Search menu Ihor Radchenko
2020-09-10 14:59 ` Eli Zaretskii
2020-09-10 15:38   ` Stefan Kangas
2020-09-10 15:51     ` Eli Zaretskii
2020-09-10 16:19       ` Stefan Kangas
2020-09-10 16:30         ` Eli Zaretskii
2020-09-10 16:38           ` Eli Zaretskii
2020-09-10 18:36       ` Juri Linkov
2020-09-10 18:45         ` Eli Zaretskii
2020-09-10 19:14           ` Juri Linkov
2020-09-10 19:44             ` Eli Zaretskii
2020-09-20  7:15               ` Ihor Radchenko
2020-09-20  8:10                 ` Eli Zaretskii
2020-09-13 10:08 ` Ihor Radchenko
2022-04-25 10:46 ` Lars Ingebrigtsen
2022-04-25 11:36   ` Eli Zaretskii
2022-04-25 12:10     ` Lars Ingebrigtsen
2022-04-25 15:06   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=090c6fc6-92b9-4604-bb14-e19287dd6685@default \
    --to=drew.adams@oracle.com \
    --cc=43308@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=stefankangas@gmail.com \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.