From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#13764: 24.3.50; please do not use defsubst for `font-lock-(apply-highlight|fontify-anchored-keywords)' Date: Fri, 29 Apr 2016 09:17:25 -0700 (PDT) Message-ID: <090ab034-aeeb-432e-b597-a138c5c13efa@default> References: <220CC265C06944E69F89E1F29796C873@us.oracle.com> <87lh3x2wnn.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1461946723 25667 80.91.229.3 (29 Apr 2016 16:18:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2016 16:18:43 +0000 (UTC) Cc: 13764@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 18:18:30 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awB7d-00025F-Vm for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 18:18:30 +0200 Original-Received: from localhost ([::1]:55374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awB7a-0001Ba-24 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 12:18:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awB7R-0000yJ-Gj for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 12:18:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awB7F-0002Dx-Gt for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 12:18:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awB7F-0002D9-DR for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 12:18:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awB7C-0002r6-3K for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 12:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Apr 2016 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13764-submit@debbugs.gnu.org id=B13764.146194665610942 (code B ref 13764); Fri, 29 Apr 2016 16:18:02 +0000 Original-Received: (at 13764) by debbugs.gnu.org; 29 Apr 2016 16:17:36 +0000 Original-Received: from localhost ([127.0.0.1]:55582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awB6m-0002qP-4u for submit@debbugs.gnu.org; Fri, 29 Apr 2016 12:17:36 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:21669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awB6k-0002qD-D7 for 13764@debbugs.gnu.org; Fri, 29 Apr 2016 12:17:34 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3TGHRV4023457 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Apr 2016 16:17:28 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u3TGHRZp002160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Apr 2016 16:17:27 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3TGHQrb005619; Fri, 29 Apr 2016 16:17:27 GMT In-Reply-To: <87lh3x2wnn.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117208 Archived-At: > > These are not tiny, trivial functions. > > > > They do not fit the criteria for `defsubst' outlined in (elisp) > > `Inline Functions'. And they introduce all of the disadvantages > > listed there, especially this one, listed first: >=20 > [...] >=20 > > I see no reason why these function should not be defuns. >=20 > Presumably they are that way because of efficiency concerns. Have you > done benchmarking to compare the impact of these defsubsts turning into > defuns? Oh come on. Why such a presumption? Did you look at the code? Read what you quoted above. These do not fit the clearly documented criteria for `defsubst'. Do you see a reason why these should be `defsubsts'? Have you done benchmarking to support such a supposition? As they don't fit the Emacs criteria, and there is no code comment that calls out why they - exceptionally - should be defsubsts in spite of not fulfilling the criteria, a priori they should not be defsubsts. The burden of proof lies with a claim that they - exceptionally - should be. Not to mention that there is less and less need for using defsubst.