From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Tue, 29 Mar 2016 02:28:22 +0300 Message-ID: <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> References: <6ok2vyzwf9.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1459207842 11355 80.91.229.3 (28 Mar 2016 23:30:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Mar 2016 23:30:42 +0000 (UTC) Cc: Michael Albinus To: Glenn Morris , 20637@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 29 01:30:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akgcB-0005UW-6M for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2016 01:30:31 +0200 Original-Received: from localhost ([::1]:43486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akgcA-0003Oe-2p for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Mar 2016 19:30:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akgao-0000ok-Hm for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 19:29:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akgak-00030J-MB for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 19:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akgak-00030D-It for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 19:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akgak-0008OG-A2 for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 19:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Mar 2016 23:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.145920771332217 (code B ref 20637); Mon, 28 Mar 2016 23:29:02 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 28 Mar 2016 23:28:33 +0000 Original-Received: from localhost ([127.0.0.1]:42583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akgaG-0008NZ-Mx for submit@debbugs.gnu.org; Mon, 28 Mar 2016 19:28:32 -0400 Original-Received: from mail-wm0-f50.google.com ([74.125.82.50]:33136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akgaE-0008NG-Qp for 20637@debbugs.gnu.org; Mon, 28 Mar 2016 19:28:31 -0400 Original-Received: by mail-wm0-f50.google.com with SMTP id r72so34624525wmg.0 for <20637@debbugs.gnu.org>; Mon, 28 Mar 2016 16:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=+R3ST6L/4y4hEsRO7DfvgyfWuD7hZfkG9P9EYZmE9+o=; b=F8xwMOUvQmmu9qyvamCmR6Fu0Fwqx7rURVf+3sbC/dOrXwLX+ak8XVYSEY/XIP0WHo mYMaF76iUQ5E9hZz3aZAHBkvGVfgeCijEPEoXZsmtJCVtF+HUGNHJuxpSapSBmbqsFGu 1bNRxfnUUy/qli1e/xNXm98viyOkNhceiTDdyEp3e7lV/H8vBv4iyBVLkk/sZD6pXzKE W+Iw/iiWD+Leq7Tsbix7i6Epmix+kNeCmzC07Iuco9TLejY9pL+u/gFVnhM/YXDwH5DX OjP9DZMPYuzPLdJyqMuXED/3/y39Fwhj03v0huZnqeFuxKAuAFpT5BwTU+73RCmpt+8r MYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:cc:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=+R3ST6L/4y4hEsRO7DfvgyfWuD7hZfkG9P9EYZmE9+o=; b=HYaI/mR2ihhEB+pnBx5M56y1N9FjTxfYNuZ2z3WAQ1+WoYxOBVXqLj+vuCiREZgXQ5 cGtxWtux4HtfGioPGrDJal8MybpmGES65mSdNlLaJJ0oYM9zimdDQYw5vwpbrijZhRbb VEFNVG+anJ9cdpqlc9zR93AGT8gyuaoXpZr6tKkziE02fIyEDVAEXn7Yl2Z3CY7aTRNz 3v5TPfMj0Owsh3r+mk2Cz0gHDtpbvE2F1W029RgtOhFq7lDrQhgnlL1VghYWMfbVHVHR JP7lmJL8XvQhTfGlvDpzBPdzR0XkWRev5syD4JiC+7bM8vUITDO8n6kxlK5JEX8LYtNn zvBQ== X-Gm-Message-State: AD7BkJKTRPNMM3x9ZtRgbWIn6tKoVrnYHR3Hxd9BRa24iT9RUMMnivn1m3akM3gnFrBc9Q== X-Received: by 10.28.9.19 with SMTP id 19mr13577151wmj.87.1459207705247; Mon, 28 Mar 2016 16:28:25 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id hq2sm26688569wjb.3.2016.03.28.16.28.23 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Mar 2016 16:28:24 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <6ok2vyzwf9.fsf@fencepost.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115678 Archived-At: On 05/24/2015 02:49 AM, Glenn Morris wrote: > Current master: > (vc-working-revision "1") ; "master" This has been caused by the commit 7f9b037245ddb662ad98685e429a2498ae6b7c62, which made both vc-state and vc-working-revision use vc-responsible-backend instead of vc-backend. As a result, in some backends these functions started return non-nil values for unknown files or directories, as long as they lie inside a VC repository. This change is indeed backward-incompatible, and it breaks the previous assumption of some backend functions that if FILE has been passed to it, then it's surely registered with the current backend. That's why the commit included changes adding lines like (unless (memq (vc-state file) '(nil unregistered))...), but it didn't get all affected code. In particular, it breaks an assumption I made when fixing #11757, that vc-git-state never receives an unregistered file as input. So if you evaluate (vc-state "1") now, it'll return `up-to-date'. While reverting the change makes some tests fail, we should fix them in different ways. For some backends, maybe, we should accept that (vc-state default-directory) and (vc-working-revision default-directory) will return nil. Alternatively, fix that problem inside the respective backends, without changing the dispatching functions. Also, reverting this commit also seems to uncover tests that shouldn't pass anyway. Checks like (should (eq (vc-state default-directory) (vc-state default-directory backend))) don't verify much, and in this case they seem to verify the wrong thing. More on that in the respective threads in emacs-devel later. Michael, thoughts?