From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#68336: 29.1.90; eww: error when eww-retrieve-command is set to 'sync Date: Tue, 09 Jan 2024 15:54:55 +1300 Message-ID: <08d22baef8df6eee40c00ae3d14d7c49@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27813"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail To: 68336@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 03:56:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rN2Hq-0006xS-IS for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 03:56:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rN2HU-0000eh-K7; Mon, 08 Jan 2024 21:55:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN2HU-0000eZ-2n for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 21:55:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rN2HT-0007fX-Qy for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 21:55:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rN2Ha-00060u-0K for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 21:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 02:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68336 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170476892623060 (code B ref -1); Tue, 09 Jan 2024 02:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Jan 2024 02:55:26 +0000 Original-Received: from localhost ([127.0.0.1]:37970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN2Gz-0005zs-HT for submit@debbugs.gnu.org; Mon, 08 Jan 2024 21:55:26 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:45790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN2Gu-0005zX-9S for submit@debbugs.gnu.org; Mon, 08 Jan 2024 21:55:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN2Gi-0000Rt-B5 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 21:55:08 -0500 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN2Gf-0006pY-Q2 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 21:55:08 -0500 Original-Received: from [10.253.37.70] (port=34221 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1rN2GV-0007u6-Bk for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 15:54:58 +1300 Original-Received: from ip-203-94-50-131.kinect.net.nz ([203.94.50.131]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 09 Jan 2024 15:54:55 +1300 X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.43; envelope-from=psainty@orcon.net.nz; helo=smtp-2.orcon.net.nz X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277597 Archived-At: Customize `eww-retrieve-command' to `sync' -- the customize label is "Use `url-retrieve-synchronously'" -- or simply: (setq eww-retrieve-command 'sync) Now any `eww' invocation fails with: apply: Wrong type argument: stringp, nil I see the error in my builds of 29 and 30, but not in 28.2. My 30.0.50 build dated back to 2023-09-21, so I've just compiled a fresh build of 30 and no longer see the *error*, but it still doesn't work -- the page is never rendered. Example in Emacs 29: (setq eww-retrieve-command 'sync) (eww "http://example.com") Debugger entered--Lisp error: (wrong-type-argument stringp nil) eww-render(nil "http://example.com/" "http://example.com/" nil #) apply(eww-render nil "http://example.com/" ("http://example.com/" nil #)) eww-retrieve("http://example.com/" eww-render ("http://example.com/" nil #)) eww("http://example.com") Or after loading the uncompiled eww.el: Debugger entered--Lisp error: (wrong-type-argument stringp nil) set-buffer(nil) (save-current-buffer (set-buffer buffer) (plist-put eww-data :peer (plist-get status :peer)) (setq list-buffers-directory url) (setq url-current-lastloc (url-generic-parse-url url))) ... eww-render(nil "http://example.com/" "http://example.com/" nil #) That BUFFER arg to `set-buffer' looks like it's nil on account of an additional duplicate argument passed to `eww-render': eww-render(nil "http://example.com/" "http://example.com/" nil #) should have been: eww-render(nil "http://example.com/" nil #) So I think the bug is the last line here: (defun eww-retrieve (url callback cbargs) (cond ((null eww-retrieve-command) (url-retrieve url #'eww-render cbargs)) ((eq eww-retrieve-command 'sync) (let ((data-buffer (url-retrieve-synchronously url))) (with-current-buffer data-buffer (apply #'eww-render nil url cbargs)))) Where cbargs evidentially contains the URL already, so it should presumably be: (apply #'eww-render nil cbargs) I can confirm that this change fixes my example case (but I haven't tried to find out if the situation is more complicated than that). -Phil In GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2023-10-24 built on phil-lp Repository revision: cc3e436c822343f72f3ede6b638e1b68cd434583 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/home/phil/emacs/29.x.nc/usr/local --with-native-compilation=aot --with-x-toolkit=lucid --without-sound '--program-transform-name=s/^ctags$/ctags_emacs/'' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_NZ.UTF-8 value of $LC_NUMERIC: en_NZ.UTF-8 value of $LC_TIME: en_NZ.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: savehist-mode: t windmove-mode: t winner-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile savehist windmove winner ring dired-aux cl-loaddefs cl-lib dired dired-loaddefs advice rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 84935 7813) (symbols 48 7538 0) (strings 32 22145 2035) (string-bytes 1 667777) (vectors 16 16684) (vector-slots 8 344081 16889) (floats 8 35 41) (intervals 56 440 0) (buffers 984 14))