From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Change in vc-git ls-files-unknown makes emacs hang Date: Thu, 19 Dec 2019 16:41:41 +0200 Message-ID: <08cfaf0c-215f-1b02-37f8-2b3886a319c7@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="131833"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 To: emacs-devel@gnu.org, andreyk.mad@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 19 15:52:23 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ihxA5-000Y4y-U8 for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2019 15:52:22 +0100 Original-Received: from localhost ([::1]:43100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihxA4-0007jo-CA for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2019 09:52:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45194) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihwzr-0000sZ-B8 for emacs-devel@gnu.org; Thu, 19 Dec 2019 09:41:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihwzq-0002fg-7L for emacs-devel@gnu.org; Thu, 19 Dec 2019 09:41:47 -0500 Original-Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:42181) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihwzp-0002Wx-UQ for emacs-devel@gnu.org; Thu, 19 Dec 2019 09:41:46 -0500 Original-Received: by mail-ed1-x542.google.com with SMTP id e10so5090038edv.9 for ; Thu, 19 Dec 2019 06:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/3C7CQel4kDhOr5AtlRp8ZLf3yEybfZOyDpg+LcDcc8=; b=UQAL9ZP+0eVT1X1ZcLyxDvy7a+b6t+1a0mwRPZ09Jt8l21s5J9i1H579Pq5idie89Q SZUQGHZIIqlg2S8WZB0KVmbrfKsVmwF5OgMYUhUtnYAMoChjZUwPh2aMQNviVy6qWQA1 Bi9gUnIWf2Z+TiN32prKJ6EUKxPP+74Fdet25gKBnRL86KYYzdVibYXo2DtQlf9KrAR9 9QhyflUk3ghTsR1cm3w2M/KKw7hDUF7vLVWGNq0EzZP/eEpAeIrBmfTItxNbKF1n5/Xs Z2Ew78Ade4RgDhiGNgHXjAjBX/b63llwF4F0fvz/qiv9itFc/2T2NLHm6rzgLEJePZxH Pp8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/3C7CQel4kDhOr5AtlRp8ZLf3yEybfZOyDpg+LcDcc8=; b=qlvjsrg6dTsp3mPzTZDAM3VH3L/Mfkxvx6PcAk8mAs3vmHMddiFERrjZZCDDonZZrD FVXADrx/ZZ6QeWYtKFe13SNXD/H1nowbvunLWiH/A2au6Ix5P+F8aFgXGRuhKoxYOafz 32oqfoDZ+hlzCM5w03HJbEWDRDaDBTyVVzI323cW7wwfycFp0hajMV2QYuc4dkCgm0Za A6Ymv32xXAkWQ2DgWiIR7KDvvajrU4vVFhzXmFtZ3uQQrrR4d6Yq4200+ugCInsPUmCV AiPx2pKEJfNzQ8/ef80mF7Plhx63sk7kHDZuPYBd+FlbLYK42G5GnZ8C3MOI+Vs9W/wI kcwg== X-Gm-Message-State: APjAAAXAyi6gMd6nNqkVjLlUcOPzAzUuH6aBqaTgJrIVH1/XDXhCv+i6 4V9hPbiJCSzgkJFs8OSCNvo= X-Google-Smtp-Source: APXvYqwP0D4rz5m/KroJeEuJyVjQXL6OQx+pNyS/KXMlwrXHDMhQ1tv0BaPlU2OcjZ9QB9qQy76ovA== X-Received: by 2002:a17:907:398:: with SMTP id ss24mr9474386ejb.317.1576766504321; Thu, 19 Dec 2019 06:41:44 -0800 (PST) Original-Received: from [192.168.0.149] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id n10sm536456ejk.67.2019.12.19.06.41.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Dec 2019 06:41:43 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::542 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243475 Archived-At: Hi Filipp, On 19.12.2019 16:16, Filipp Gunbin wrote: > Hi, this commit makes Emacs hang and become unusable, this happens when > loading the desktop. Quitting doesn't unfreeze, so I can't get the > backtrace. I'm on macOS, tty emacs. I'm the one who reviewed that patch. Could you figure out under what circumstances that code (vc-git-dir-status-goto-stage which triggers the freeze) gets called while loading the desktop? In particular, for which directory (but which list of files is passed to vc-git-dir-status-files might also be important). And after you figure that out, does VC-Dir work okay in it? Since backtrace is hard to get, how about some print-debugging with logging to a file? write-region should help. UUIC, the only case where this change should lead to a performance problem is a Git repository with lots of unregistered files. Ones not hidden by gitignore.