From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, andreyk.mad@gmail.com
Subject: Re: Change in vc-git ls-files-unknown makes emacs hang
Date: Thu, 19 Dec 2019 16:41:41 +0200 [thread overview]
Message-ID: <08cfaf0c-215f-1b02-37f8-2b3886a319c7@yandex.ru> (raw)
In-Reply-To: <m28sn8bduc.fsf@fastmail.fm>
Hi Filipp,
On 19.12.2019 16:16, Filipp Gunbin wrote:
> Hi, this commit makes Emacs hang and become unusable, this happens when
> loading the desktop. Quitting doesn't unfreeze, so I can't get the
> backtrace. I'm on macOS, tty emacs.
I'm the one who reviewed that patch.
Could you figure out under what circumstances that code
(vc-git-dir-status-goto-stage which triggers the freeze) gets called
while loading the desktop? In particular, for which directory (but which
list of files is passed to vc-git-dir-status-files might also be
important). And after you figure that out, does VC-Dir work okay in it?
Since backtrace is hard to get, how about some print-debugging with
logging to a file? write-region should help.
UUIC, the only case where this change should lead to a performance
problem is a Git repository with lots of unregistered files. Ones not
hidden by gitignore.
next prev parent reply other threads:[~2019-12-19 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 14:16 Change in vc-git ls-files-unknown makes emacs hang Filipp Gunbin
2019-12-19 14:41 ` Dmitry Gutov [this message]
2019-12-19 20:44 ` Filipp Gunbin
2019-12-19 22:42 ` Dmitry Gutov
2019-12-20 7:33 ` Eli Zaretskii
2019-12-20 10:52 ` Filipp Gunbin
2019-12-20 14:13 ` Dmitry Gutov
2019-12-20 15:36 ` Filipp Gunbin
2019-12-20 15:40 ` Dmitry Gutov
2019-12-20 17:14 ` Filipp Gunbin
2019-12-20 22:18 ` Dmitry Gutov
2019-12-21 21:51 ` Proced signals (was: Change in vc-git ls-files-unknown makes emacs hang) Juri Linkov
2019-12-22 17:02 ` Eli Zaretskii
2019-12-19 20:45 ` Change in vc-git ls-files-unknown makes emacs hang Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cfaf0c-215f-1b02-37f8-2b3886a319c7@yandex.ru \
--to=dgutov@yandex.ru \
--cc=andreyk.mad@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.